From nobody Fri Feb 14 10:41:00 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YvT9S5jNtz5p7nS; Fri, 14 Feb 2025 10:41:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YvT9S3F7Yz455x; Fri, 14 Feb 2025 10:41:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739529660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pNjUOAF+gawMlPV/zAzwD21p/AHhDNLCnY9ecyQAmko=; b=Okrmi6NNFLTII34NqSkqfksZPQzYOojbxsPtQ3mK+FWn8J3oLi+KzQNYOQ9LANFX7S3RNp xoCidENv1uQn6ByvLA2+UiGoFlpXRDGSu6GKpl0D16ImyXKUMGuhNGFmGaZM4OWzVGLf7l BxlynMcx0ElaSkkfSAoMasVkBRU6koHtUTMHfQPIOFOhB3xaHF48OCFyh8F9SPpdLLRfCw a9+nFqvVlniu6fqdpfiw9i/jYPeQX5jMUoVjbobo0zM1b8Q3FsJchFOIN5t/rDD4vHu3qb yJrlVqwoV6TSlA13rpSvqbN/20HDLFVwbtDjydn5KC+DjtqDBKIZO6WvEnmygA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739529660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pNjUOAF+gawMlPV/zAzwD21p/AHhDNLCnY9ecyQAmko=; b=pFsqQRKbx9syyjIqw9q9Uq0TXa/L6uTh5us0U95W/OY5UaOv0V/M7uGidAK4foO9eDJ0Dg 9hXyv60EjVs+3FkBb11BrcWurrNx1uPa3VQ1J5sdSmjO55foBst+XFG/8VkipxSSRvIJJ4 BzyUuFHJljfzI2yFiHgvVtxG/X9HP/Di/bw88SGG25GzQybxZwtKqITWeNflqk207tltHc 4SFibLGWrUA9IG2DUgHiiCO8O9W5Yp3NTBNE97v1BZ/5FzzfQDB5VYcYz+xVxfoP73ov72 x9BN2bUoRTxK/ehs1l54SpLePUyFdictgPxKjqpRBl+revVUgJgG7ieff6HHcg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739529660; a=rsa-sha256; cv=none; b=BsxQcX1TIyzwYXCoVEtekcoEi59aJfvh7Q/2Dc3ORuPhrXaZLJoCU6gdHt5jNb0hHpUGB4 eQRUuUBrJ6xJfdwqFuyqij3Mjc46QJuGJnyCAYCydBjMdUlO3GE230HqfLRQw39Ec6C44e bI33zS3nDlcZ1XnIZXCm4dVAg+LZylRythSsMudMCQdM2WQ580S6aoVowSOFCiI6MdyFEO OA45p6JHinEfCw8KT3EhG7pTMk6YgEXX5rkJJwLMn7+t/xI4Q++sXMrkWDyysmED5GzNW1 vmP3q7dAgivt+l8MH1NjzDHOABO8asKo+Sdxla47MoQItL51arEEqYCrOQ7ALg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YvT9S2VmXzBJk; Fri, 14 Feb 2025 10:41:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51EAf0Oq061177; Fri, 14 Feb 2025 10:41:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51EAf0uf061174; Fri, 14 Feb 2025 10:41:00 GMT (envelope-from git) Date: Fri, 14 Feb 2025 10:41:00 GMT Message-Id: <202502141041.51EAf0uf061174@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: 747fd2db538a - main - bnxt_en: Remove pointless NULL check for sysctl arg1 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 747fd2db538a85df84ae6ac1e58494295b4a65ee Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=747fd2db538a85df84ae6ac1e58494295b4a65ee commit 747fd2db538a85df84ae6ac1e58494295b4a65ee Author: Zhenlei Huang AuthorDate: 2025-02-14 10:38:30 +0000 Commit: Zhenlei Huang CommitDate: 2025-02-14 10:38:30 +0000 bnxt_en: Remove pointless NULL check for sysctl arg1 Those sysctl handlers have been guaranteed to have non-null softc. No need for NULL check within sysctl handlers. No functional change intended. Reviewed by: markj Tested by: Daniel Porsch MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D48495 --- sys/dev/bnxt/bnxt_en/bnxt_sysctl.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c b/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c index a8ae1d41d501..9c2d5bebbce7 100644 --- a/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c +++ b/sys/dev/bnxt/bnxt_en/bnxt_sysctl.c @@ -1792,9 +1792,6 @@ bnxt_dcb_dcbx_cap(SYSCTL_HANDLER_ARGS) int val; int rc; - if (softc == NULL) - return EBUSY; - val = bnxt_dcb_getdcbx(softc); rc = sysctl_handle_int(oidp, &val, 0, req); if (rc || !req->newptr) @@ -1944,9 +1941,6 @@ bnxt_dcb_list_app(SYSCTL_HANDLER_ARGS) int rc, num_inputs = 0; char *buf; - if (softc == NULL) - return EBUSY; - #define BNXT_APP_TLV_STR_LEN 4096 buf = malloc(BNXT_APP_TLV_STR_LEN, M_DEVBUF, M_NOWAIT | M_ZERO); if (!buf) @@ -1972,9 +1966,6 @@ bnxt_dcb_del_app(SYSCTL_HANDLER_ARGS) char buf[256] = {0}; int rc, num_inputs; - if (softc == NULL) - return EBUSY; - rc = sysctl_handle_string(oidp, buf, sizeof(buf), req); if (rc || req->newptr == NULL) return rc; @@ -1999,9 +1990,6 @@ bnxt_dcb_set_app(SYSCTL_HANDLER_ARGS) char buf[256] = {0}; int rc, num_inputs; - if (softc == NULL) - return EBUSY; - rc = sysctl_handle_string(oidp, buf, sizeof(buf), req); if (rc || req->newptr == NULL) return rc; @@ -2029,9 +2017,6 @@ bnxt_dcb_pfc(SYSCTL_HANDLER_ARGS) int pri_mask = 0; char pri[8]; - if (softc == NULL) - return EBUSY; - rc = bnxt_dcb_ieee_getpfc(softc, &pfc); if (!rc) bnxt_pfc_get_string(softc, buf, &pfc); @@ -2087,9 +2072,6 @@ bnxt_dcb_ets(SYSCTL_HANDLER_ARGS) char buf[256] = {0}; char tsa[8]; - if (softc == NULL) - return EBUSY; - rc = bnxt_dcb_ieee_getets(softc, &ets); if (!rc) bnxt_ets_get_string(softc, buf);