From nobody Tue Feb 11 01:11:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YsNhC2yPFz5n7ft; Tue, 11 Feb 2025 01:11:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YsNhC2RJxz3mBD; Tue, 11 Feb 2025 01:11:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739236315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7CyK7Xg0BhR+VFWHUzTEyxo3h0BA5swauEUAJh7PqRA=; b=dLuAwGgOjRiof5LyQElZJ5Nd2Cm2ENPlU1sRG7Tg4HCT+gdSFIqTzKSglt/TLCVomFcHCv 97y3ilFnELdoA6s4r1FewtO7qhZ0CtlT4oMk40ZY+aTtA9qAp3k9L3kXNJNew0i4W6l8Ew N749nD4NaJHLZngXv35wH9Aol5nnXRVGJCbYslHizbK9EUlRF2cqws8D3ZWGuFH+WgvRGP zfLXGaZCsUlKfF6QKzB+ohwYqZJlme1e7hZso6bjuMvJ4Kjlaye4ijZlJR1qTeme7pdFtI JIzGz49511jhiAV8kHkuHAXIKBI/GTXhzmNxHTKtufGiht0//Kw1xABCCaIvbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1739236315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7CyK7Xg0BhR+VFWHUzTEyxo3h0BA5swauEUAJh7PqRA=; b=Lfozlea4GitWAONSK86EDxM72ZhQsReUJ/jkG/olnJ6HKom+q6yjyX6cX/FGmapP0e77q/ lzyxy6aWqKpToaZGBmU38Ab6P46ccUPI2WnoHcPaZoiKxJc7v8ix8TGqUqEqr624R/8zk4 KOTCB/O5uwItUnMHKTHVHDKaTznKfP4MzOXmQJ5DwpU/7p77x6j0EX+kGazxrP17RMaC1X lhregathdh+2xtCgRd6r+XCv7LbLEE0y1oc64gP8VVvfTOx3LuihkOMGY4fr5xUUnl7z2Y 5PX36RsENKa9uX5jrHNTs2Pkgyq+QUrPwRv+doYpC/1N3W+5VB5TSapcATctuQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1739236315; a=rsa-sha256; cv=none; b=P0Px0Q8EDGHodg8a2ur40HeiyYeE7aLvcShxfgFZL1yzOxXmboVmejwD+4W5sYWUVmCYDy qG3i7qH39wQp1OLXcb66FhqpP7Pxvv0b7lFJmCFqjw29qUF5MKcdrCruob5DYY4Ya8IVBX WdFVouE743Jqa/qKdnSk/kRgTaY/sk9mHaYIK7EopHZamo1Yhe9T4CgKB1v40Y4GqNxyM5 Ozt5uFXL2boQZiepfxNGbsANvLIr74fSQEJ5bnMvDHdEM7TzKkCe1kRs3ZvW/g+lutMftN PT/hSeCWaYZwj0afpO5xvOUlJQPnIF9nYR3jwJ6xjy744TAgFEdm7zGhhkWR0A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YsNhC1slrzrs7; Tue, 11 Feb 2025 01:11:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 51B1BtJm088070; Tue, 11 Feb 2025 01:11:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 51B1Bt3E088067; Tue, 11 Feb 2025 01:11:55 GMT (envelope-from git) Date: Tue, 11 Feb 2025 01:11:55 GMT Message-Id: <202502110111.51B1Bt3E088067@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: cba91bf59c79 - stable/14 - unlink, rmdir: call notify_upper from VOP pre method instead of syscall List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: cba91bf59c79eadc3b60b83fe2185116496f08fb Auto-Submitted: auto-generated The branch stable/14 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=cba91bf59c79eadc3b60b83fe2185116496f08fb commit cba91bf59c79eadc3b60b83fe2185116496f08fb Author: Konstantin Belousov AuthorDate: 2025-02-04 00:23:05 +0000 Commit: Konstantin Belousov CommitDate: 2025-02-11 01:11:49 +0000 unlink, rmdir: call notify_upper from VOP pre method instead of syscall PR: 254210 (cherry picked from commit 1a0cb938f7b461edc40316cb44a80438df674174) --- sys/kern/vfs_subr.c | 2 ++ sys/kern/vfs_syscalls.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 729741ea901f..5a0a7f9161ed 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -6157,6 +6157,7 @@ vop_remove_pre(void *ap) a = ap; dvp = a->a_dvp; vp = a->a_vp; + vfs_notify_upper(vp, VFS_NOTIFY_UPPER_UNLINK); vn_seqc_write_begin(dvp); vn_seqc_write_begin(vp); } @@ -6225,6 +6226,7 @@ vop_rmdir_pre(void *ap) a = ap; dvp = a->a_dvp; vp = a->a_vp; + vfs_notify_upper(vp, VFS_NOTIFY_UPPER_UNLINK); vn_seqc_write_begin(dvp); vn_seqc_write_begin(vp); } diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index 45a9a0c2bd48..17ab419fb0ae 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -1996,7 +1996,6 @@ restart: if (error != 0) goto out; #endif - vfs_notify_upper(vp, VFS_NOTIFY_UPPER_UNLINK); error = VOP_REMOVE(nd.ni_dvp, vp, &nd.ni_cnd); #ifdef MAC out: @@ -3964,7 +3963,6 @@ restart: goto fdout; goto restart; } - vfs_notify_upper(vp, VFS_NOTIFY_UPPER_UNLINK); error = VOP_RMDIR(nd.ni_dvp, nd.ni_vp, &nd.ni_cnd); vn_finished_write(mp); out: