From nobody Wed Feb 05 21:50:04 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YpDRh312Nz5mSQl; Wed, 05 Feb 2025 21:50:08 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YpDRg6dQdz3jcc; Wed, 05 Feb 2025 21:50:07 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTPS id fefftrp83yLQGfnHbtkKxV; Wed, 05 Feb 2025 21:50:07 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id fnHZt2kmel5eGfnHattzxz; Wed, 05 Feb 2025 21:50:07 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=EO6l0EZC c=1 sm=1 tr=0 ts=67a3dd0f a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=T2h4t0Lz3GQA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=ICHTZM_y5o49PRjEHbcA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id E5D02265; Wed, 05 Feb 2025 13:50:04 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 6F61118A; Wed, 05 Feb 2025 13:50:04 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Konstantin Belousov cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 53ece2bea9ff - main - audit(9): do not touch VFS if panicing In-reply-to: <202502052142.515Lg7O9095895@gitrepo.freebsd.org> References: <202502052142.515Lg7O9095895@gitrepo.freebsd.org> Comments: In-reply-to Konstantin Belousov message dated "Wed, 05 Feb 2025 21:42:07 +0000." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 05 Feb 2025 13:50:04 -0800 Message-Id: <20250205215004.6F61118A@slippy.cwsent.com> X-CMAE-Envelope: MS4xfOxVnQJkR6EH3VtpNmrImyhCk08QQMSFQQI9mA250Kxj623czgRAxCL5NOPy7AHw1EGmk2xhQ/yXT2ZTfWs1OVDGRzqfH+fzQBux5RRuET8mifQrO1z4 EcdylLih/Lu2doxdC8LGkZroar68Bsoqe/sp+v9JyQT8Bag985jsNSKY9xVbfouT3lVSls9r9aA7npocOfpmLPOngBqLjJBgtxSxJJku1GuVKeLnI48CZDvg YyertxwKoaE1xlle/t0cL7MGto+g87oYh/9iaJMsDptmF578OC/GvUZgCOCQ9K4/jwVZzlpN6RXXcPsmTM8Oajt0mAwym841z8e1TBjra8s= X-Rspamd-Queue-Id: 4YpDRg6dQdz3jcc X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] In message <202502052142.515Lg7O9095895@gitrepo.freebsd.org>, Konstantin Belous ov writes: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=53ece2bea9ffa654aaa50e5ed6634116 > 0194179f > > commit 53ece2bea9ffa654aaa50e5ed66341160194179f > Author: Konstantin Belousov > AuthorDate: 2025-01-30 10:45:04 +0000 > Commit: Konstantin Belousov > CommitDate: 2025-02-05 21:41:01 +0000 > > audit(9): do not touch VFS if panicing > > Reported by: bz > --- > sys/security/audit/audit.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sys/security/audit/audit.c b/sys/security/audit/audit.c > index 269e62db454a..8a9865bf233b 100644 > --- a/sys/security/audit/audit.c > +++ b/sys/security/audit/audit.c > @@ -396,7 +396,8 @@ SYSINIT(audit_init, SI_SUB_AUDIT, SI_ORDER_FIRST, audit_i > nit, NULL); > void > audit_shutdown(void *arg, int howto) > { > - > + if (KERNEL_PANICED()) Should this not be KERNEL_PANICKED? > + return; > audit_rotate_vnode(NULL, NULL); > } > > -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0