From nobody Wed Feb 05 20:55:52 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YpCF51Yh0z5mNV8; Wed, 05 Feb 2025 20:55:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YpCF514HDz3VN4; Wed, 05 Feb 2025 20:55:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738788953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uBBM+HLWxO5iTUqBdn3PAM41IZDHaIeUcgzEm2k5TDU=; b=OcRrcMpSfP+Gdcf7ffTVIHWeETvVajAvkUWaW9ZKUCE52XT6VIpXpxDYxNgQmWA4nkTkxE 4xXjbJJyXIoQZTsT9bXnByiP07jg6YQXuIzQwC3YZki/fcCZ7UlPq3IZGg6ip6lRgGs5Kq Z5eAA6iYLYkmngqSC5g8zK0vX9UqPgaH3PPoOH3jXvoa4qG3bj10EMUSQgfxFw3Jc6+DWM +T+jKd3IcxqTIaHsJ16UXuJiZL3A8iaqj0nux/e74G5YQruKoKVAOBfL1p4k+Yz7HHoQiS flQBXn7ZxOAckbK+Q4vJO2/WAb0keCR45Rrbayuqq/a9J+ODYyz5XAy4pI5wiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738788953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uBBM+HLWxO5iTUqBdn3PAM41IZDHaIeUcgzEm2k5TDU=; b=VVzaG8LHgoRTHYBB/+LF+TT0uv8TEMLBI0rmJXkzcxq/U9BoeZPShnQBnQV0AY2k5MTvPw 0hhHqg87OToi4GUSXMDsMotY/tOotpGq0/mjDoXdchq15eUUNgHewR03plo1gJHTP+u6LS CAYi4ffBxD3JsWbIg7hHEtVlYqoqXKUBw/EN0nC1PviPfj7mOdKGooxDpaP1lcFERajOZi UIosVDp2iCGGOkHwsXaT4Unoa3wp2chivtkTB7VOsBfOU78mvrgVY1A+RdELS/UzeKeeKo d/zLCIe/aAT7Cg20xzMua1AOJvVohUy023wDveR522KIhMFUdxGSc9vGEEuX8Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738788953; a=rsa-sha256; cv=none; b=THRjkGFnuEJWSARs4GZTZ9hGqOsN1aMvBQxt1XCNqEWIkOQF/k+PlweacvbsvRqMdd0+jl YpkylRO8aBdaXYTQhHGeojX5g9LV6XzecrbqO1JUisIBlln1hiHbXVglp3owI0Z4ji0ZTj R/z8GaxNwNVdZb8q41a4pgd9aGjABdR3Jjn1XTRqsDRYNMMlvOlGH1+Q1lf2X4X1wsbq3H 5UE1vMUQ/qrdORNjjK3JPsZEAJM1B8OO0+6TuCxypouvHVh1TIehVj6ctpJhECZRMan8ig o282IynEBBdTMauUPcy1a6h0j4lj+FgOSbELo99762DaLLktRWVBqIql+h05PQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YpCF50cxgz16wN; Wed, 05 Feb 2025 20:55:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 515Ktqik004403; Wed, 5 Feb 2025 20:55:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 515Ktqcj004400; Wed, 5 Feb 2025 20:55:52 GMT (envelope-from git) Date: Wed, 5 Feb 2025 20:55:52 GMT Message-Id: <202502052055.515Ktqcj004400@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 7edc7c8f6f97 - stable/13 - TCP BBR: remove dead code List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 7edc7c8f6f975ee437124534bbd59ee4ba42b66d Auto-Submitted: auto-generated The branch stable/13 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=7edc7c8f6f975ee437124534bbd59ee4ba42b66d commit 7edc7c8f6f975ee437124534bbd59ee4ba42b66d Author: Michael Tuexen AuthorDate: 2025-01-06 19:40:33 +0000 Commit: Michael Tuexen CommitDate: 2025-02-05 20:41:04 +0000 TCP BBR: remove dead code bw is unsigned and not zero. So it cannot be smaller than 1. No functional change intended. Reviewed by: rrs, cc CID: 1523791 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48323 (cherry picked from commit c28fefe1dc44b69743dd18d038440da38a2867a7) --- sys/netinet/tcp_stacks/bbr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c index cc39884a3e33..1fd41b568e1f 100644 --- a/sys/netinet/tcp_stacks/bbr.c +++ b/sys/netinet/tcp_stacks/bbr.c @@ -3008,9 +3008,6 @@ use_initial_window: /* We should not be at 0, go to the initial window then */ goto use_initial_window; } - if (bw < 1) - /* Probably should panic */ - bw = 1; if (bw < min_bw) bw = min_bw; return (bw);