From nobody Tue Dec 30 04:17:14 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dgKYn0FLDz6MnLy for ; Tue, 30 Dec 2025 04:17:33 +0000 (UTC) (envelope-from khng300@gmail.com) Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dgKYl4fFQz3bc4 for ; Tue, 30 Dec 2025 04:17:31 +0000 (UTC) (envelope-from khng300@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=SACTh3+V; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of khng300@gmail.com designates 2001:4860:4864:20::35 as permitted sender) smtp.mailfrom=khng300@gmail.com Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-3fe9d6179efso1148084fac.1 for ; Mon, 29 Dec 2025 20:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767068245; x=1767673045; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hZrIeaYTRpWI/V1lQcYUDwkEsK20+xQ44ieIQ0pqK3E=; b=SACTh3+VTlXOftisv3sgr5y8GL9Ej8t2verKUgQabhDt4fdxMrlN/1JCr0SRK3dl42 IyaLK6LSi7NyAUneDrj95CVsft7Y7A36CZxf5tzNuA/aTxtEOOzzWmvFZQGtViKdKBoC 7kh5Zo2gLm1ehZnd41/vOx3IZcdbmGcHAbs47ZaDLsgO8WHgjNAbbcA4LXm9khmW9oil f6i2sqlf0yCdaXqerezbp8S4E/1RpgRaNuKHqiJGvs1vBO77VUA6dSKou4WYA/WLHDHv iukMoMDdnWGVQjHwGBf32AqtDCrhFPBtOsxXXI1RCZZn6aXFl7eNDNU5VAM6p9H/0xAM rPtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767068245; x=1767673045; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hZrIeaYTRpWI/V1lQcYUDwkEsK20+xQ44ieIQ0pqK3E=; b=Ql6lcswAQHsksZv3zrGTOJsET7lgtihu6TZTi7Wa03un2g193f0yi+cuLeR7fxBQgA b5kUHZOobR59N256Z01HMDGD7CJQ1trCUBouFwRwlnkO7kszIsTwEsudl5w/GEp4jw9t U2mqNSmTezjRHCX5kJiTz8J04tmnMU/QyrqvETuhhDOBpunR8gYqp/NsnPD0EnxqzVLC f9/C5F7U1Ek4vtkY4WK276+BpZwnQpbNo06VRygG0Jy4BuxGARM5ercSd4jBVm+P8w+2 6vWAL5iRu6CMx2XbAXcC3rZJZra9/yrbMekWIWxMH2DVKz7RX6iDTRIaPUp9rHWfc8Zn 4ruw== X-Forwarded-Encrypted: i=1; AJvYcCU/yz1vIO3RE6fZQuUoBZc84aCoCl0dKIqsZLBUo11rmoS2s4fu56Nx/SoOiGGONkrGBa3/F2HZZd6sXUULOqKlPqiQ@freebsd.org X-Gm-Message-State: AOJu0YwXSM2jEsnEsVm6JmoAQV8/nMeCtODkeTTMOw/vfRQ2qBaZNzRZ JoVi4pBlXRBqMzQP0PDqaxQiI0e9Ha8/ZC+3HvEdHwOLzHiVQ2AxanwGnVl6VZr5Ah/LOBRGNX9 kpm10cNjERuIWVQvebrLFnItPxLS00Mc= X-Gm-Gg: AY/fxX4l1fZM7I0NKxuFh8JE+hOE9WzcE7QzCSvhGPXEOo4M4rHFlnUNSm6X/jDwoRF UXDcdP8PB9DuzzpA61uRk0RJW6CgOOrNsdtTyT1uSZ6s8WCw4RS4F6AYSCm6CCYK8f+5336659S YCuZQzUWvQ4wYjYVQg8WHKWNyKcX2GPGtTaWXE+MertWdtctQo/vdB3ewJXqZFc9xDc20kNsVQT EltEC4WxiHq7Hskp4jmOF/KlQLjRZzBonxymZ0dDPjfsjZtfF3QHzcC3Ku63AEWBvO5JrnwYxMS nXdifbHHBFm6BF1aumcSSFuHGNc1B3r19p+8uvWz X-Google-Smtp-Source: AGHT+IEO0NypnSLYeH+wiJmIUdxVOe8SQPjX+ol64Ec5gMJCHLl9mg8foSaTTmo5FREeaes3XYkLNngU7pz72qED+4M= X-Received: by 2002:a4a:ddc1:0:b0:65b:2b26:8022 with SMTP id 006d021491bc7-65cfe667108mr13765193eaf.6.1767068245631; Mon, 29 Dec 2025 20:17:25 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <69489316.252e6.179063dd@gitrepo.freebsd.org> In-Reply-To: From: Ka Ho Ng Date: Mon, 29 Dec 2025 23:17:14 -0500 X-Gm-Features: AQt7F2qS32NMYLMjKObaibR4dGkiwC66bHH-tyLCWrH3dxnsft9fjkXhdCwivLk Message-ID: Subject: Re: git: 112c453ba910 - stable/15 - geom(9): struct bio KBI fix To: Konstantin Belousov Cc: Kristof Provost , Ka Ho Ng , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Content-Type: multipart/alternative; boundary="00000000000013296d064723a3b4" X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.985]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; R_SPF_ALLOW(-0.20)[+ip6:2001:4860:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; FREEMAIL_TO(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_TLS_LAST(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2001:4860:4864:20::35:from]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; BLOCKLISTDE_FAIL(0.00)[2001:4860:4864:20::35:server fail]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_COUNT_ONE(0.00)[1]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_FIVE(0.00)[6] X-Rspamd-Queue-Id: 4dgKYl4fFQz3bc4 --00000000000013296d064723a3b4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 29, 2025 at 11:08=E2=80=AFPM Ka Ho Ng wrote= : > On Mon, Dec 29, 2025 at 10:51=E2=80=AFPM Konstantin Belousov > wrote: > >> On Mon, Dec 29, 2025 at 10:22:50AM +0100, Kristof Provost wrote: >> > On 22 Dec 2025, at 1:38, Ka Ho Ng wrote: >> > > The branch stable/15 has been updated by khng: >> > > >> > > URL: >> https://cgit.FreeBSD.org/src/commit/?id=3D112c453ba91012f19ed140c56a3ac8= fc929ddabb >> > > >> > > commit 112c453ba91012f19ed140c56a3ac8fc929ddabb >> > > Author: Ka Ho Ng >> > > AuthorDate: 2025-12-21 22:45:03 +0000 >> > > Commit: Ka Ho Ng >> > > CommitDate: 2025-12-22 00:37:40 +0000 >> > > >> > > geom(9): struct bio KBI fix >> > > >> > > The struct bio was changed after cb85c2e2e995 on the branch. To >> fix >> > > this, move BIO_ERROR flag to another value, and now >> BIO_ERROR_COMPAT >> > > occupies 0x1 instead. Also, introduce b_error_compat field at th= e >> > > place >> > > where the old bio_error was. >> > > >> > > This allows non-CAM(9) disk drivers and software volume manager >> > > modules >> > > compiled against 15.0-RELEASE kernel to work on 15-STABLE kernel >> > > again. >> > > >> > > Reviewed by: kib >> > > Differential Revision: https://reviews.freebsd.org/D54327 >> > > >> > > Approved by: re (cperciva) >> > >> > I=E2=80=99m seeing panics on boot now: >> > >> > vtnet0: Ethernet address: 58:9c:fc:0c:60:85 >> > vtnet0: netmap queues/slots: TX 1/1024, RX 1panic: Memory >> modified after >> > free 0xfffff800038b51a8 (424, g_bio) + 0 =3D deadc0dedeacc0de >> > >> > cpuid =3D 6 >> > time =3D 1 >> > KDB: stack backtrace: >> > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame >> > 0xfffffe008d5679a0 >> > vpanic() at vpanic+0x136/frame 0xfffffe008d567ad0 >> > panic() at panic+0x43/frame 0xfffffe008d567b30 >> > trash_ctor() at trash_ctor+0x74/frame 0xfffffe008d567b40 >> > item_ctor() at item_ctor+0x59/frame 0xfffffe008d567b90 >> > g_clone_bio() at g_clone_bio+0x1d/frame 0xfffffe008d567bb0 >> > g_part_start() at g_part_start+0x96/frame 0xfffffe008d567c40 >> > g_io_request() at g_io_request+0x2ca/frame 0xfffffe008d567c70 >> > g_read_data() at g_read_data+0x95/frame 0xfffffe008d567cb0 >> > g_raid_md_taste_intel() at g_raid_md_taste_intel+0x1d8/frame >> > 0xfffffe008d567e50 >> > g_raid_taste() at g_raid_taste+0x18e/frame 0xfffffe008d567ea0 >> > g_new_provider_event() at g_new_provider_event+0xaa/frame >> > 0xfffffe008d567ec0 >> > g_run_events() at g_run_events+0x104/frame 0xfffffe008d567ef0 >> > fork_exit() at fork_exit+0x82/frame 0xfffffe008d567f30 >> > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe008d567f3= 0 >> > --- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 --- >> > KDB: enter: panic >> > [ thread pid 13 tid 100069 ] >> > Stopped at kdb_enter+0x33: movq $0,0x121aa92(%rip) >> > db> >> > >> > With this commit (and the follow-up =E2=80=9Cgeom(9): unset the BIO_ER= ROR_COMPAT >> > flag correctly=E2=80=9D) reverted the VM boots again. >> >> Does the following help? >> >> diff --git a/sys/kern/vfs_bio.c b/sys/kern/vfs_bio.c >> index dc90bd3add22..2368f863a248 100644 >> --- a/sys/kern/vfs_bio.c >> +++ b/sys/kern/vfs_bio.c >> @@ -4523,8 +4523,6 @@ biodone(struct bio *bp) >> bp->bio_flags |=3D BIO_ERROR_COMPAT; >> } >> done(bp); >> - bp->bio_error_compat =3D 0; >> - bp->bio_flags &=3D ~BIO_ERROR_COMPAT; >> } >> } >> >> >> Yep that fixes the issue. I committed this as 9cfd75a6f88f. > > Ka Ho > + the missing recipients and the mailing lists. Ka Ho --00000000000013296d064723a3b4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Dec 29, 2025 at 11:08=E2=80=AFPM = Ka Ho Ng <khng300@gmail.com>= wrote:
On Mon, Dec 29, 2025 at 10:51=E2=80=AFPM Konstantin Belousov &= lt;kostikbel@gmail= .com> wrote:
On Mon, Dec 29, 2025 at 10:22:50AM +0100, Kristo= f Provost wrote:
> On 22 Dec 2025, at 1:38, Ka Ho Ng wrote:
> > The branch stable/15 has been updated by khng:
> >
> > URL: htt= ps://cgit.FreeBSD.org/src/commit/?id=3D112c453ba91012f19ed140c56a3ac8fc929d= dabb
> >
> > commit 112c453ba91012f19ed140c56a3ac8fc929ddabb
> > Author:=C2=A0 =C2=A0 =C2=A0Ka Ho Ng <khng@FreeBSD.org>
> > AuthorDate: 2025-12-21 22:45:03 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Ka Ho Ng <khng@FreeBSD.org>
> > CommitDate: 2025-12-22 00:37:40 +0000
> >
> >=C2=A0 =C2=A0 =C2=A0geom(9): struct bio KBI fix
> >
> >=C2=A0 =C2=A0 =C2=A0The struct bio was changed after cb85c2e2e995 = on the branch. To fix
> >=C2=A0 =C2=A0 =C2=A0this, move BIO_ERROR flag to another value, an= d now BIO_ERROR_COMPAT
> >=C2=A0 =C2=A0 =C2=A0occupies 0x1 instead. Also, introduce b_error_= compat field at the
> > place
> >=C2=A0 =C2=A0 =C2=A0where the old bio_error was.
> >
> >=C2=A0 =C2=A0 =C2=A0This allows non-CAM(9) disk drivers and softwa= re volume manager
> > modules
> >=C2=A0 =C2=A0 =C2=A0compiled against 15.0-RELEASE kernel to work o= n 15-STABLE kernel
> > again.
> >
> >=C2=A0 =C2=A0 =C2=A0Reviewed by:=C2=A0 =C2=A0 kib
> >=C2=A0 =C2=A0 =C2=A0Differential Revision:=C2=A0 https://= reviews.freebsd.org/D54327
> >
> >=C2=A0 =C2=A0 =C2=A0Approved by:=C2=A0 =C2=A0 re (cperciva)
>
> I=E2=80=99m seeing panics on boot now:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0vtnet0: Ethernet address: 58:9c:fc:0c:60:85<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0vtnet0: netmap queues/slots: TX 1/1024, RX 1= panic: Memory modified after
> free 0xfffff800038b51a8 (424, g_bio) + 0 =3D deadc0dedeacc0de
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0cpuid =3D 6
>=C2=A0 =C2=A0 =C2=A0 =C2=A0time =3D 1
>=C2=A0 =C2=A0 =C2=A0 =C2=A0KDB: stack backtrace:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0db_trace_self_wrapper() at db_trace_self_wra= pper+0x2b/frame
> 0xfffffe008d5679a0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0vpanic() at vpanic+0x136/frame 0xfffffe008d5= 67ad0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0panic() at panic+0x43/frame 0xfffffe008d567b= 30
>=C2=A0 =C2=A0 =C2=A0 =C2=A0trash_ctor() at trash_ctor+0x74/frame 0xffff= fe008d567b40
>=C2=A0 =C2=A0 =C2=A0 =C2=A0item_ctor() at item_ctor+0x59/frame 0xfffffe= 008d567b90
>=C2=A0 =C2=A0 =C2=A0 =C2=A0g_clone_bio() at g_clone_bio+0x1d/frame 0xff= fffe008d567bb0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0g_part_start() at g_part_start+0x96/frame 0x= fffffe008d567c40
>=C2=A0 =C2=A0 =C2=A0 =C2=A0g_io_request() at g_io_request+0x2ca/frame 0= xfffffe008d567c70
>=C2=A0 =C2=A0 =C2=A0 =C2=A0g_read_data() at g_read_data+0x95/frame 0xff= fffe008d567cb0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0g_raid_md_taste_intel() at g_raid_md_taste_i= ntel+0x1d8/frame
> 0xfffffe008d567e50
>=C2=A0 =C2=A0 =C2=A0 =C2=A0g_raid_taste() at g_raid_taste+0x18e/frame 0= xfffffe008d567ea0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0g_new_provider_event() at g_new_provider_eve= nt+0xaa/frame
> 0xfffffe008d567ec0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0g_run_events() at g_run_events+0x104/frame 0= xfffffe008d567ef0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0fork_exit() at fork_exit+0x82/frame 0xfffffe= 008d567f30
>=C2=A0 =C2=A0 =C2=A0 =C2=A0fork_trampoline() at fork_trampoline+0xe/fra= me 0xfffffe008d567f30
>=C2=A0 =C2=A0 =C2=A0 =C2=A0--- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 = ---
>=C2=A0 =C2=A0 =C2=A0 =C2=A0KDB: enter: panic
>=C2=A0 =C2=A0 =C2=A0 =C2=A0[ thread pid 13 tid 100069 ]
>=C2=A0 =C2=A0 =C2=A0 =C2=A0Stopped at=C2=A0 =C2=A0 =C2=A0 kdb_enter+0x3= 3: movq=C2=A0 =C2=A0 $0,0x121aa92(%rip)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0db>
>
> With this commit (and the follow-up =E2=80=9Cgeom(9): unset the BIO_ER= ROR_COMPAT
> flag correctly=E2=80=9D) reverted the VM boots again.

Does the following help?

diff --git a/sys/kern/vfs_bio.c b/sys/kern/vfs_bio.c
index dc90bd3add22..2368f863a248 100644
--- a/sys/kern/vfs_bio.c
+++ b/sys/kern/vfs_bio.c
@@ -4523,8 +4523,6 @@ biodone(struct bio *bp)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 bp->bio_flags |=3D BIO_ERROR_COMPAT;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 done(bp);
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bp->bio_error_co= mpat =3D 0;
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bp->bio_flags &a= mp;=3D ~BIO_ERROR_COMPAT;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0}


Yep that fixes=C2=A0the issue. I committed this as=C2= =A09cfd75a6f88f.

Ka Ho=C2=A0
+ the missing recipients and the mailing lists.

Ka Ho
--00000000000013296d064723a3b4--