From nobody Mon Dec 29 09:22:50 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dfrNY4JBsz6M1P6; Mon, 29 Dec 2025 09:22:53 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dfrNY3SQ3z3CXv; Mon, 29 Dec 2025 09:22:53 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767000173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Tn/lzNnhy+MroI03FXzk9D3uxb52fLGQg81ArSZ7NNo=; b=inW9kBX13ZBeDlpSRpzZXqgqLOR7G1tdJlH97/bxbPGL78jDOSvusfpT0Ha0geVXNiz9BI NNer6MoaI3UN4oKjReztHGsIXNIqwNLjjYHsjdVjuTVF34IgYXh2hPLW7b4vIuv7jo9VOp R1tmKg301iTasJTF3padVG+iJfpRAFiWoBqgDXzdaUk60om3jshrHkE+LtkNWxdqSZZpOH GDt1WMDkvKMk6OGm9ttWXLI6Obwh1yxnUfvdNgRFzrJYpIWMEue+iZk8B5LDmmgAnsm0ED gXLSwushDYO2d3Sh20Q36rhzml9UKB2HFysnbA7IoqUX/aYXDBLLtA0CQgSZFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767000173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Tn/lzNnhy+MroI03FXzk9D3uxb52fLGQg81ArSZ7NNo=; b=couiuPQrw+d9y1DkoVfUbtU7YbbkQl72JkCMRE9qtCFlfgXpwi337JLDW8hzEPRJELzUKU OiNFXKzk3gla4lX4i4dp2SnTiue6dKZ8kaz2m+6mxLHiwx+qFJwRpbDqmF6sCjjKDUoiSu CpNtATO5Emrjb3pjf/8GXo8NNCDNp6YykOf3fvzHs6ikGqHMNDE53Yu5LFpUWH+5vBhVgb oURhEYwiktRoE0VHZ2eOrprZK5mF1Hv9cNT7KIEuqQTf1XA/6N9qIy2c3DvHSi8gcPoTWS 05QCuoNSYA51/gTWERruN/Ld/n0DATIepqneD5rPnAE6Cep1Uqxtxo+YOWALtQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1767000173; a=rsa-sha256; cv=none; b=yw05fibV+OpMzENElSepDqqy8OPrKCqLuWI1RlGnE/3pa6Xg2HEzxyFpKMJsDROStk0Ues jtAsRePi2jAczpZo1u+HtXK+32t3DbEvktoPdM4Qxiz6lvSJPyFwYKOH8k1H2izw0TWi3W EP+SkXaPpbbIjWzNqNpqsX7wcfj/TzB8UZ89ov5/n56jRq7yNIniQlcj0TVl5G0Nkf4GJn PTrYiWL8/YbygE7XY4vMwG3zUf+9EiLiRAH4FhFTNnqUMN7zHPXP7MNavyrpgRhpGYbZqr fda1FdBjwiFIbWpwGjA9MAQ+1idy3NeT9sqG2Ilat7T0LSWjzjWSpdt5jtmbSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R13" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4dfrNY1lMSzFbT; Mon, 29 Dec 2025 09:22:53 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 724F11D3E5; Mon, 29 Dec 2025 10:22:51 +0100 (CET) From: Kristof Provost To: Ka Ho Ng Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: Re: git: 112c453ba910 - stable/15 - geom(9): struct bio KBI fix Date: Mon, 29 Dec 2025 10:22:50 +0100 X-Mailer: MailMate (2.0r6272) Message-ID: In-Reply-To: <69489316.252e6.179063dd@gitrepo.freebsd.org> References: <69489316.252e6.179063dd@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_8F56F269-AA01-4D4F-8A93-6AC3F4C03A05_=" --=_MailMate_8F56F269-AA01-4D4F-8A93-6AC3F4C03A05_= Content-Type: text/plain; charset=UTF-8; format=flowed; markup=markdown Content-Transfer-Encoding: quoted-printable On 22 Dec 2025, at 1:38, Ka Ho Ng wrote: > The branch stable/15 has been updated by khng: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D112c453ba91012f19ed140c56a3ac= 8fc929ddabb > > commit 112c453ba91012f19ed140c56a3ac8fc929ddabb > Author: Ka Ho Ng > AuthorDate: 2025-12-21 22:45:03 +0000 > Commit: Ka Ho Ng > CommitDate: 2025-12-22 00:37:40 +0000 > > geom(9): struct bio KBI fix > > The struct bio was changed after cb85c2e2e995 on the branch. To = > fix > this, move BIO_ERROR flag to another value, and now = > BIO_ERROR_COMPAT > occupies 0x1 instead. Also, introduce b_error_compat field at the = > place > where the old bio_error was. > > This allows non-CAM(9) disk drivers and software volume manager = > modules > compiled against 15.0-RELEASE kernel to work on 15-STABLE kernel = > again. > > Reviewed by: kib > Differential Revision: https://reviews.freebsd.org/D54327 > > Approved by: re (cperciva) I=E2=80=99m seeing panics on boot now: vtnet0: Ethernet address: 58:9c:fc:0c:60:85 vtnet0: netmap queues/slots: TX 1/1024, RX 1panic: Memory modified = after free 0xfffff800038b51a8 (424, g_bio) + 0 =3D deadc0dedeacc0de cpuid =3D 6 time =3D 1 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame = 0xfffffe008d5679a0 vpanic() at vpanic+0x136/frame 0xfffffe008d567ad0 panic() at panic+0x43/frame 0xfffffe008d567b30 trash_ctor() at trash_ctor+0x74/frame 0xfffffe008d567b40 item_ctor() at item_ctor+0x59/frame 0xfffffe008d567b90 g_clone_bio() at g_clone_bio+0x1d/frame 0xfffffe008d567bb0 g_part_start() at g_part_start+0x96/frame 0xfffffe008d567c40 g_io_request() at g_io_request+0x2ca/frame 0xfffffe008d567c70 g_read_data() at g_read_data+0x95/frame 0xfffffe008d567cb0 g_raid_md_taste_intel() at g_raid_md_taste_intel+0x1d8/frame = 0xfffffe008d567e50 g_raid_taste() at g_raid_taste+0x18e/frame 0xfffffe008d567ea0 g_new_provider_event() at g_new_provider_event+0xaa/frame = 0xfffffe008d567ec0 g_run_events() at g_run_events+0x104/frame 0xfffffe008d567ef0 fork_exit() at fork_exit+0x82/frame 0xfffffe008d567f30 fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe008d567f30 --- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 --- KDB: enter: panic [ thread pid 13 tid 100069 ] Stopped at kdb_enter+0x33: movq $0,0x121aa92(%rip) db> With this commit (and the follow-up =E2=80=9Cgeom(9): unset the = BIO_ERROR_COMPAT flag correctly=E2=80=9D) reverted the VM boots again. Best regards, Kristof --=_MailMate_8F56F269-AA01-4D4F-8A93-6AC3F4C03A05_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 22 Dec 2025, at 1:38, Ka Ho Ng wrote:

The branch stable/15 has been updated by khng:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3D112c453ba91012f19ed140c56a3ac8fc929ddabb

commit 112c453ba91012f19ed140c56a3ac8fc929ddabb
Author: Ka Ho Ng khng@FreeBSD.org=
AuthorDate: 2025-12-21 22:45:03 +0000
Commit: Ka Ho Ng khng@FreeBSD.org=
CommitDate: 2025-12-22 00:37:40 +0000

ge=
om(9): struct bio KBI fix

The struct bio was changed after cb85c2e2e995 on the branch. To fix
this, move BIO_ERROR flag to another value, and now BIO_ERROR_COMPAT
occupies 0x1 instead. Also, introduce b_error_compat field at the place
where the old bio_error was.

This allows non-CAM(9) disk drivers and software volume manager modules
compiled against 15.0-RELEASE kernel to work on 15-STABLE kernel again.

Reviewed by:    kib
Differential Revision:  https://reviews.freebsd.org/D54327

Approved by:    re (cperciva)

I=E2=80=99m seeing panics on boot now:

vt=
net0: Ethernet address: 58:9c:fc:0c:60:85
vtnet0: netmap queues/slots: TX 1/1024, RX 1panic: Memory modified after =
free 0xfffff800038b51a8 (424, g_bio) + 0 =3D deadc0dedeacc0de

cpuid =3D 6
time =3D 1
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe008d5=
679a0
vpanic() at vpanic+0x136/frame 0xfffffe008d567ad0
panic() at panic+0x43/frame 0xfffffe008d567b30
trash_ctor() at trash_ctor+0x74/frame 0xfffffe008d567b40
item_ctor() at item_ctor+0x59/frame 0xfffffe008d567b90
g_clone_bio() at g_clone_bio+0x1d/frame 0xfffffe008d567bb0
g_part_start() at g_part_start+0x96/frame 0xfffffe008d567c40
g_io_request() at g_io_request+0x2ca/frame 0xfffffe008d567c70
g_read_data() at g_read_data+0x95/frame 0xfffffe008d567cb0
g_raid_md_taste_intel() at g_raid_md_taste_intel+0x1d8/frame 0xfffffe008d=
567e50
g_raid_taste() at g_raid_taste+0x18e/frame 0xfffffe008d567ea0
g_new_provider_event() at g_new_provider_event+0xaa/frame 0xfffffe008d567=
ec0
g_run_events() at g_run_events+0x104/frame 0xfffffe008d567ef0
fork_exit() at fork_exit+0x82/frame 0xfffffe008d567f30
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe008d567f30
--- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 ---
KDB: enter: panic
[ thread pid 13 tid 100069 ]
Stopped at      kdb_enter+0x33: movq    $0,0x121aa92(%rip)
db>

With this commit (and the follow-up =E2=80=9Cgeom(9): uns= et the BIO_ERROR_COMPAT flag correctly=E2=80=9D) reverted the VM boots ag= ain.

Best regards,
Kristof

--=_MailMate_8F56F269-AA01-4D4F-8A93-6AC3F4C03A05_=--