From nobody Sun Dec 28 22:03:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dfYK73mxPz6MQy9 for ; Sun, 28 Dec 2025 22:03:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dfYK72NWyz3Gg1 for ; Sun, 28 Dec 2025 22:03:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766959435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hkYqrcWTt2cXlXb35H029QT/G573h8Ncqvfc6nnucRk=; b=XtjJ2KGZIdunoO/1E4qSBUuhCTny7OPFSqXL2ts7kkp9Kg82pmIcS6DxvXB+kWEiYrKQCo mDK98oYriIj+GHlBGlXpzM+4y7jXMBFR3T16fCGo8vubNoywMR0vlM+/CxGlARM1n4/zq1 XdPxy+GU/YroHQcOxGIU5L4jbZ8J17l7pJKaTQ2pyiC/QELw0SlRD2ughUZQUWODqUoB3m DTHoc+rWKqXIVZb9fBQtglVei5bBUiNzdblpYBZPfelghrUThF404IM7BSwdtCnTVAj0Y7 Zr/FgIYqK8+F+h+MLfxqpzf3yKNf5YooPFQQp45u7gJmaM29+zkde+Pv6Dbq/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766959435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hkYqrcWTt2cXlXb35H029QT/G573h8Ncqvfc6nnucRk=; b=qyJMCYhRdEx9XWOqX2jbufezIlVXr0BXdyVjtGvkju8NWEczjp5IZGBSDNCz/xsPueWhyV zJmsM42KfPnbEI/a66hW2i/aiYWioGFn9IKWQsCl9B8xo1GlCN2UYxyn6lMIfmcufB22nk +dm5HA+nlnumTamHhm/cGKxXQm0GiGc1FLEN5j8hCMHFJkcF908PH4rd65znIkzl5r5ubp UDNRV1LwmRelpso338O9Xbmkdnx08aMzD0n7nO/V8ARo4KrH+I+ZyzN291pkQJbmf64ERg cQZ3btzwp1+i2AEoM211qKjE9wj1hVWZSSRzHNG4/0V+ofNZjN1o2KapOt2WGQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1766959435; a=rsa-sha256; cv=none; b=NZYabVy0Wfq0w4SAiNz+eUOTPZc4YTF7bJO/8X/bFkmTHUcuuHWmrw0dtbSpFbP3Wpm6Mu /SNOJlSOdHUl+vjSRaJZ+kRdlI6lDrFNN9WozeGHCqLMZ8Cj9e9JdTJPx0sRReyCiuVv+O HAYGPrr9rQRyZvxJqGaeqI9qWk03F/WXW0yKFEfXlxFCdI+aJ9ac3ETk8MR/eI8tHPNOrA xNQ7tELDjmpgwdcaGnbF5jhesFuCaYwTmuOeDyQOLd946bmIzMTyEoyT8m3fn4CqkEY+KE 91N2rUEoCYNj97KLoKVTEymfUmAiGG1oq6E4OxB0dOQ4ts42GOKpVA0Rm+gGPQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dfYK71gw4z13QW for ; Sun, 28 Dec 2025 22:03:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id e12a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 28 Dec 2025 22:03:55 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Kyle Evans From: Dimitry Andric Subject: git: 541a98d7e28a - main - compat: linux: use appropriate variables for copying out old timers List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 541a98d7e28a8e4697ac2fa78dd4c4203c2c3a9c Auto-Submitted: auto-generated Date: Sun, 28 Dec 2025 22:03:55 +0000 Message-Id: <6951a94b.e12a.483fcc57@gitrepo.freebsd.org> The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=541a98d7e28a8e4697ac2fa78dd4c4203c2c3a9c commit 541a98d7e28a8e4697ac2fa78dd4c4203c2c3a9c Author: Kyle Evans AuthorDate: 2025-12-28 22:02:04 +0000 Commit: Dimitry Andric CommitDate: 2025-12-28 22:03:33 +0000 compat: linux: use appropriate variables for copying out old timers We copyout &l_oval but do the conversions into &l_val, leaving us with stack garbage. A build with an LLVM21 cross-toolchain seems to catch this. Reported by: Florian Limberger Reviewed by: markj Fixes: a1fd2911ddb06 ("linux(4): Implement timer_settime64 syscall.") MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D52985 --- sys/compat/linux/linux_timer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/compat/linux/linux_timer.c b/sys/compat/linux/linux_timer.c index ed9133359302..230be9572b85 100644 --- a/sys/compat/linux/linux_timer.c +++ b/sys/compat/linux/linux_timer.c @@ -131,7 +131,7 @@ linux_timer_settime(struct thread *td, struct linux_timer_settime_args *uap) return (error); error = kern_ktimer_settime(td, uap->timerid, flags, &val, ovalp); if (error == 0 && uap->old != NULL) { - error = native_to_linux_itimerspec(&l_val, &val); + error = native_to_linux_itimerspec(&l_oval, &oval); if (error == 0) error = copyout(&l_oval, uap->old, sizeof(l_oval)); } @@ -158,7 +158,7 @@ linux_timer_settime64(struct thread *td, struct linux_timer_settime64_args *uap) return (error); error = kern_ktimer_settime(td, uap->timerid, flags, &val, ovalp); if (error == 0 && uap->old != NULL) { - error = native_to_linux_itimerspec64(&l_val, &val); + error = native_to_linux_itimerspec64(&l_oval, &oval); if (error == 0) error = copyout(&l_oval, uap->old, sizeof(l_oval)); }