From nobody Sun Dec 28 17:11:43 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dfQqz3w3Dz6M4SC for ; Sun, 28 Dec 2025 17:11:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dfQqz3CwYz3Vtf for ; Sun, 28 Dec 2025 17:11:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766941903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IZTxp2kbWkYOwDZ2sjvG8sjddchAwN42B775AYpWjJc=; b=r/inzPQFnCzpMaPZJmdNMpkBcgffx4YEL5tRZekvV4KgnfiFEeE+7yLGAq/hyLWHkQsm6o d9AHIyijju2iaXmGl3wmt0F14tMGY1FWPZrgtITF/2Oy4YWS/imSrkWP8g9cpNC1+xckmf KbcL4ktDLh0vyUoJ2gU0JhcTdF+1k24TdgYQHW6aw4D1rYtP6QfpDRlDsf7DqnOrHJs7p8 0bpbvR4WtRP/5ogXmPHdeeqp1OYNFAXioK8Ubk2CLOQd4yJ8WxSIo4aaUbfnakiiovIHjT FeQZPg9Yzw49Q15+G6nNHrZlwXKRvyyBK5Z1dpwc9mkpJtRur1SbDYXi7tLnOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766941903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IZTxp2kbWkYOwDZ2sjvG8sjddchAwN42B775AYpWjJc=; b=ugoNtBZrBUr5wp8ULBK88jUwiDe0bU4J0XlaL+xrhz+qJH6qU3QNW5Uf0aHYmWRjKKCRaL 6zDzqGw+3OPK+Ardq24aaQ/kOOs9h1nER8y8rs5RxQ9JsLBmLdPC+8+Q200FPkGXmSXQ+c 23z1YfTONTsoFO4UXBXuYq85NFpuOGu1BtefyTswd5nOK6lNK0rSzPKRw13VDlKL7Mmqmv 2Vig0t1hx9OHrV1RMY1DSgecZVT/AtHj50XYqLurcxSWEGFjPcdT8HpZlvQoD9FbK+6/3l fx88sq+Y1Z0/loWK1L+0aR4C/96/pPuPABQEKnerqrNhQzb7PhzhhlwVREhX+A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1766941903; a=rsa-sha256; cv=none; b=XLDqcSrSigm1lOYZXn1nBsBBiJIOYTcffZvZvCTpmgt4qvAsHXsTT/UisAtdRsiejRwDX+ sVPyCqHE0875qKNQiGkOXR39YW/7Z8d4YDN82K+m8NAItkifUNt61kHaKhb7c1L3Gh20p1 +KZT/6CZxp6RxJhH7xmjsbRFXfl5sH+f3Hy6zHLbmt+zD7kj3u291wGxVxfepVxrTunN3R u7j0AI5yhuEZYyLmI33yNt0NayAe8T+h/7kLl1U+oFUNy1N6/4WuefqpbgbCgXU9aG71Ar t0lWYWAscRqk6/34B/l3t0xxZQZ/M8JXAlAMXaXHKJ+2SlZBpuB61j73DF62Zw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dfQqz2hdKztT0 for ; Sun, 28 Dec 2025 17:11:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id f358 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 28 Dec 2025 17:11:43 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Eugene Grosbein Subject: git: a7b8a5d37bcb - main - ipfw.8: fix documentation bug for setmark List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: eugen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a7b8a5d37bcb0009297962137bfb6c6570e5af12 Auto-Submitted: auto-generated Date: Sun, 28 Dec 2025 17:11:43 +0000 Message-Id: <695164cf.f358.59339a5c@gitrepo.freebsd.org> The branch main has been updated by eugen: URL: https://cgit.FreeBSD.org/src/commit/?id=a7b8a5d37bcb0009297962137bfb6c6570e5af12 commit a7b8a5d37bcb0009297962137bfb6c6570e5af12 Author: Eugene Grosbein AuthorDate: 2025-12-28 17:05:22 +0000 Commit: Eugene Grosbein CommitDate: 2025-12-28 17:05:22 +0000 ipfw.8: fix documentation bug for setmark A mark set with "setmark" keyword is intended to be "sticky" and documented as such but in fact it is not yet, as current implementation lacks "sticky" feature and its implementation will be not MFC'd, most probably. Correct the manual page until the implementation improved. MFC after: 3 days Discussed with: Boris Lytochkin (author) --- sbin/ipfw/ipfw.8 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sbin/ipfw/ipfw.8 b/sbin/ipfw/ipfw.8 index 7a81c84de3e4..bafad1479c0e 100644 --- a/sbin/ipfw/ipfw.8 +++ b/sbin/ipfw/ipfw.8 @@ -839,8 +839,12 @@ When a packet matches a rule with the .Cm setmark keyword, a 32-bit numeric mark is assigned to the packet. The mark is an extension to the tags. -As tags, mark is "sticky" so the value is kept the same within the kernel and -is lost when the packet leaves the kernel. +The mark is preserved for a packet within a single ipfw rulese traversal +and is lost when the packet is checked against the active ruleset +next time (see +.Sx PACKET FLOW +section) or leaves ipfw context (e.g. accepted, +diverted, bridged or routed). Unlike tags, mark can be matched as a lookup table key or compared with bitwise mask applied against another value. Each packet can have only one mark, so