From nobody Fri Dec 26 23:12:06 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ddLwm07FSz6MGX1; Fri, 26 Dec 2025 23:12:08 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ddLwl6Yskz3hZb; Fri, 26 Dec 2025 23:12:07 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766790727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rTRJd2D1gp2DmnYplyD+P5jcr+8YJdXR34n1POH+EKw=; b=Ja7ZuvTvW1ksl5ps9zy6l8rawW9EhTIiKQV7wPROcMDNiA/6mdQ1R0i3pzMNNBUZtsVVRF Mdm1SSHI2rSot9/K/V20T9CPlzJ1jA+pn405xqO2NMr32Lr5hvKMOOjHBWKjfZNz8uy7bL 6nmQSGF7QnBVZvZTTzg8umKGKNdgBPvysw3mVwh/Xwu088PvFIGyakpmE2yNpkVb0f470K IUqsQzHNKmpQi2+yjDG9orbacZBgbmYsHlwUXb7IY1OncPZV5sHIhHqnyGmYBFnL/WEWWO +qpQ7wNNopg2+ZkIxiv4GXLQ6lQVfRl97VPfWPysDVpUaqaQWEOYYucCD+6UEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766790727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rTRJd2D1gp2DmnYplyD+P5jcr+8YJdXR34n1POH+EKw=; b=K2Bg9OleVx36EQkRKxm/Gxjum/uqruW8ZSXc5OqZPr/vvq4jnyvuDwcjORfoMRGSCNKwWi It4l+GFv7upZKaoZAPwQgaAl2AWyAX7vYO2Eugp0AiXlARgzKbnwtxUbJxpSWESQf7WAcP Em+hPAnTPM8jqKQDEBLKRE1kMCD+eon2gzkKuN5uBK6OV9ZSORYaNkk2lrB19thoL+qEbg okKvdokO5BztQ0TlCdN2G36HIIOptmDsxaAlwRw5vJeNlbadSWMgJPig44ZfX6M25Os4Uj qmhifNzn828oX5WmnXRnKxvyjb9pneRzKnkxUe8zbjN5Ot9jnhgbugWNFPYCXg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1766790727; a=rsa-sha256; cv=none; b=WN/E7DnIIlHrweBtdMsZVdRD0IpVfu9LlgnAKqe5gkcXMOHHEqu5wClKZ4g8Ct/q6bb4Z8 7B6g22DOJhgzMty3c0uivKoNrCGVC2DQT+YLzMnFkQ3bqAebDhTetKtpVOeiW/d8faNzdi 9okL2mj+d2OiYgcXbh3MLlCFkbdNPd0kibhMBa0xFTbi8Deb37tIES4CahwaN4Jh/c4HlP wnC7rCTBB/LS1rIJ17+zncHwAeJgAqMNUhOAx8wBAR9ccyAYuODCTDey058sFFkrrQ+fSj FVjSuSOMGjcrW0WTTZc3weryvsH0p9pnWEfoksQijkT6vCG9NQCq8Tq0kXMXwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "E7" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ddLwl5WVgzCrn; Fri, 26 Dec 2025 23:12:07 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (bladnoch.home.andric.com [192.168.0.20]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id A2DB951D04; Sat, 27 Dec 2025 00:12:06 +0100 (CET) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: git: 1c9ff80f0635 - main - tools.build: add sys/cdefs.h to SYSINCS, since lots of other headers use it From: Dimitry Andric In-Reply-To: Date: Sat, 27 Dec 2025 00:12:06 +0100 Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <694ea9cc.9f30.1d45a192@gitrepo.freebsd.org> To: Konstantin Belousov X-Mailer: Apple Mail (2.3826.700.81.1.4) On 26 Dec 2025, at 19:36, Konstantin Belousov = wrote: >=20 > On Fri, Dec 26, 2025 at 03:29:16PM +0000, Dimitry Andric wrote: >> The branch main has been updated by dim: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D1c9ff80f06350fa44b7e50ce09ad665a= b0082abb >>=20 >> commit 1c9ff80f06350fa44b7e50ce09ad665ab0082abb >> Author: Dimitry Andric >> AuthorDate: 2025-12-26 15:26:13 +0000 >> Commit: Dimitry Andric >> CommitDate: 2025-12-26 15:26:13 +0000 >>=20 >> tools.build: add sys/cdefs.h to SYSINCS, since lots of other = headers use it >>=20 >> This is needed to let the legacy stage compile against newer = versions of >> sys/font.h, which transitively includes sys/cdefs.h, and requires = the >> new __nonstring macro from it. >>=20 >> Fixes: e2c93ed09f25 >> MFC after: 3 days >> --- >> tools/build/Makefile | 4 ++++ >> 1 file changed, 4 insertions(+) >>=20 >> diff --git a/tools/build/Makefile b/tools/build/Makefile >> index a701c12a9b5c..2c6237c4dd7d 100644 >> --- a/tools/build/Makefile >> +++ b/tools/build/Makefile >> @@ -351,6 +351,10 @@ MSDOSFSINCS+=3D ${SRCTOP}/sys/fs/msdosfs/fat.h >> MSDOSFSINCS+=3D ${SRCTOP}/sys/fs/msdosfs/msdosfsmount.h >> DISKINCS+=3D ${SRCTOP}/sys/sys/disk/bsd.h >>=20 >> +# Needed to build most of the things below, which include = sys/cdefs.h either >> +# directly or transitively >> +SYSINCS+=3D ${SRCTOP}/sys/sys/cdefs.h >> + >> # Needed to build config (since it uses libnv) >> SYSINCS+=3D ${SRCTOP}/sys/sys/_nv.h >> SYSINCS+=3D ${SRCTOP}/sys/sys/nv.h ${SRCTOP}/sys/sys/cnv.h \ >=20 > Then the sys/_visible.h needs to be added as well if it is not added = yet. Thanks, committed that in 086bedb11a85. -Dimitry