From nobody Fri Dec 26 09:30:41 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dd0hy2Pfzz6LHpP for ; Fri, 26 Dec 2025 09:30:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dd0hy19DNz3LyT for ; Fri, 26 Dec 2025 09:30:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766741442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eRiRWPsKf/q+sZZ3msncAmxqlcAnUQhWTpgk9kHtZis=; b=Mr+mX8JPBY27J91LjgTTZQ1AQ72crhEOZg58kwgL8/5QdSATQnfiLkcTdbEgD2p/MntQSY LJN3iYIQfVQKE/H0M6rVyCAibYnhoXas9TFfBcN4a7ZkxdJfV7Irf4rnH408EloP7zyHIA C0N8M1WHOZ8pUp2xEuARf1BQteKBf6BUtmuQ845d78HvoUBA9PNoCkWmbIR/jYWdYr+4+f ZmHDUlzhYMmQh2CJ8xtSjBKhml3Fmq4T8OumHAFGzBcDNmrK33EEziEEaeH8TmWzGEF//K VNCVojxWbPJwScKEdeNzyn4liR0uaCro5vmFmba6vVlabtRp/pczzAw//cBabw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1766741442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=eRiRWPsKf/q+sZZ3msncAmxqlcAnUQhWTpgk9kHtZis=; b=O8BdLWW5h9auUXIHZVJ36jVR+JomPak6u2DEPoyuDPo/JZVNPMJC0vUIBQvLVNhpRTVo4n W2/EKRefGV6mX2Hzr6XGACU+CI7MTk9YoGzGB9N7+Tx5ozwwy/dd9Tf/uvJEfDftfJHhWn sza2haYjaGja2UrDt144FyASmCIpQeyfpNXB7SvtoIXJn0ldwENj6gVpcjeEBLldkFbavf j4rk9TmeOCy5pabUNPWBlKRcI+JNFCAAoRJ/lZckPfrnDghhvLyLDNHk2fWrR8E4rNJv5D T+5GpO5/X0YQPkT8K4+ZEQGtTlVjdLpOqCYhoFEduHDwMaVPb9PIFrplS43Mpg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1766741442; a=rsa-sha256; cv=none; b=nk7AQEb1MLYq1XbMfBhPnTM+Gh3doQ5CNSW5QbBZEq9IL/NQRwYkt4tPNuWVlBvYSc2YBy UZUMFLB3+V/M9BJdYgWBuNsnlwHQ3hyEUseMLy1JRWRy9TP2uHO7Cy686Sk96i2V39yOXJ tBJPImio9u40apUWU/62jexRkwby52DQ9xi281c+fzVCdedYQsiNHYnc6L5hH54gL2QXw0 mdkjGuvAiC7vnxsE5882Ji4NLR7AcsQpyn+QEetr8R+yF1MqgtXP16M0P5D/iIv9l3BNZQ d109lTNdcdAuva0BHqQQL6YLeRLh0UvGVe43JNpY9MUw15+9zjpzQwhsUhoj6A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dd0hx5WMRz16pW for ; Fri, 26 Dec 2025 09:30:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 8804 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 26 Dec 2025 09:30:41 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Justin Hibbits From: Zhenlei Huang Subject: git: 2fef1a6ef9f0 - stable/14 - netlink: Don't directly access ifnet members List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 2fef1a6ef9f095df5ed8f1cd8766878fb960c86b Auto-Submitted: auto-generated Date: Fri, 26 Dec 2025 09:30:41 +0000 Message-Id: <694e55c1.8804.4b2cc628@gitrepo.freebsd.org> The branch stable/14 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=2fef1a6ef9f095df5ed8f1cd8766878fb960c86b commit 2fef1a6ef9f095df5ed8f1cd8766878fb960c86b Author: Justin Hibbits AuthorDate: 2024-10-31 15:09:48 +0000 Commit: Zhenlei Huang CommitDate: 2025-12-26 08:25:47 +0000 netlink: Don't directly access ifnet members Summary: Remove the final direct access of struct ifnet members from netlink. Since only the first address is used, create the iterator and then free, without fully iterating. Reviewed By: kp Sponsored by: Juniper Networks, Inc. Differential Revision: https://reviews.freebsd.org/D42972 (cherry picked from commit b224af946a17b8e7a7b4942157556b5bc86dd6fb) --- sys/netlink/route/iface.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/netlink/route/iface.c b/sys/netlink/route/iface.c index d98385a4c23e..6fd99cf61e2d 100644 --- a/sys/netlink/route/iface.c +++ b/sys/netlink/route/iface.c @@ -322,11 +322,13 @@ dump_iface(struct nl_writer *nw, if_t ifp, const struct nlmsghdr *hdr, */ if (if_getaddrlen(ifp) != 0) { struct ifaddr *ifa; + struct ifa_iter it; NET_EPOCH_ENTER(et); - ifa = CK_STAILQ_FIRST(&ifp->if_addrhead); + ifa = ifa_iter_start(ifp, &it); if (ifa != NULL) dump_sa(nw, IFLA_ADDRESS, ifa->ifa_addr); + ifa_iter_finish(&it); NET_EPOCH_EXIT(et); }