From nobody Tue Dec 23 18:47:28 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dbPC908gbz6K9FL for ; Tue, 23 Dec 2025 18:47:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dbPC82pqPz3lDB for ; Tue, 23 Dec 2025 18:47:48 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-34c2f52585fso4502874a91.1 for ; Tue, 23 Dec 2025 10:47:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1766515661; x=1767120461; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2CLX/jOyvm/01FjD2p8Av9GqFJv7RzE9ZiNqmmNpQ/I=; b=wZixOPD0NU+WVN3e5p3txwV6V2iO8VY6WP5yI1UpBXm6D1g0cYT2qpla+o0FX2NWfg J7Hd7smk9ylvRYNVzbDGoA1f1XxUdQp7SE1v7XEAhdhD1R8R5N+e1cQuJ77YprCI+EAk dN8GIsFE3Plp5+FtrwjWYCFAfWMxVIvHJhBzM14oZagk+0rdahL5elUlTDewhGf+G74b k7sGnqv56rf8zbATa1AvmmZ/YnZDRRCXPUCZ1gy2WmUYdgY6i7ORmsIOxrRDvE8aZOjC wkUc9+FV/VHeXLt54Wpl51k0OdMyU+ijmVO0RoYsVvOBj7WbIUKEHU65fyjJx3R9Kdy4 q4dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766515661; x=1767120461; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2CLX/jOyvm/01FjD2p8Av9GqFJv7RzE9ZiNqmmNpQ/I=; b=WicZph+wqW/ljELW8zMouCBI+dSl8y15LBPsRzsfwfq9uPXgUb18oEf3AJdtWv/o09 mkkG8lhGjq/0eSM1gbM3mYtDdVzDkAlkHZd5mVD/DtZ4UjDKf94zd8EACRjO+bhS4YDm IoWfp3XCi/Hu4V7ztrJojGoZTLNeqhI3hNeviH7QSYpGCTVlIs1AVLE0YpD29WvUcNy+ sLNq3k4EAdEwQkM/Hd8XqUm5n5m6mUD2/k0xmqZKNSjotOqiLHBW061ccup0AuTzgesb yxqacmrBcY9SghpETKE0nYosiUMegOEHpjTg8iAm4rkLyLKzxcyOINmaCGVdhfE0a6kN RrBw== X-Forwarded-Encrypted: i=1; AJvYcCVVA03wlPF+rAwH6BJeGJRBomQQsIqXxsr3zKUwBm91yF6CDq4VhDAVnjVqkczOWdDBYZLUy6614KaWrLT4lGlLic08@freebsd.org X-Gm-Message-State: AOJu0Yy19xqW9psKw6Qlmv7PUvfGAksSs6p/c1nZZ/s7Ld5yZDN1eUos clBZ0NzlIw8+qIDzNLY+eX7QcwenpoKIeISshB0v/kCzYgHLMhEDNs7vLNVi8g6Bs+yOnANTa36 QW0fMIkqG7zkyDx3135F66luEJkmxA/kNt50q77i7IA== X-Gm-Gg: AY/fxX6rmBjMhxIuBuu+lrXn0G6B1Xmon1ezIpzn2/7toqRlivvdq5qe0cdxrjMm07W u1pygjbAsmV/rQRO2aqjvgN/N5B98O11rq0TuyfdIz8SBcckR079S4o5fyR+3Y9MILkPFuDhbZE VfTCuVg8fMa9bJPvl7YTu3pMTmchtlZhZWX0lFRfOwEi81pZHl5g6DAsqr440bBs48gWj1tg+0Y V2OuvX7sgUjoVWGYAWJd5OGRoKNcLAkFZwUzDjubhea6wdb5VNcW559/HoTC7KbG0C+YigJ X-Google-Smtp-Source: AGHT+IGK/pGo2cQSZaNYb0BJe/Wqsuh9MZpC5ASOg9xH4WM0Rr0wPkmGeRPg99U7GhSjpaU1UU1oGkWJe6mryXdh2Pg= X-Received: by 2002:a17:90b:2d4c:b0:341:194:5e7c with SMTP id 98e67ed59e1d1-34e921b73a6mr11985185a91.24.1766515660982; Tue, 23 Dec 2025 10:47:40 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <694ad6f7.3129d.4b8eaff6@gitrepo.freebsd.org> In-Reply-To: <694ad6f7.3129d.4b8eaff6@gitrepo.freebsd.org> From: Warner Losh Date: Tue, 23 Dec 2025 11:47:28 -0700 X-Gm-Features: AQt7F2ptbaz9ATlWq07gds4Xf0r1tqPvAGXd9LHIPXT1HH4TXWMRZD7aLEZImwo Message-ID: Subject: Re: git: 1aea5b0ba76a - main - nvme: make the interface standard file To: Gleb Smirnoff Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000007699630646a2fa5b" X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dbPC82pqPz3lDB --0000000000007699630646a2fa5b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks Gleb! This is the right fix. Warner On Tue, Dec 23, 2025 at 10:52=E2=80=AFAM Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D1aea5b0ba76a30cc9753fbc860c0f35= a980b756b > > commit 1aea5b0ba76a30cc9753fbc860c0f35a980b756b > Author: Gleb Smirnoff > AuthorDate: 2025-12-23 17:51:25 +0000 > Commit: Gleb Smirnoff > CommitDate: 2025-12-23 17:51:25 +0000 > > nvme: make the interface standard file > > This makes nvme.ko and nvd.ko loadable. > > Fixes: aed44717a1606e4c5c79f7c8831de49cba64d7e6 > --- > sys/conf/files | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/conf/files b/sys/conf/files > index d41e3ccc23be..474f337e569a 100644 > --- a/sys/conf/files > +++ b/sys/conf/files > @@ -2582,7 +2582,7 @@ dev/nvme/nvme_sim.c optional nvme scb= us > dev/nvme/nvme_sysctl.c optional nvme > dev/nvme/nvme_test.c optional nvme > dev/nvme/nvme_util.c optional nvme | scbus > -dev/nvme/nvme_if.m optional nvme > +dev/nvme/nvme_if.m standard > dev/nvmem/nvmem.c optional nvmem fdt > dev/nvmem/nvmem_if.m optional nvmem > dev/nvmf/controller/ctl_frontend_nvmf.c optional nvmft > > --0000000000007699630646a2fa5b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks Gleb! This is the right fix.

War= ner

On Tue, Dec 23, 2025 at 10:52=E2=80=AFAM Gle= b Smirnoff <glebius@freebsd.org> wrote:
Th= e branch main has been updated by glebius:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3D1aea5b0ba76a30cc9753fbc860c0f35a980b756b
commit 1aea5b0ba76a30cc9753fbc860c0f35a980b756b
Author:=C2=A0 =C2=A0 =C2=A0Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2025-12-23 17:51:25 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2025-12-23 17:51:25 +0000

=C2=A0 =C2=A0 nvme: make the interface standard file

=C2=A0 =C2=A0 This makes nvme.ko and nvd.ko loadable.

=C2=A0 =C2=A0 Fixes:=C2=A0 aed44717a1606e4c5c79f7c8831de49cba64d7e6
---
=C2=A0sys/conf/files | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/conf/files b/sys/conf/files
index d41e3ccc23be..474f337e569a 100644
--- a/sys/conf/files
+++ b/sys/conf/files
@@ -2582,7 +2582,7 @@ dev/nvme/nvme_sim.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0optional nvme scbus
=C2=A0dev/nvme/nvme_sysctl.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional nvme=
=C2=A0dev/nvme/nvme_test.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional= nvme
=C2=A0dev/nvme/nvme_util.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional= nvme | scbus
-dev/nvme/nvme_if.m=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional= nvme
+dev/nvme/nvme_if.m=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0standard=
=C2=A0dev/nvmem/nvmem.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 opt= ional nvmem fdt
=C2=A0dev/nvmem/nvmem_if.m=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0optional= nvmem
=C2=A0dev/nvmf/controller/ctl_frontend_nvmf.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 optional nvmft

--0000000000007699630646a2fa5b--