git: 8da838ac3169 - main - vtnet: improve consistency
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 19 Dec 2025 16:45:54 UTC
The branch main has been updated by tuexen:
URL: https://cgit.FreeBSD.org/src/commit/?id=8da838ac31692e381adfc63d83ea49f2adabbf23
commit 8da838ac31692e381adfc63d83ea49f2adabbf23
Author: Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2025-12-19 16:44:20 +0000
Commit: Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2025-12-19 16:44:20 +0000
vtnet: improve consistency
Use sbuf_new_for_sysctl() instead of sbuf_new_auto() when exposing
the flags via sysctl.
MFC after: 1 week
---
sys/dev/virtio/network/if_vtnet.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/sys/dev/virtio/network/if_vtnet.c b/sys/dev/virtio/network/if_vtnet.c
index 73f34808e008..19775416f8d4 100644
--- a/sys/dev/virtio/network/if_vtnet.c
+++ b/sys/dev/virtio/network/if_vtnet.c
@@ -4417,16 +4417,14 @@ vtnet_sysctl_features(SYSCTL_HANDLER_ARGS)
static int
vtnet_sysctl_flags(SYSCTL_HANDLER_ARGS)
{
- struct vtnet_softc *sc;
- struct sbuf *sb;
+ struct sbuf sb;
+ struct vtnet_softc *sc = (struct vtnet_softc *)arg1;
int error;
- sb = sbuf_new_auto();
- sc = (struct vtnet_softc *)arg1;
- sbuf_printf(sb, "%b", sc->vtnet_flags, VTNET_FLAGS_BITS);
- sbuf_finish(sb);
- error = SYSCTL_OUT(req, sbuf_data(sb), sbuf_len(sb) + 1);
- sbuf_delete(sb);
+ sbuf_new_for_sysctl(&sb, NULL, 0, req);
+ sbuf_printf(&sb, "%b", sc->vtnet_flags, VTNET_FLAGS_BITS);
+ error = sbuf_finish(&sb);
+ sbuf_delete(&sb);
return (error);
}