git: 1dc4fa83bb8b - stable/14 - mdo(1): Avoid calling getgroups() in some unnecessary cases

The branch stable/14 has been updated by olce:

URL: https://cgit.FreeBSD.org/src/commit/?id=1dc4fa83bb8b78314cd24bbfda547edbfe2c7553

commit 1dc4fa83bb8b78314cd24bbfda547edbfe2c7553
Author:     Olivier Certner <olce@FreeBSD.org>
AuthorDate: 2025-11-14 11:59:09 +0000
Commit:     Olivier Certner <olce@FreeBSD.org>
CommitDate: 2025-12-19 09:16:48 +0000

    mdo(1): Avoid calling getgroups() in some unnecessary cases
    
    If the basis for supplementary groups are the current ones, we do not
    need to fetch them when they are to be replaced entirely (which we
    already have been doing), as in the '!start_from_current_groups' case,
    but specifically also when they are not going to be touched at all.
    
    This change in passing makes the modified code block's comment saying
    that SETCREDF_SUPP_GROUPS need not be set here correct.
    
    MFC after:      2 weeks
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D53771
    
    (cherry picked from commit b92b1b47583036bd02e656564ff22c92b8949077)
---
 usr.bin/mdo/mdo.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/usr.bin/mdo/mdo.c b/usr.bin/mdo/mdo.c
index 3eb5d4e5c23f..879423bc0128 100644
--- a/usr.bin/mdo/mdo.c
+++ b/usr.bin/mdo/mdo.c
@@ -753,8 +753,14 @@ main(int argc, char **argv)
 			 */
 			setcred_flags |= SETCREDF_SUPP_GROUPS;
 		}
-	} else if (supp_groups_str == NULL && (supp_mod_str == NULL ||
-	    supp_mod_str[0] != '@')) {
+	} else if (supp_groups_str == NULL && supp_mod_str != NULL &&
+	    supp_mod_str[0] != '@') {
+		/*
+		 * We do not need to determine the current groups if, as for the
+		 * '!start_from_current_groups' case, we are going to replace
+		 * them entirely, but here also if we do not amend them at all
+		 * (because they are by definition already in place).
+		 */
 		const int ngroups = getgroups(0, NULL);
 
 		if (ngroups > 0) {