git: ab4f4f4efaac - stable/15 - kgssapi: Remove broken MOD_UNLOAD code
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 09 Dec 2025 16:33:01 UTC
The branch stable/15 has been updated by emaste:
URL: https://cgit.FreeBSD.org/src/commit/?id=ab4f4f4efaac85bbf235e60f2ced4876a9e916f2
commit ab4f4f4efaac85bbf235e60f2ced4876a9e916f2
Author: Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2025-11-27 16:44:08 +0000
Commit: Ed Maste <emaste@FreeBSD.org>
CommitDate: 2025-12-09 16:32:09 +0000
kgssapi: Remove broken MOD_UNLOAD code
The module panicked at unload with "recursing but non-recursive rw".
There is a comment that "Unloading of the kgssapi module is not
currently supported" and the MOD_UNLOAD case falls through to returning
EOPNOTSUPP anyway. Just #if 0 the code in the unload path, leaving it
as a hint in case someone implements unload support later on.
PR: 291249
Reviewed by: rmacklem
Fixes: ad704a34bc2c ("Use syscall_helper_register(9) rather than syscall_register().")
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53949
(cherry picked from commit 6901376f59b870ddbb0d922e3455a388333cd460)
---
sys/kgssapi/gss_impl.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sys/kgssapi/gss_impl.c b/sys/kgssapi/gss_impl.c
index c9cd4d880695..323b379e1619 100644
--- a/sys/kgssapi/gss_impl.c
+++ b/sys/kgssapi/gss_impl.c
@@ -88,6 +88,7 @@ kgss_load(void)
return (0);
}
+#if 0
static void
kgss_unload(void)
{
@@ -96,6 +97,7 @@ kgss_unload(void)
clnt_destroy(KGSS_VNET(kgss_gssd_handle));
KGSS_CURVNET_RESTORE();
}
+#endif
int
kgss_oid_equal(const gss_OID oid1, const gss_OID oid2)
@@ -297,8 +299,10 @@ kgssapi_modevent(module_t mod, int type, void *data)
error = kgss_load();
break;
case MOD_UNLOAD:
+#if 0
kgss_unload();
mtx_destroy(&kgss_gssd_lock);
+#endif
/*
* Unloading of the kgssapi module is not currently supported.
* If somebody wants this, we would need to keep track of