Re: git: 5f529f9e292a - main - libc: Fix TESTSDIR for new stdbit tests

Hi Jessica,

Am Mon, Dec 01, 2025 at 02:10:14PM +0000 schrieb Jessica Clarke:
> The branch main has been updated by jrtc27:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=5f529f9e292a30c065c316ed5fd0d23e07b26e5c
> 
> commit 5f529f9e292a30c065c316ed5fd0d23e07b26e5c
> Author:     Jessica Clarke <jrtc27@FreeBSD.org>
> AuthorDate: 2025-12-01 14:06:21 +0000
> Commit:     Jessica Clarke <jrtc27@FreeBSD.org>
> CommitDate: 2025-12-01 14:06:21 +0000
> 
>     libc: Fix TESTSDIR for new stdbit tests
>     
>     Otherwise the directory created by etc/mtree/BSD.tests.dist, which is
>     where these belong, and referred to by the generated Kyuafile for
>     /usr/tests/lib/libc (via stdbit's existence in TESTS_SUBDIRS), ends up
>     empty with no Kyuafile, which is an error for kyua.
>     
>     Reported by:    kp
>     Fixes:          2fb8cbc6ef1b ("libc/tests: add stdbit test framework and unit tests")
> ---
>  lib/libc/tests/stdbit/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/libc/tests/stdbit/Makefile b/lib/libc/tests/stdbit/Makefile
> index 37450056007a..8dbc86528de3 100644
> --- a/lib/libc/tests/stdbit/Makefile
> +++ b/lib/libc/tests/stdbit/Makefile
> @@ -1,3 +1,5 @@
> +TESTSDIR=	${TESTSBASE}/lib/libc/stdbit
> +
>  # ensure libc functions are tested, not clang's builtins
>  CFLAGS+=	-fno-builtin

Many thanks for the quick fix!

Yours,
Robert Clausecker

-- 
()  ascii ribbon campaign - for an encoding-agnostic world
/\  - against html email  - against proprietary attachments