From nobody Fri Apr 25 11:48:34 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZkWM727vSz5tSY4; Fri, 25 Apr 2025 11:48:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZkWM664s6z45kn; Fri, 25 Apr 2025 11:48:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745581714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mVdb1dmmMJ7C+3U9SWw28IpL16b9yZ6whamEBeAMmyQ=; b=YypUPk5c8KfkwxcarPzLReS1nvfayPauk0SItOto3wTnM44ZKWLqq0+TRgx1WPHnyiDYSa NISn6UEFj196cAaU888irDpGX/ti3kxVatMKbi8C/LUJrZvO1ffbKey/07qtRtN55Tz2y/ dQR/WCeITr2b06fb6UiktdOABeI29I1Vr262y9C9mUJ8kerFyU8sdGBtf4AnPSEcmKEO4A S8xb6aECMQEI8Txzz5Y5RzzwN7ZgE6bb8eQB9D6dv8u4FYt+qjllunk/lRu//RLWVESlo/ VQP9ZqoKM5e0IUGJqaWJMKrkc+unTZfRt01rOWe0RSWB55QMUgxBATQACtO3Aw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745581714; a=rsa-sha256; cv=none; b=lT8Im+qE5hVdcsq4JE94XRcVjU1Ml7m8k5KRAbXOrLTehel/O8gOMzYKrNBE6LDqNexXQ/ v8L88ig+uIxS8OpXceYVHiHR4dStwg7QHvMMfJzTEmblG8eTcA2sGnEMjsqs0a0azBUIt3 iOd7RInaljI8rXv0A1Z4/w/bbyxdNoKtyfynCKPbDWyaKEC/8grLCRZNwtl3dPKyvHofFA RuSS92iccAy8sqvaq72FKLYUwhX4EI9T7+Mbe6obnIPs3/g5zENQCK3ITVnZPy4noANvR9 2hVEVRM7siO0hoLI9pO9z8B6z881M5/51KF9D5BUgYtPmfv4rwBl0sBewR1XwA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745581714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mVdb1dmmMJ7C+3U9SWw28IpL16b9yZ6whamEBeAMmyQ=; b=Cfqus1f2sVNqEL2JmgwzHh8P+/NPvYzIZlKuhnalXKOHFMg3WxCXEdLnmpHIEWOlgGgY2F IGS2K3xquy2i8GzgJXYdEAXS5PO9++uionoacXUjzgQCTH3FQthption/rHvZpjf59kraJ 8/O0SwrA9mQxK+tlOtaG0w+poSx1FldF7CD9LglB4c8SxvbqrJUXRVMPJQ4mduRod6CAcU wspCy61U/Ikpq45GVmUlqZMOnIsF2PNv2TTVtUNpGWllYSmCzE6yFVf/0sIk13atMeT+xn 6CfP7nn2Yb0c5TN790957tGgBu2aOA3otVjEMCnxLeAOGn9dz0NQsxtMr+1MXQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZkWM65gyQzZqv; Fri, 25 Apr 2025 11:48:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53PBmYju053608; Fri, 25 Apr 2025 11:48:34 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53PBmYb1053605; Fri, 25 Apr 2025 11:48:34 GMT (envelope-from git) Date: Fri, 25 Apr 2025 11:48:34 GMT Message-Id: <202504251148.53PBmYb1053605@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 22e564c74eb2 - main - libthr: properly align struct pthreads List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 22e564c74eb20e14bd93fd9fdde20e38a29cfcf1 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=22e564c74eb20e14bd93fd9fdde20e38a29cfcf1 commit 22e564c74eb20e14bd93fd9fdde20e38a29cfcf1 Author: Konstantin Belousov AuthorDate: 2025-04-24 21:24:19 +0000 Commit: Konstantin Belousov CommitDate: 2025-04-25 11:48:12 +0000 libthr: properly align struct pthreads For instance, the structure contains the struct _Unwind_Exception, and it seems that libgcc requires specific alignment for it. PR: 285711 Tested by: Oleg Sidorkin Sponsored by: The FreeBSD Foundation MFC after: 1 week --- lib/libthr/thread/thr_list.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/libthr/thread/thr_list.c b/lib/libthr/thread/thr_list.c index bbc1d2899cb9..5578abdc8727 100644 --- a/lib/libthr/thread/thr_list.c +++ b/lib/libthr/thread/thr_list.c @@ -150,11 +150,13 @@ _thr_alloc(struct pthread *curthread) if (total_threads > MAX_THREADS) return (NULL); atomic_add_int(&total_threads, 1); - thread = __thr_calloc(1, sizeof(struct pthread)); + thread = __thr_aligned_alloc_offset(_Alignof(struct pthread), + sizeof(struct pthread), 0); if (thread == NULL) { atomic_add_int(&total_threads, -1); return (NULL); } + memset(thread, 0, sizeof(*thread)); if ((thread->sleepqueue = _sleepq_alloc()) == NULL || (thread->wake_addr = _thr_alloc_wake_addr()) == NULL) { thr_destroy(curthread, thread);