From nobody Wed Apr 23 20:19:48 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZjVp8335qz5tq50; Wed, 23 Apr 2025 20:20:00 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZjVp81jDJz3Hr9; Wed, 23 Apr 2025 20:20:00 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745439600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PL9u2U9bMjuBTsCYNPoqtM2a+/LVuT1DDQST4jF06FY=; b=LOHIagPGDGhjiIzEKQG3duXJQRJcmH0OVQvd78LeHr77d+1gVZykfNJd+FBkDztHNCVc3S 9u7M20ShLKiV2sw0RwdfL1ETsYU6u2ERZbJ3aqI4AX41oOh51mCITtRWp9sGup6lPx1P5t xA+xtXldGVx+IZRsjPEL+YXb1KjgdIlOW2h+9PM9n4AN1zaT8V7zmfte8TJKxl9lSh1+M5 1BNIgSUnexxKwgE9kFZ4mzuNoP0hFJwxgeHMFD8hrhT/xjvEoHYsuBtrcUd4Z+z0S45ket Pj/1gLJQ8A71qAizLv+9/eS97vEY3AX1mC0lEYsIVdWVE9G8vcZ4hMa0RcEhpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745439600; a=rsa-sha256; cv=none; b=GxozFvWfltdu6X4p9FKHZNBKsvW/q7Jor0g2JuXwU4VYnQxvy7ISZl8sfpEqQ13olOH4uh ogSWHohW9fO9be91OBSzPHzBLfI3+p1MHhDvr1X+94BI67SpwEGlqlnE6niCBdgjyN3KW5 EvEzG6zA4XjRO52RCi/XxS4YnAeP1GzFROAgn/l/UEABbSNVqrBTi9sK+e8b49+sorTl5H Ma/lqK1wu5n1hD1lc7Z3SRrXV9vMNmKv4bBac9YVMTE9nSIAC67bzZYBd2/6tugFgQZSer DpbOSXtdGrWpdjaFTgyrSNWPPviaYI3btVYOIP3LUwgTgy19KEtiYfcj4I5nJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745439600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PL9u2U9bMjuBTsCYNPoqtM2a+/LVuT1DDQST4jF06FY=; b=CL14kcL03I6uMxEXZsLDvkpARYyr0whQn03OQNfR6PX9SLSG46uYM44oZl+90yH0uR2jng VPSq8gP9phOmawemA8aT/gq0g/gzgi94nLr9Wm8gO6gwoUlPJHE2S33nuA6WJ+hwbuJTIf ZpFmKppAtfzw5EenupM7nKJTqglZefz3YrCp3o9zJdYFjBr6LwjzaZjXzMzHwNIs1F6VXS qq7qfIAmdaOdNkAXXjxbWEujC8fSQPFlyIcP0EfvYN0aepEbPurJ8YhePTZVOAFdKZoV60 rQVVx0+r1YH4W9Wa2C5Pg1/P0Y0tul27/0jMc5IBrRYIcBc912Q2xv/RHBO/vQ== Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZjVp80z21zppx; Wed, 23 Apr 2025 20:20:00 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-479009c951cso387571cf.1; Wed, 23 Apr 2025 13:20:00 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCV3iSrv799002NE2m8tTka95DKYucoMxznjX8e6coDXKLD9xO/si6jxhcElc7p3QGR0l1WqvwGFAFdW5p6wpCDChVK/@freebsd.org, AJvYcCVWTU/WOsiraWx9IgYDPPgShT/UNsYQ/1mty6cTgy5l2U0No1kT+tEgMyZRUqXZxa/apfAIH6AAgUXTuodTFHz9favAibY=@freebsd.org X-Gm-Message-State: AOJu0YwDWeEatVPhyMFKAyg+8oPlMiQiIq3k2KIaMAgoykWz0rvaVNBq CnG9cLVAC33DX7+FIvzYo14LEgneJaWQhWbgcaiPhEqwjWropeBh2PE91HXGfOPEmfqllshG6wp +Oth3UuxzB3qBXxiYuW0R87+uS00= X-Google-Smtp-Source: AGHT+IHCSNtnmmilyGz2gYWVMYZ6Q1Mi60jtSh4MPWpWxWXq2mtGbwWyz7Iu0uDQkIC0gepUTAUG5Hum09jxs1l9src= X-Received: by 2002:a05:622a:8e:b0:476:ad95:c08 with SMTP id d75a77b69052e-47d1be7947cmr24217451cf.5.1745439599744; Wed, 23 Apr 2025 13:19:59 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202504230204.53N248Jb070185@gitrepo.freebsd.org> In-Reply-To: <202504230204.53N248Jb070185@gitrepo.freebsd.org> From: Nuno Teixeira Date: Wed, 23 Apr 2025 21:19:48 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: ATxdqUFSvDdC0T3eOpHmDfOnCojc4E96OcOsv5xoNFKBoAzmrfq9u8c8XbwWRmA Message-ID: Subject: Re: git: 5c74aa3abd4e - main - rtwn: enable reception of BAR frames To: Adrian Chadd Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello all, I used to have a stable 11ac connection with Archer T2U PLUS [RTL8821AU] on arm64 (rpi4). world is at main-n276705-e3e55936ce3b: Wed Apr 23 I noticed that `git pull --rebase` was taking too much time and sometimes failed. /var/log/messages have tons of: rtwn0: rtwn_rx_copy_to_mbuf: could not allocate RX mbuf iperf3 to local machine connected with ethernet also fails: % iperf3 -c hp -R Connecting to host hp, port 5201 Reverse mode, remote host hp is sending [ 5] local 192.168.1.102 port 14481 connected to 192.168.1.100 port 5201 [ ID] Interval Transfer Bitrate [ 5] 0.00-1.01 sec 0.00 Bytes 0.00 bits/sec [ 5] 1.01-2.01 sec 0.00 Bytes 0.00 bits/sec [ 5] 2.01-3.01 sec 0.00 Bytes 0.00 bits/sec [ 5] 3.01-4.06 sec 0.00 Bytes 0.00 bits/sec [ 5] 4.06-5.01 sec 0.00 Bytes 0.00 bits/sec [ 5] 5.01-6.04 sec 0.00 Bytes 0.00 bits/sec [ 5] 6.04-7.06 sec 0.00 Bytes 0.00 bits/sec [ 5] 7.06-8.06 sec 512 KBytes 4.21 Mbits/sec [ 5] 8.06-9.06 sec 0.00 Bytes 0.00 bits/sec [ 5] 9.06-10.04 sec 0.00 Bytes 0.00 bits/sec - - - - - - - - - - - - - - - - - - - - - - - - - [ ID] Interval Transfer Bitrate Retr [ 5] 0.00-10.04 sec 640 KBytes 522 Kbits/sec 30 sender [ 5] 0.00-10.04 sec 512 KBytes 418 Kbits/sec recei= ver Any clues if this related to this commit? Thanks, Adrian Chadd escreveu (quarta, 23/04/2025 =C3=A0(s) 03= :04): > > The branch main has been updated by adrian: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D5c74aa3abd4e353ed7f8cb446c= 0527c8ebe15d1c > > commit 5c74aa3abd4e353ed7f8cb446c0527c8ebe15d1c > Author: Jessica Clarke > AuthorDate: 2025-04-01 00:43:13 +0000 > Commit: Adrian Chadd > CommitDate: 2025-04-23 02:02:39 +0000 > > rtwn: enable reception of BAR frames > > The RX filter wasn't enabling BAR frames, so we weren't receiving the= m > during normal operation. > > Jessica noticed we WERE getting BAR frames, but only when promisc mod= e > is active. Which is a different set of bugs, but it did highlight > the differences here. > > Differential Revision: https://reviews.freebsd.org/D49596 > PR: kern/285822 > --- > sys/dev/rtwn/if_rtwn.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/sys/dev/rtwn/if_rtwn.c b/sys/dev/rtwn/if_rtwn.c > index 7df1b78db37b..7a547e13cafa 100644 > --- a/sys/dev/rtwn/if_rtwn.c > +++ b/sys/dev/rtwn/if_rtwn.c > @@ -1203,6 +1203,9 @@ rtwn_newstate(struct ieee80211vap *vap, enum ieee80= 211_state nstate, int arg) > /* Stop Rx of data frames. */ > rtwn_write_2(sc, R92C_RXFLTMAP2, 0); > > + /* Stop Rx of control frames. */ > + rtwn_write_2(sc, R92C_RXFLTMAP1, 0); > + > /* Reset EDCA parameters. */ > rtwn_write_4(sc, R92C_EDCA_VO_PARAM, 0x002f3217); > rtwn_write_4(sc, R92C_EDCA_VI_PARAM, 0x005e4317); > @@ -1374,6 +1377,11 @@ rtwn_run(struct rtwn_softc *sc, struct ieee80211va= p *vap) > rtwn_write_2(sc, R92C_BCN_INTERVAL(uvp->id), ni->ni_intval); > > if (sc->vaps_running =3D=3D sc->monvaps_running) { > + /* Enable Rx of BAR control frames. */ > + rtwn_write_2(sc, R92C_RXFLTMAP1, > + 1 << (IEEE80211_FC0_SUBTYPE_BAR >> > + IEEE80211_FC0_SUBTYPE_SHIFT)); > + > /* Enable Rx of data frames. */ > rtwn_write_2(sc, R92C_RXFLTMAP2, 0xffff); > > --=20 Nuno Teixeira FreeBSD UNIX: Web: https://FreeBSD.org