git: 998fc383bd02 - stable/14 - LinuxKPI: 802.11: remove ieee80211_node_get_txrate_dot11rate()

The branch stable/14 has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=998fc383bd02e8f1abe3c67decb60dc326c87908

commit 998fc383bd02e8f1abe3c67decb60dc326c87908
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2025-03-04 15:20:06 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2025-04-18 14:35:59 +0000

    LinuxKPI: 802.11: remove ieee80211_node_get_txrate_dot11rate()
    
    net80211 ieee80211_node_get_txrate_dot11rate() does not yet support
    VHT and that means we get a lot of log lines when doing VHT for a
    debugging statement even if it's not active.
    Remove the calls to ieee80211_node_get_txrate_dot11rate() as with
    hw/fw based rate control (modern iwlwifi) they are pointless anyway
    as they are currently.
    
    Sponsored by:   The FreeBSD Foundation
    Reported by:    J.R. Oldroyd (jr opal.com)
    Fixes:          706745001093 (I should have noticed during review)
    
    (cherry picked from commit d1a37f280be46a707b42c3eca5f8b6a38ecf726b)
---
 sys/compat/linuxkpi/common/src/linux_80211.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c
index b0bf54744e3a..3d60404537e2 100644
--- a/sys/compat/linuxkpi/common/src/linux_80211.c
+++ b/sys/compat/linuxkpi/common/src/linux_80211.c
@@ -6986,12 +6986,6 @@ linuxkpi_ieee80211_tx_status_ext(struct ieee80211_hw *hw,
 	}
 
 	if (ni != NULL) {
-		int ridx __unused;
-#ifdef LINUXKPI_DEBUG_80211
-		int old_rate;
-
-		old_rate = ni->ni_vap->iv_bss->ni_txrate;
-#endif
 		txs.pktlen = skb->len;
 		txs.flags |= IEEE80211_RATECTL_STATUS_PKTLEN;
 		if (info->status.rates[0].count > 1) {
@@ -7008,16 +7002,13 @@ linuxkpi_ieee80211_tx_status_ext(struct ieee80211_hw *hw,
 			txs.flags |= IEEE80211_RATECTL_STATUS_RSSI;
 		}
 
-		IMPROVE("only update of rate matches but that requires us to get a proper rate");
+		IMPROVE("only update rate if needed but that requires us to get a proper rate from mo_sta_statistics");
 		ieee80211_ratectl_tx_complete(ni, &txs);
-		ridx = ieee80211_ratectl_rate(ni->ni_vap->iv_bss, NULL, 0);
 
 #ifdef LINUXKPI_DEBUG_80211
 		if (linuxkpi_debug_80211 & D80211_TRACE_TX) {
-			printf("TX-RATE: %s: old %d new %d ridx %d, "
-			    "long_retries %d\n", __func__,
-			    old_rate, ni->ni_vap->iv_bss->ni_txrate,
-			    ridx, txs.long_retries);
+			printf("TX-RATE: %s: long_retries %d\n", __func__,
+			    txs.long_retries);
 		}
 #endif
 	}