From nobody Fri Apr 11 14:03:54 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZYz1k2LPFz5s43s; Fri, 11 Apr 2025 14:03:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZYz1k1dhPz43DZ; Fri, 11 Apr 2025 14:03:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744380234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f+ezLXzEGzRdD3pMVtyDY38rkPy5FNmKPR8n0wvuWVI=; b=aOVcBW8LzXhn92nCBzbpSUo9GbAbVvjoG4yKs3DtFyka5luPHhIIDF44FoB/idJuQQW6Wz QB238EUC50/85FiTmgnkp/eCi/cU+ALZvISMLf0ZRUSLVtJcdFdpcxZtGziLWDgkUkFEOL kXZhpIf9tPS2rBWQtK9TIogMSAwoNs65MH25iLrrYQe7Ic/OBE2C9tnBh6FI+7ER2ZL3O2 /Oi338r507ghRyta0PRtOvOh+VBBKJEJ1jKxTVCwwshD+vME7nmUSBsBmR3ii4coxKsLZj JA0s+duzrMix6rQt5buueRuvyHIMjWZh4MBe2fSTmd9HjkpMjeje6pSsXdS03A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744380234; a=rsa-sha256; cv=none; b=A+ZuUivcnmVOLr8Rcnyg1z7UBdUXRhP8eNNYRvILUSGPhvoAHpuVp1p1C1ii17F6HvxnsZ 57oDrU+EJluEB6tXPYJiKkL424gLlAfjG+3RS8rt6hUvfzgF5XZWaWaqqF8wEvG71JQCRi nvBUATLtzA9EUH0vXjYmZIjNSDj1MhxNBKdrwW3cb6cIQybNs86DUV9/yJsBwaoJ/nAHyL W1c0lHSctiA8JNm68ZMFRSqS8ugCFpdRgFMPKabX160b4VC7s4tIoZ+sAlje6T+xW62zaq q2krkatTlcXNoSyBwkSCQDI0CqGnKLAaFvbpGWWpuDxWg+P2ruZCYX2SDM7exQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744380234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f+ezLXzEGzRdD3pMVtyDY38rkPy5FNmKPR8n0wvuWVI=; b=SIDngO4TnyLsmiPl9dnF7E45sRT8YB9/MPXfjAJgMkTnu/ceS5Ci7+fEpYtv/z5BVhyVta LGGbTp81KAiu6JUUnpNuqzZ9/OpV44E8j5h8lux7o60bJtuQ1/hvJSX9Ev1BEy4hQd/QY3 uX/ivwaTw37FBBM9rdUZkWrRCedqdLFQENSpmrKW89Y7mzCvwX/BHZquf6DERED3+i5uuF uPcJGdf47oEtv+HtuKTj/7KbAPyYANSjdQmznUIiCFdLDUiEQQJMGcu6QQfxfBBmruvPmL XK1NFDBi7JknI08/68bu7WjJ0yQbglV7ghOo8Hf24ciZaiKGaaNZhvw30ciXlA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZYz1k19crzbjl; Fri, 11 Apr 2025 14:03:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53BE3sM7053498; Fri, 11 Apr 2025 14:03:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53BE3sS7053495; Fri, 11 Apr 2025 14:03:54 GMT (envelope-from git) Date: Fri, 11 Apr 2025 14:03:54 GMT Message-Id: <202504111403.53BE3sS7053495@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: e7611b7531c4 - main - ctld: Fix sign bug validating kernel ports when reloading config List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e7611b7531c4fc6d26d36faad79088f277af78f0 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=e7611b7531c4fc6d26d36faad79088f277af78f0 commit e7611b7531c4fc6d26d36faad79088f277af78f0 Author: John Baldwin AuthorDate: 2025-04-11 13:59:24 +0000 Commit: John Baldwin CommitDate: 2025-04-11 13:59:24 +0000 ctld: Fix sign bug validating kernel ports when reloading config When I switched new_pports_from_conf to return bool instead of an inverted int, I missed updating the call after reloading the config file due to SIGHUP. Fixes: 450a84c292ae ("ctld: Some bool-related cleanups") Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D49641 --- usr.sbin/ctld/ctld.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/ctld/ctld.cc b/usr.sbin/ctld/ctld.cc index f07ee7b34cd7..03a298146f4a 100644 --- a/usr.sbin/ctld/ctld.cc +++ b/usr.sbin/ctld/ctld.cc @@ -2601,7 +2601,7 @@ main(int argc, char **argv) if (tmpconf == NULL) { log_warnx("configuration error, " "continuing with old configuration"); - } else if (new_pports_from_conf(tmpconf, &kports)) { + } else if (!new_pports_from_conf(tmpconf, &kports)) { log_warnx("Error associating physical ports, " "continuing with old configuration"); conf_delete(tmpconf);