From nobody Tue Apr 08 13:40:57 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZX6ff50fbz5sQ5Q; Tue, 08 Apr 2025 13:40:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZX6fd6cqMz3D6R; Tue, 08 Apr 2025 13:40:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744119657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BE+Dr10N0YaOlfQ2LSVoyToa0DZE250BGKrdCPsPmOw=; b=kXMv1JKpSwWozBWN0iA3WtUz5jbkyybSEUO5b6uEuxHLjkDcVx38HwoT1zhNVvR+iBU62S +PzHTUGHkK5I2aT4asvd74aIpAFeilc06pROoZYwSZMzZcUyEIZB4HiGuoo7wqDjWe6HEy s+tno6uOe87i4RRwChdP9mUP1tiOQ6J3gDrzsyYqzSH+SvQH9Qhd0q0BVpGsWbNI6hQ1T9 hN0KkDf1zRmgqs7knGHQg7goGxgLpHOGc2NmoRc7vPfh0rscJt20ZH/HymHd8O40khENtW kQ58YgHm2B8bMMxxQkYJLkSw8qGidM1CXO/gGX6KxlG/eua03wICmbAv8nhh5A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744119657; a=rsa-sha256; cv=none; b=ZcVAbg89WJ9r26c6AkhYaBwabYbQmC82MgYqmDZ4ixpST9V4FBI3ZaW9SqqOYX3c4CTl2d aaY4FbMzXeTEzspzYZz082i16yVWZYJv1To8sVeSPH7X1Ok8I64sxnyPMZqz4h5qdqq4P9 Hm9nKRnoArcjmWAFD9b3NRHjJpP0VdPxVwAjlpTdtsrc46Cri5DUgbHpa+vE6BRgYUuTjW Fx7MDq/QOWdnflWFPZRl3M+GM3WAYIuCrIRIumYAoHjnx1t2JgfdT6XCgBgLeaXFQ/MgQe necoDU3T2JZfKHm1pFS6kSbmRCOkULEA1aho9idNPXaOTEXJ/sC4sCU9Vsx41w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744119657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BE+Dr10N0YaOlfQ2LSVoyToa0DZE250BGKrdCPsPmOw=; b=uJBTeoGidKUkXPCs6nT2/91t29s3oaZXJGJnxn2vzjkOyc1MYe915qJZgRvjjb3TU47Swq jahQ5pnw+c6XgkWuUS1gx7b70U3sU9tmjYTU8HqhKixuwl65XQtRVqcBU28vEJb26dDyGy rqgGkeGY25Zs5rxO+7mppiJrD/wP0iLmUwcH2wBgMSBFcY/RMNoD2mKXLqkAhVXYqac3sC 1b6XyeeG64xW+30cBretCE499l623p3Mv09iUBMOvGaUswFiitDjJyclfAdsWTk9AubPWY IQaEdh18unZgOQUoSJt1pbCTdRBhLHliztxs1b/HzH4PDDP7FFzwaEF2yIjN+Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZX6fd5p3xzbJc; Tue, 08 Apr 2025 13:40:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 538Devhc032278; Tue, 8 Apr 2025 13:40:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 538DevEN032275; Tue, 8 Apr 2025 13:40:57 GMT (envelope-from git) Date: Tue, 8 Apr 2025 13:40:57 GMT Message-Id: <202504081340.538DevEN032275@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: cc1cb8e37646 - stable/14 - smbios: style(9): smbios_cksum() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: cc1cb8e376464e41dcc2de532552fd7e83695b13 Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=cc1cb8e376464e41dcc2de532552fd7e83695b13 commit cc1cb8e376464e41dcc2de532552fd7e83695b13 Author: Olivier Certner AuthorDate: 2025-03-04 16:29:22 +0000 Commit: Olivier Certner CommitDate: 2025-04-08 13:38:25 +0000 smbios: style(9): smbios_cksum() Reduce some variables' lifecycle. Remove useless casts. Remove superfluous braces. Add some consts. MFC after: 2 weeks Sponsored by: The FreeBSD Foundation (cherry picked from commit ef446a8065ac0228a5da15f233cd2f964e4d7433) --- sys/dev/smbios/smbios.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/sys/dev/smbios/smbios.c b/sys/dev/smbios/smbios.c index 24e110f722d3..b9fd7bd25f11 100644 --- a/sys/dev/smbios/smbios.c +++ b/sys/dev/smbios/smbios.c @@ -339,25 +339,24 @@ smbios_eps3 (void *v) static int smbios_cksum (void *v) { - struct smbios3_eps *eps3; - struct smbios_eps *eps; - u_int8_t *ptr; + const u_int8_t *ptr; u_int8_t cksum; u_int8_t length; int i; if (smbios_eps3(v)) { - eps3 = (struct smbios3_eps *)v; + const struct smbios3_eps *eps3 = v; + length = eps3->length; } else { - eps = (struct smbios_eps *)v; + const struct smbios_eps *eps = v; + length = eps->length; } - ptr = (u_int8_t *)v; + ptr = v; cksum = 0; - for (i = 0; i < length; i++) { + for (i = 0; i < length; i++) cksum += ptr[i]; - } return (cksum); }