git: be2940e90864 - stable/14 - amd64: do not pass -z rodynamic to ld.bfd when building vdso
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 24 Oct 2024 02:46:10 UTC
The branch stable/14 has been updated by kib:
URL: https://cgit.FreeBSD.org/src/commit/?id=be2940e908642c3019ba8196430c2cb09f1dc532
commit be2940e908642c3019ba8196430c2cb09f1dc532
Author: Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2024-10-18 14:09:26 +0000
Commit: Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2024-10-24 02:44:40 +0000
amd64: do not pass -z rodynamic to ld.bfd when building vdso
(cherry picked from commit 3b2cf9381ef86847603c3c94811f638660c417ae)
---
sys/tools/amd64_ia32_vdso.sh | 7 ++++++-
sys/tools/amd64_vdso.sh | 9 +++++++--
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/sys/tools/amd64_ia32_vdso.sh b/sys/tools/amd64_ia32_vdso.sh
index 59923749042f..85d2299b45d0 100644
--- a/sys/tools/amd64_ia32_vdso.sh
+++ b/sys/tools/amd64_ia32_vdso.sh
@@ -34,9 +34,14 @@ ${CC} -x assembler-with-cpp -DLOCORE -fPIC -nostdinc -c -m32 \
-o ia32_sigtramp.pico -I. -I"${S}" -include opt_global.h \
"${S}"/amd64/ia32/ia32_sigtramp.S
+if ${LD} --version | ${AWK} '/^GNU ld/{exit 1}' ; then
+ RODYNAMIC="-z rodynamic"
+else
+ RODYNAMIC=""
+fi
${LD} --shared -Bsymbolic -soname="elf-vdso32.so.1" \
-T "${S}"/conf/vdso_amd64_ia32.ldscript \
- --eh-frame-hdr --no-undefined -z rodynamic -z norelro -nmagic \
+ --eh-frame-hdr --no-undefined ${RODYNAMIC} -z norelro -nmagic \
--hash-style=sysv --fatal-warnings --strip-all \
-o elf-vdso32.so.1 ia32_sigtramp.pico
diff --git a/sys/tools/amd64_vdso.sh b/sys/tools/amd64_vdso.sh
index aec0694ebdb1..2a83ae874ab7 100644
--- a/sys/tools/amd64_vdso.sh
+++ b/sys/tools/amd64_vdso.sh
@@ -40,12 +40,17 @@ ${CC} -x assembler-with-cpp -DLOCORE -fPIC -nostdinc -c \
#
# -z rodynamic is undocumented lld-specific option, seemingly required
# for lld to avoid putting dynamic into dedicated writeable segment,
-# despite ldscript placement. It is ignored by ld.bfd but ldscript
+# despite ldscript placement. It is omitted for ld.bfd, but ldscript
# alone is enough there.
#
+if ${LD} --version | ${AWK} '/^GNU ld/{exit 1}' ; then
+ RODYNAMIC="-z rodynamic"
+else
+ RODYNAMIC=""
+fi
${LD} --shared -Bsymbolic -soname="elf-vdso.so.1" \
-T "${S}"/conf/vdso_amd64.ldscript \
- --eh-frame-hdr --no-undefined -z rodynamic -z norelro -nmagic \
+ --eh-frame-hdr --no-undefined ${RODYNAMIC} -z norelro -nmagic \
--hash-style=sysv --fatal-warnings --strip-all \
-o elf-vdso.so.1 sigtramp.pico