Re: git: aa48259f3371 - main - periodic.conf: remove long deprecated security_daily_compat_var()

On 23 May 2024, at 10:14, Baptiste Daroussin wrote:

> On Thu 23 May 14:34, Michael Osipov wrote:
>> On 2024-05-23 14:10, Mike Karels wrote:
>>> On 22 May 2024, at 10:07, Baptiste Daroussin wrote:
>>>
>>>> On Fri 03 May 07:40, Michael Osipov wrote:
>>>>> The branch main has been updated by michaelo:
>>>>>
>>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=aa48259f337100e79933d660fec8856371f761ed
>>>>>
>>>>> commit aa48259f337100e79933d660fec8856371f761ed
>>>>> Author:     Michael Osipov <michaelo@FreeBSD.org>
>>>>> AuthorDate: 2024-04-15 11:05:17 +0000
>>>>> Commit:     Michael Osipov <michaelo@FreeBSD.org>
>>>>> CommitDate: 2024-05-03 07:38:55 +0000
>>>>>
>>>>>      periodic.conf: remove long deprecated security_daily_compat_var()
>>>>>
>>>>>      This function is documented to be gone in after 11. Time to remove this
>>>>>      compat shim.
>>>>>
>>>>>      PR:             275296
>>>>>      Reviewed by:    jrm (mentor)
>>>>>      MFC after:      1 month
>>>>>      Differential Revision:  https://reviews.freebsd.org/D44796
>>>>
>>>> this broke pkg's periodic script, I would have appreciated a heads up to give me
>>>> time to prepare a release compatible prior this commit.
>>>>
>>>> This also breaks some ports.
>>>>
>>>> Bapt
>>>
>>> This produces almost a dozen failure messages in the daily security email.
>>> Given that the deprecated function was still in use, it should not be removed.
>>> Michael, please revert this.
>>
>> Salut Baptiste,
>> Hi Mike,
>>
>> this is surprising that is it still in use although clear marked as
>> deprecated after 11. Though, Baptiste has pushed a new pkg release yesterday
>> [1] and only main is affected, do you still prefer to revert this commit
>> (for now)?
>>
>> @bapt, can you name the affected ports and report a PR, so we can track
>> them?
>>
>
> This was in use beside the deprecation, because pkg for one is supposed to
> support as many version of freebsd as possible so we had to keep the deprecation
> notice.
>
> I have released a new version of pkg without it and merged that version in
> quarterly branches, so even if it gets MFCed we should be safe.
>
> I was scared more ports where keeping for the same reason the deprecated code, I
> span the ports tree itself and found one port which I fixed straight away, I
> also did a deep analysis of the any port which plist contains etc/periodic,
> I extracted all their sources and I found nothing.
>
> so I think we are safe now. I don't think we should revert.
>
> Best regards,
> Bapt

OK, I'll withdraw my request to revert if we're confident that there are no
stragglers.

		Mike