Re: git: 408957613bc0 - main - Regen

On 5/22/24 3:36 AM, Dmitry Salychev wrote:
> 
> Lexi Winter <lexi@le-fay.org> writes:
> 
>> [[PGP Signed Part:Undecided]]
>> Mariusz Zaborski:
>>> The branch main has been updated by oshogbo:
>>>
>>> URL: https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c4444812c3ae276ace03697ebd
>>>
>>> commit 408957613bc065c4444812c3ae276ace03697ebd
>>> Author:     Mariusz Zaborski <oshogbo@FreeBSD.org>
>>> AuthorDate: 2024-05-21 20:02:50 +0000
>>> Commit:     Mariusz Zaborski <oshogbo@FreeBSD.org>
>>> CommitDate: 2024-05-21 20:03:20 +0000
>>>
>>>      Regen
>>> ---
>>>   sys/compat/freebsd32/freebsd32_sysent.c | 2 +-
>>>   sys/kern/init_sysent.c                  | 2 +-
>>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> i'm sorry if this is considered accepted practice in FreeBSD (i'm not a
>> committer) but could i please request more useful commit messages than
>> "Regen" for things like this?
>>
>> when looking through 'git log', especially 'git log --format=oneline',
>> it's really not clear what this commit actually does, meaning if i'm
>> looking through the log for commits related to a problem i'm having, i
>> have to examine commits like this by hand to see if they're related.
>>
>> it would save me (and other people, i suppose) a lot of time if the
>> commit message could at least mention what it's touching, e.g. "Regen
>> sys/compat/freebsd32/freebsd32_sysent.c".
>>
>> [[End of PGP Signed Part]]
> 
> Looks like it slipped in by mistake. I expected it to be reverted and
> re-worded.

I don't think it's worth reverting at this point.  For `make sysent` I would
suggest 'sysent: Regen' as a commit log in the future.  We typically use
'src.conf.5: Regen' after running `make makeman`.

-- 
John Baldwin