Re: git: 408957613bc0 - main - Regen

Hello,

Not really as a mistake :) The files in question have many such commits
(not only committed by me). So I have assumed this is a common practice.
I'm happy to provide more details next time. However, I don't plan to
revert it at this point as it seems pointless to complicate the log even
more.

For freebsd32:
e90259af59a1 regen
38bfddf597b1 regen
7893419d492c Remove never implemented sbrk and sstk syscalls
30cdbb5833f6 freebsd32: Remove mac_syscall from the unimpl list
af93fea71038 timerfd: Move implementation from linux compat to sys/kern
c7df87209634 Regen
9121945d7003 Regenerate sysent stuff after $FreeBSD$ removal
7b42f338d7a3 freebsd32: Regen
11cdffc60325 Regen
6a0a634590e4 Regen
f99cc5a38947 sysent: regen after 52a1d90c8bfe, posix_fadvise in capmode
8601fca7895c sysent: regen for syscallarg_t
0910a41ef3b9 Revert "syscallarg_t: Add a type for system call arguments"
3889fb8af0b6 sysent: regen for syscallarg_t
b7c55487ff2f Regen
5c1835b1d4b5 syscalls: regen
7fb006e7d61e syscalls: regen
c2996f8ad930 syscalls: regen
30bc335a0501 freebsd32: regen
97fdcfcaf799 freebsd32: remove unnecessicary headers
bcd07aaa4ebd freebsd32: regen
8460d3e9e6cb freebsd32: regen

And for freebsd
408957613bc0 (HEAD -> main, origin/main, origin/HEAD) Regen
663838451ec6 syscalls: regen
38bfddf597b1 regen
7893419d492c Remove never implemented sbrk and sstk syscalls
af93fea71038 timerfd: Move implementation from linux compat to sys/kern
c7df87209634 Regen
9121945d7003 Regenerate sysent stuff after $FreeBSD$ removal
9abba78acc2a syscalls: regenerate
11cdffc60325 Regen
6a0a634590e4 Regen
f99cc5a38947 sysent: regen after 52a1d90c8bfe, posix_fadvise in capmode
8601fca7895c sysent: regen for syscallarg_t
0910a41ef3b9 Revert "syscallarg_t: Add a type for system call arguments"
3889fb8af0b6 sysent: regen for syscallarg_t
b7c55487ff2f Regen
5c1835b1d4b5 syscalls: regen
7fb006e7d61e syscalls: regen
c2996f8ad930 syscalls: regen
e58e9a8cbd7c syscalls: regen
439c3d95638a Regen
da9fe3529b3d Regen after 0dc332bff200
273728b1257f Regen
2c9764f36b6f regen syscall files after d51198d63b63
d89c1c461ce3 Reserve gaps in syscall numbers for local use
65a524b499ae Remove documentation of unimplemented syscalls
20321e622515 Regenerate syscall files after reallocation of
aio_writev/aio_readv
1868a91fac5e Regenerate syscall files after addition of aio_writev/aio_readv
9dd48b87e6ca Regen.
0c5bd5f99320 Regen after r366145.

Thanks,
Mariusz

On Wed, 22 May 2024 at 12:37, Dmitry Salychev <dsl@freebsd.org> wrote:

>
> Lexi Winter <lexi@le-fay.org> writes:
>
> > [[PGP Signed Part:Undecided]]
> > Mariusz Zaborski:
> >> The branch main has been updated by oshogbo:
> >>
> >> URL:
> https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c4444812c3ae276ace03697ebd
> >>
> >> commit 408957613bc065c4444812c3ae276ace03697ebd
> >> Author:     Mariusz Zaborski <oshogbo@FreeBSD.org>
> >> AuthorDate: 2024-05-21 20:02:50 +0000
> >> Commit:     Mariusz Zaborski <oshogbo@FreeBSD.org>
> >> CommitDate: 2024-05-21 20:03:20 +0000
> >>
> >>     Regen
> >> ---
> >>  sys/compat/freebsd32/freebsd32_sysent.c | 2 +-
> >>  sys/kern/init_sysent.c                  | 2 +-
> >>  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > i'm sorry if this is considered accepted practice in FreeBSD (i'm not a
> > committer) but could i please request more useful commit messages than
> > "Regen" for things like this?
> >
> > when looking through 'git log', especially 'git log --format=oneline',
> > it's really not clear what this commit actually does, meaning if i'm
> > looking through the log for commits related to a problem i'm having, i
> > have to examine commits like this by hand to see if they're related.
> >
> > it would save me (and other people, i suppose) a lot of time if the
> > commit message could at least mention what it's touching, e.g. "Regen
> > sys/compat/freebsd32/freebsd32_sysent.c".
> >
> > [[End of PGP Signed Part]]
>
> Looks like it slipped in by mistake. I expected it to be reverted and
> re-worded.
>
> Regards,
> Dmitry
>
> --
> https://wiki.freebsd.org/DmitrySalychev
>