Re: git: fce03f85c5bf - main - TCP can be subject to Sack Attacks lets fix this issue.

Am 2024-05-06 13:11, schrieb Gary Jennejohn:
> On Mon, 06 May 2024 09:27:31 +0200
> Alexander Leidinger <Alexander@Leidinger.net> wrote:
> 
>> Am 2024-05-05 15:10, schrieb Randall Stewart:

>> > diff --git a/sys/netinet/tcp_stacks/sack_filter.c
>> > b/sys/netinet/tcp_stacks/sack_filter.c
>> > index e82fcee2ffac..fc9ee8454a1e 100644
>> > --- a/sys/netinet/tcp_stacks/sack_filter.c
>> > +++ b/sys/netinet/tcp_stacks/sack_filter.c
>> 
>> >  #ifndef _KERNEL
>> > +
>> > +static u_int tcp_fixed_maxseg(const struct tcpcb *tp)
>> > +{
>> > +	/* Lets pretend their are timestamps on for user space */
>> > +	return (tp->t_maxseg - 12);
>> > +}
>> 
>> Typo in the comment?
>> 
> 
> Yes.  Should be Let's as a contraction of Let us.

As a non-native english speaker I also would change "their" in this 
place and reword "timestamps on for user space".

Bye,
Alexander.

-- 
http://www.Leidinger.net Alexander@Leidinger.net: PGP 0x8F31830F9F2772BF
http://www.FreeBSD.org    netchild@FreeBSD.org  : PGP 0x8F31830F9F2772BF