Re: git: cb808de400c7 - main - rc.conf.5: modernise network_interfaces
- In reply to: Lexi Winter : "Re: git: cb808de400c7 - main - rc.conf.5: modernise network_interfaces"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 04 May 2024 21:38:39 UTC
On Sat, May 4, 2024 at 1:40 PM Lexi Winter <lexi@le-fay.org> wrote: > Kelly Hays: > > On Sat, May 4, 2024 at 11:45 AM Warner Losh <imp@freebsd.org> wrote: > > > @@ -2045,9 +2062,9 @@ interfaces with: > > > .Bd -literal > > > gif_interfaces="gif0 gif1" > > > gifconfig_gif0="100.64.0.1 100.64.0.2" > > > -ifconfig_gif0="inet 10.0.0.1 10.0.0.2 netmask 255.255.255.252" > > > +ifconfig_gif0="inet 10.0.0.1/32 10.0.0.2" > > > gifconfig_gif1="inet6 2a00::1 2a01::1" > > > -ifconfig_gif1="inet 10.1.0.1 10.1.0.2 netmask 255.255.255.252" > > > +ifconfig_gif1="inet 10.1.0.1/32 10.1.0.2" > > > > In the last example above the CIDR notation for the netmask of > > 255.255.255.252 would be /30 not /32. > > yes, this is wrong. imp: can you fix this or do you want a new PR? > I'll just commit a fix and give Kelly credit. Warner