git: a8edc9f1e316 - main - tests/netgraph: start ng_ksocket(4) tests

The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/src/commit/?id=a8edc9f1e316e4893b0b6aac282c542102cf3b99

commit a8edc9f1e316e4893b0b6aac282c542102cf3b99
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2024-03-23 05:44:16 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2024-03-23 05:44:16 +0000

    tests/netgraph: start ng_ksocket(4) tests
    
    The ng_ksocket(4) functionality is very fragile as it interfaces with
    kernel socket code in unusual way.  It definitely needs a test suite.
    Start one with a test that tests UDP over IPv4.
---
 tests/sys/netgraph/Makefile  |   1 +
 tests/sys/netgraph/ksocket.c | 115 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 116 insertions(+)

diff --git a/tests/sys/netgraph/Makefile b/tests/sys/netgraph/Makefile
index 36f9943a7312..2240570ff46a 100644
--- a/tests/sys/netgraph/Makefile
+++ b/tests/sys/netgraph/Makefile
@@ -14,6 +14,7 @@ TEST_METADATA.ng_macfilter_test+=	required_programs="perl"
 ATF_TESTS_C+=	basic		\
 		bridge		\
 		hub		\
+		ksocket		\
 		socket		\
 		vlan_rotate	\
 
diff --git a/tests/sys/netgraph/ksocket.c b/tests/sys/netgraph/ksocket.c
new file mode 100644
index 000000000000..e97b9b3f0691
--- /dev/null
+++ b/tests/sys/netgraph/ksocket.c
@@ -0,0 +1,115 @@
+/*-
+ * SPDX-License-Identifier: BSD-2-Clause
+ *
+ * Copyright (c) 2024 Gleb Smirnoff <glebius@FreeBSD.org>
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
+ * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
+ * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+ * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
+ * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
+ * SUCH DAMAGE.
+ */
+
+#include <sys/socket.h>
+#include <netinet/in.h>
+#include <netgraph.h>
+#include <netgraph/ng_socket.h>
+#include <netgraph/ng_ksocket.h>
+
+#include <errno.h>
+
+#include <atf-c.h>
+
+static void
+hellocheck(int wr, int rd)
+{
+	char sbuf[] = "Hello, peer!", rbuf[sizeof(sbuf)];
+
+	ATF_REQUIRE(send(wr, sbuf, sizeof(sbuf), 0) == sizeof(sbuf));
+	ATF_REQUIRE(recv(rd, rbuf, sizeof(rbuf), 0) == sizeof(sbuf));
+	ATF_REQUIRE(strcmp(sbuf, rbuf) == 0);
+}
+
+#define	OURHOOK	"ks"
+
+ATF_TC_WITHOUT_HEAD(udp_connect);
+ATF_TC_BODY(udp_connect, tc)
+{
+	struct sockaddr sa = {
+		.sa_family = AF_INET,
+	};
+	socklen_t slen = sizeof(sa);
+	int ds, cs, us;
+
+	ATF_REQUIRE((us = socket(PF_INET, SOCK_DGRAM, 0)) > 0);
+	ATF_REQUIRE(bind(us, &sa, sizeof(sa)) == 0);
+	ATF_REQUIRE(getsockname(us, &sa, &slen) == 0);
+
+	struct ngm_mkpeer mkp = {
+		.type = NG_KSOCKET_NODE_TYPE,
+		.ourhook = OURHOOK,
+		.peerhook = "inet/dgram/udp",
+	};
+	ATF_REQUIRE(NgMkSockNode(NULL, &cs, &ds) == 0);
+	ATF_REQUIRE(NgSendMsg(cs, ".", NGM_GENERIC_COOKIE, NGM_MKPEER, &mkp,
+	    sizeof(mkp)) >= 0);
+	ATF_REQUIRE(NgSendMsg(cs, ".:" OURHOOK, NGM_KSOCKET_COOKIE,
+	    NGM_KSOCKET_CONNECT, &sa, sizeof(sa)) >= 0);
+
+	hellocheck(ds, us);
+}
+
+ATF_TC_WITHOUT_HEAD(udp_bind);
+ATF_TC_BODY(udp_bind, tc)
+{
+	struct sockaddr_in sin = {
+		.sin_family = AF_INET,
+		.sin_len = sizeof(sin),
+	};
+	struct ng_mesg *rep;
+	int ds, cs, us;
+
+	struct ngm_mkpeer mkp = {
+		.type = NG_KSOCKET_NODE_TYPE,
+		.ourhook = OURHOOK,
+		.peerhook = "inet/dgram/udp",
+	};
+	ATF_REQUIRE(NgMkSockNode(NULL, &cs, &ds) == 0);
+	ATF_REQUIRE(NgSendMsg(cs, ".", NGM_GENERIC_COOKIE, NGM_MKPEER, &mkp,
+	    sizeof(mkp)) >= 0);
+	ATF_REQUIRE(NgSendMsg(cs, ".:" OURHOOK, NGM_KSOCKET_COOKIE,
+	    NGM_KSOCKET_BIND, &sin, sizeof(sin)) >= 0);
+	ATF_REQUIRE(NgSendMsg(cs, ".:" OURHOOK, NGM_KSOCKET_COOKIE,
+	    NGM_KSOCKET_GETNAME, NULL, 0) >= 0);
+	ATF_REQUIRE(NgAllocRecvMsg(cs, &rep, NULL) == sizeof(struct ng_mesg) +
+	    sizeof(struct sockaddr_in));
+
+	ATF_REQUIRE((us = socket(PF_INET, SOCK_DGRAM, 0)) > 0);
+	ATF_REQUIRE(connect(us, (struct sockaddr *)rep->data,
+	    sizeof(struct sockaddr_in)) == 0);
+
+	hellocheck(us, ds);
+}
+
+ATF_TP_ADD_TCS(tp)
+{
+	ATF_TP_ADD_TC(tp, udp_connect);
+	ATF_TP_ADD_TC(tp, udp_bind);
+
+	return (atf_no_error());
+}