From nobody Fri Mar 22 16:52:43 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V1T0F6HHzz5FL8T; Fri, 22 Mar 2024 16:52:45 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V1T0F5pqLz4f1p; Fri, 22 Mar 2024 16:52:45 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711126365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fE1ZzRDgRBVoUuVbVMNoco9aa83fW1alLsSXvauNNoo=; b=sg8rCrl/f2nioZ+FCD/N2He/mA5eG6qg8RHUFdp0dC6a8k3Vv59ZFtam/R+0dvbjRV4u9/ k3Vp0Pr5JC/JiNtXc4qdaVz0EJPTAdXQ5ch1SDnAkfQYWyAtqkSEuN4QpJJ5J1Avuc4NX8 WeMyhErY/gFoJHzqrx2mk4XsnJI38w53SmsaD1SzY+PcpEJWCWOyacC6pGdPzYF7hdOY+V srqTr6jSJBWLAle+O1wepNfWlA9y99MLaFN0kczVyXVqZt1OEKh0dg9xSrIbBQp0r67B/s z9yEyjpNYURMoaKRfxQDTeDcHeOLPDRpLGLyjN4rNmV9xzVkjWtjDTYGQ3WPjQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711126365; a=rsa-sha256; cv=none; b=j8KboHaNEGVP24BsM9x0gCr5NAXXJieYhN6CklUuNM/Edqf+ZSMkL5LDU1E51jzku9kzen q1+x+yFu/364Dumgx88R9v7VWRyZhk8ytXL9AYUMg2RkDeMpSj5Ty5Cv+HhoEU9O3QWrAi 4dZYpR0eXLvDMMDksA9LktGV6q7XlkJickpyyTn3l7ePFdQk0Bq1D4KWughioU2hih2fDx l3uuggBjXfXY8HFLcv6saKoV1ezw+DpxoW6dm75CzO6tiKUK7dF6ZfKxFAhxMX14aZHHrQ YHwg0YgMSHZPd5KeGobN5JOHA62awbYS4Hs8CRTcI2XVyX6LjQ7+LE7gc3mZhg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711126365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fE1ZzRDgRBVoUuVbVMNoco9aa83fW1alLsSXvauNNoo=; b=I12afx+cXBALaXT4+MsDFQ18KsdVzWJgIsBTKcC+DNOLoIdaDDWVJ8XLkLWbMcYbUbGDJf TswNkf0bjd4+qnb8eFsgZIg+Yhepx7HQ5Q6eAwDC93kHVu/lbUO0dNQOTKBHQrIu0AFaUb v3hDYdzKzZXcOg8mcT0iJKMa9bo8tFH9GSrcrUi6PVWwwD8+6LV0vIMGL6nQkT14S3BwtF oFV4K1XmFwIhDc7+419QKnjgvztExQc0XHQ7deTigeeavdBgniHoqCaEeJx8adjfT4bc8B fk4JHkM6bYhRd7D/kfkV5/7rt+mzH1RO9THB5UlSjl+Q8MO+0/Htw10JQAxPeA== Received: from aniel.nours.eu (nours.eu [176.31.115.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V1T0F4sBcz1YfJ; Fri, 22 Mar 2024 16:52:45 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id C3C36221D4; Fri, 22 Mar 2024 17:52:43 +0100 (CET) Date: Fri, 22 Mar 2024 17:52:43 +0100 From: Baptiste Daroussin To: Mitchell Horne Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: dc7ae2bc6fad - main - kern_ctf.c: fix linking with nooptions DDB Message-ID: References: <202403221630.42MGUEPq099456@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202403221630.42MGUEPq099456@gitrepo.freebsd.org> On Fri 22 Mar 16:30, Mitchell Horne wrote: > The branch main has been updated by mhorne: > > URL: https://cgit.FreeBSD.org/src/commit/?id=dc7ae2bc6fadd67cef0e1c65d79aa82818ac9793 > > commit dc7ae2bc6fadd67cef0e1c65d79aa82818ac9793 > Author: Mitchell Horne > AuthorDate: 2024-03-22 16:26:00 +0000 > Commit: Mitchell Horne > CommitDate: 2024-03-22 16:26:00 +0000 > > kern_ctf.c: fix linking with nooptions DDB > > !DDB builds don't include the db_ctf_lookup_typename() symbol, so this > is a stop-gap to fix linking of the MINIMAL kernel config. > > Reported by: bapt > Fixes: c21bc6f3c242 ("ddb: Add CTF-based pretty printing") > --- > sys/kern/kern_ctf.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sys/kern/kern_ctf.c b/sys/kern/kern_ctf.c > index 8a2106a15308..b525c274f9e0 100644 > --- a/sys/kern/kern_ctf.c > +++ b/sys/kern/kern_ctf.c > @@ -326,5 +326,9 @@ link_elf_ctf_lookup_typename(linker_file_t lf, linker_ctf_t *lc, > if (link_elf_ctf_get_ddb(lf, lc)) > return (ENOENT); > > +#ifdef DDB > return (db_ctf_lookup_typename(lc, typename) ? 0 : ENOENT); > +#else > + return (ENOENT); > +#endif > } I can confirm that pkgbase builders are now happy thanks a lot! Bapt