From nobody Thu Mar 21 20:21:53 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V0xhC5ZCBz5FR17; Thu, 21 Mar 2024 20:22:03 +0000 (UTC) (envelope-from chmeee@has.gonegalt.net) Received: from mail.gonegalt.net (mail.gonegalt.net [208.167.253.104]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4V0xhC2s0Lz4SS0; Thu, 21 Mar 2024 20:22:03 +0000 (UTC) (envelope-from chmeee@has.gonegalt.net) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gonegalt.net; s=dkim; t=1711052514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Jz7Pv9f7WyTvAZ4DMTkaPjMZL5fXDlQM6Sacp2am9Q=; b=SmMz33FFkvqoqqjCcOBzpHoXOb0NP6t5MhZxAEEBvLaoUXUDafwRnUdO+Dqxc04himehDB 81mQrtwMTPZVSMRYNsO/qKkCJlYeB6nZD7Xkj7U3oPwybkFpZKxzdQQPDZlXhNw3nA61Eb TeTdWPQQHG9kgL1kfOWwgzvmGsLhBr0= Received: by localhost (OpenSMTPD) with ESMTP id 1e0b1754; Thu, 21 Mar 2024 16:21:54 -0400 (EDT) Received: from ralga.knownspace ([192.168.1.17]) by mail.gonegalt.net with ESMTPSA id E3prBuKW/GVtBAEA0J78UA (envelope-from ); Thu, 21 Mar 2024 16:21:54 -0400 Date: Thu, 21 Mar 2024 16:21:53 -0400 From: Justin Hibbits To: Dimitry Andric Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: f0620ceeccf0 - main - Fix building of several libclang_rt libraries for powerpc64 and powerp64le Message-ID: <20240321162153.0048ccba@ralga.knownspace> In-Reply-To: <202403211711.42LHBlpr041561@gitrepo.freebsd.org> References: <202403211711.42LHBlpr041561@gitrepo.freebsd.org> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.39; powerpc64le-unknown-linux-gnu) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:20473, ipnet:208.167.224.0/19, country:US] X-Rspamd-Queue-Id: 4V0xhC2s0Lz4SS0 On Thu, 21 Mar 2024 17:11:47 GMT Dimitry Andric wrote: > The branch main has been updated by dim: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=f0620ceeccf070a69352105c5dbc23cff499a732 > > commit f0620ceeccf070a69352105c5dbc23cff499a732 > Author: Dimitry Andric > AuthorDate: 2024-03-21 13:53:36 +0000 > Commit: Dimitry Andric > CommitDate: 2024-03-21 17:05:25 +0000 > > Fix building of several libclang_rt libraries for powerpc64 and > powerp64le > I reorganized the libclang_rt Makefile in e77a1bb27574 to make it > more readable and maintainable, but the check for 32-bit powerpc was > wrong. This caused almost no libclang_rt libraries to be built for > powerpc64 and powerpc64le. > > PR: 262706 > Reported by: tuexen > Fixes: e77a1bb27574 > MFC after: 3 days > --- > lib/libclang_rt/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/libclang_rt/Makefile b/lib/libclang_rt/Makefile > index 46f7fdf814be..984da3f34156 100644 > --- a/lib/libclang_rt/Makefile > +++ b/lib/libclang_rt/Makefile > @@ -67,7 +67,7 @@ SUBDIR+= ${SD_CFI} > SUBDIR+= ${SD_SAFESTACK} > SUBDIR+= ${SD_STATS} > SUBDIR+= ${SD_UBSAN} > -.elif ${MACHINE_CPUARCH} == "powerpc" > +.elif ${MACHINE_ARCH} == "powerpc" If you're excluding 32-bit powerpc you'll want to also exclude powerpcspe. Though, you could just omit both powerpc and powerpcspe from the list here, since there's no default error case. > # nothing for 32-bit powerpc > .elif ${MACHINE_ARCH} == "powerpc64" > SUBDIR+= ${SD_ASAN} - Justin