From nobody Tue Mar 19 06:57:27 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TzMwl6k16z5DhFR; Tue, 19 Mar 2024 06:57:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TzMwl6CFZz4Dk5; Tue, 19 Mar 2024 06:57:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710831447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bqe7eUATJ/GaDqrnO8VAN64YgG318iu0JKBKxTdS0nY=; b=Nl5abUzr2aoZy+JlqLd8nmv7AqzHqhvT7wOWUHMZnCm25cI9ghlL/29YijKHaQUqHVATzx r6pYGQhze8RGJpOBDl/xlj2hqu8l/82yfsrdfX2YyRqL+iOIY88WlbyDxzalR3Ef49X5L5 P6EZMtBayS/5TJBZcJpqOR/qG22j7EsF/QSyJSr9X/+ZCZZkoxhYMXx2TZ2fcEt7JK+9kZ OSQsjGSw+SaCBAmLM6IZ6KZzaBW8MKhnlCWR4VhjHQlRbp1vov1yz+4oAEjE5w73BN7gxD DtuGhYUrNE8/v/m+8l2suv28qQEjHatUGnHpjVTTDBuj1doIwf6EJlOo0gJhQg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1710831447; a=rsa-sha256; cv=none; b=AyKzVv3e1kbmqG7s3/vPu2P1+B1m4jCmiHm/3Fats3ZstwtazNq9eHF1nc19P7dGI6Hg2i 3GldgLiQqb0INdOn7/tzWirsYmpzIk47j4usBZ4qd9b4RtxL17zosoFwAzVOeMeYAP4vCh tCKyo+NA6rmbJw2Y+60+SRtG+fCk2TZaJvhNW9nfRLI28jCBoLloCwkMDxcBG+mSI0G7GD F8nq3h2yuWnaKROIZjbYre2D2zt3atLE8/yrw7o0S2Ij77PuUwLZLDxb9ASkbqm22fQysg nTDLk7MHZE/2TsVkit5mUh78CAIPUvZwPqLXQHKdeuV4bfb1u6Ys0PD9J8sM7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710831447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bqe7eUATJ/GaDqrnO8VAN64YgG318iu0JKBKxTdS0nY=; b=ZP1D0Y2ruyg+plbzHdmU1vtD9xDTESy+xrrW3+PiPCi51D/xmtBY3qWTP5nWKTaL+gGUv4 aY/7bwWCWDXQMa5jXjCSzBZUEeOexddeu38v3F5Cx1FsLGUdnVYxVzJO3Vvjn+waksuk0s 1cjUZmN9yhApbGSSO52s35kO/IDrwDjkPvfChDkCgJSGBcbrlBvMkuXA9gAL6bgHK7I64B 8bqZOzv1eWZVJOUWBxHaroxJdP5eXMxZxs6KfI4TZEjCusY9iCwVqCpIzafK8JADIYHmi/ LgQlkBgatBIoiLNx33IwFh1FbDDbfDTtVEiBj79x/trdF1UlI8Uf6bRPTPoLRg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TzMwl5l2Tzx9S; Tue, 19 Mar 2024 06:57:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 42J6vR7A024313; Tue, 19 Mar 2024 06:57:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 42J6vRXD024310; Tue, 19 Mar 2024 06:57:27 GMT (envelope-from git) Date: Tue, 19 Mar 2024 06:57:27 GMT Message-Id: <202403190657.42J6vRXD024310@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Eugene Grosbein Subject: git: 9fd628361bd8 - stable/13 - diskinfo(8): introduce new option -l List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: eugen X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 9fd628361bd86a6bf59166d433646ea1e7831949 Auto-Submitted: auto-generated The branch stable/13 has been updated by eugen: URL: https://cgit.FreeBSD.org/src/commit/?id=9fd628361bd86a6bf59166d433646ea1e7831949 commit 9fd628361bd86a6bf59166d433646ea1e7831949 Author: Eugene Grosbein AuthorDate: 2024-03-05 17:23:41 +0000 Commit: Eugene Grosbein CommitDate: 2024-03-19 06:56:45 +0000 diskinfo(8): introduce new option -l In modes -p or -s, add an option -l to start each line with a device name separated with a tab. Update the manual page. Add an example to list names with corresponding serial numbers: diskinfo -ls /dev/da? (cherry picked from commit e333110d1de748e50051d1305b5438d1bc54eeb4) --- usr.sbin/diskinfo/diskinfo.8 | 23 ++++++++++++++++++++--- usr.sbin/diskinfo/diskinfo.c | 15 ++++++++++++--- 2 files changed, 32 insertions(+), 6 deletions(-) diff --git a/usr.sbin/diskinfo/diskinfo.8 b/usr.sbin/diskinfo/diskinfo.8 index 72fd1df4eb08..970bafd4f8e5 100644 --- a/usr.sbin/diskinfo/diskinfo.8 +++ b/usr.sbin/diskinfo/diskinfo.8 @@ -27,7 +27,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd July 4, 2017 +.Dd March 5, 2024 .Dt DISKINFO 8 .Os .Sh NAME @@ -38,10 +38,12 @@ .Op Fl citSvw .Ar disk ... .Nm -.Op Fl p +.Op Fl l +.Fl p .Ar disk ... .Nm -.Op Fl s +.Op Fl l +.Fl s .Ar disk ... .Sh DESCRIPTION The @@ -57,6 +59,13 @@ Print fields one per line with a descriptive comment. Perform a simple measurement of the I/O read command overhead. .It Fl i Perform a simple IOPS benchmark. +.It Fl l +In case of +.Fl p +or +.Fl s +modes prepend each line of an output with a device name using a tab +character as a separator. .It Fl p Return the physical path of the disk. This is a string that identifies the physical path to the disk in the @@ -80,6 +89,14 @@ with the following fields: device name, sectorsize, media size in bytes, media size in sectors, stripe size, stripe offset, firmware cylinders, firmware heads, and firmware sectors. The last three fields are only present if the information is available. +.Sh EXAMPLES +List first ten (at most) +.Xr da 4 +devices with corresponding serial numbers: +.Pp +.Dl diskinfo -ls /dev/da? +.Sh SEE ALSO +.Xr da 4 .Sh HISTORY The .Nm diff --git a/usr.sbin/diskinfo/diskinfo.c b/usr.sbin/diskinfo/diskinfo.c index 42227d793e99..0f62817ef1cb 100644 --- a/usr.sbin/diskinfo/diskinfo.c +++ b/usr.sbin/diskinfo/diskinfo.c @@ -58,11 +58,14 @@ static void usage(void) { - fprintf(stderr, "usage: diskinfo [-cipsStvw] disk ...\n"); + fprintf(stderr, "usage: diskinfo [-ciStvw] disk ...\n" + " diskinfo [-l] -p disk ...\n" + " diskinfo [-l] -s disk ...\n" + ); exit (1); } -static int opt_c, opt_i, opt_p, opt_s, opt_S, opt_t, opt_v, opt_w; +static int opt_c, opt_i, opt_l, opt_p, opt_s, opt_S, opt_t, opt_v, opt_w; static bool candelete(int fd); static void speeddisk(int fd, off_t mediasize, u_int sectorsize); @@ -88,7 +91,7 @@ main(int argc, char **argv) u_int sectorsize, fwsectors, fwheads, zoned = 0, isreg; uint32_t zone_mode; - while ((ch = getopt(argc, argv, "cipsStvw")) != -1) { + while ((ch = getopt(argc, argv, "cilpsStvw")) != -1) { switch (ch) { case 'c': opt_c = 1; @@ -98,6 +101,9 @@ main(int argc, char **argv) opt_i = 1; opt_v = 1; break; + case 'l': + opt_l = 1; + break; case 'p': opt_p = 1; break; @@ -169,6 +175,9 @@ main(int argc, char **argv) goto out; } } else { + if (opt_l && (opt_p || opt_s)) { + printf("%s\t", argv[i]); + } if (opt_p) { if (ioctl(fd, DIOCGPHYSPATH, physpath) == 0) { printf("%s\n", physpath);