git: 9e09b33e8efc - stable/14 - icmp6: make icmp6_ratelimit() responsible to update the stats counter

From: Zhenlei Huang <zlei_at_FreeBSD.org>
Date: Wed, 26 Jun 2024 04:50:24 UTC
The branch stable/14 has been updated by zlei:

URL: https://cgit.FreeBSD.org/src/commit/?id=9e09b33e8efc9b4a7f9befb3cf61d17d4a1a35e5

commit 9e09b33e8efc9b4a7f9befb3cf61d17d4a1a35e5
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2024-03-24 16:13:23 +0000
Commit:     Zhenlei Huang <zlei@FreeBSD.org>
CommitDate: 2024-06-26 04:48:43 +0000

    icmp6: make icmp6_ratelimit() responsible to update the stats counter
    
    Reviewed by:            tuexen
    Differential Revision:  https://reviews.freebsd.org/D44479
    
    (cherry picked from commit c6c96aaba8dd74eb39469ed156ff19cc31d599b7)
---
 sys/netinet6/icmp6.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sys/netinet6/icmp6.c b/sys/netinet6/icmp6.c
index b8ac3fc7b094..ba66e18b6524 100644
--- a/sys/netinet6/icmp6.c
+++ b/sys/netinet6/icmp6.c
@@ -343,10 +343,8 @@ icmp6_error(struct mbuf *m, int type, int code, int param)
 	}
 
 	/* Finally, do rate limitation check. */
-	if (icmp6_ratelimit(&oip6->ip6_src, type, code)) {
-		ICMP6STAT_INC(icp6s_toofreq);
+	if (icmp6_ratelimit(&oip6->ip6_src, type, code))
 		goto freeit;
-	}
 
 	/*
 	 * OK, ICMP6 can be generated.
@@ -2746,6 +2744,7 @@ icmp6_ratelimit(const struct in6_addr *dst, const int type,
 	    V_icmp6errppslim)) {
 		/* The packet is subject to rate limit */
 		ret++;
+		ICMP6STAT_INC(icp6s_toofreq);
 	}
 
 	return ret;