From nobody Fri Jun 21 05:45:04 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W55ss0crQz5PWy1; Fri, 21 Jun 2024 05:45:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W55sr70mmz4tLd; Fri, 21 Jun 2024 05:45:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718948705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=REEBGfxB9yD9KkWeB6x2gugVhlMhyCdCbYdoXJBy2wY=; b=K4KC5DV33DDl6H7ILDPWcYnDsEV9yCPPR4M+fh5bDN/geX8rKyVKn9mCsLYm8HKdqvFWm3 7LhDxFxu19NcAF69KSfPmdJo+YazRVtkWOp44DcrHT8ahamA6DDnA4WSkFFWjelo7xosWy /a9CyC5efBf1Fs1oahkDI8WfzSjzo0yiM12ssFiUd6qdAABdDMeq70ojgmvC+NPgq5RizH F+CnuAkj7QfFDkKFAr/HsNaODrVL3eOr6sRvDfcRBA5YWvazAI6ciMLeTxrivQxPPBs+4M 3R7Hnu9eroI51h3xh3Eo8JTaw/AdBzO58iRtqYM4XFZ9RzZj1KphdQgQ+nIsjA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1718948705; a=rsa-sha256; cv=none; b=qrgMM/EGY0R/m10/qRLMbFm6rHuzAlv+j9BXUMPSbRJUCog5iUucH/lPs0JYZI5LE1SuPq snhx0Z7zINldamNt+Zwunqz+6AjETenMSV7oMCGbUDshWAghM+QmASSpzSIaQT4U3SW/ix 03xRIKZAIjd33PyrwCQFr9Aq+G9gbDfThVt1zhH0jk1HRNLjZIwZ/5rl64hAiKzTEZW1SV nvfs2noE+AncNNaJeOP/mdYGbV+kabcUoHQjy+wr6mnQyQ6q9C2CykwFl1Qy2u//f+9GOm My1db7GjEOCRs/Igil3mEpaWWNKVXIF/7367XWYxbp8eenJsPpYRoHoj8z2Hww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718948705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=REEBGfxB9yD9KkWeB6x2gugVhlMhyCdCbYdoXJBy2wY=; b=TFb2mNr77M1DIWip/rkK4/F0tLhjd4MWA9WOKCVT56u5Irff67l7ps6V8jt3je1nqYWakk B35xJoCUnIW5819Ij8rWyYrYMQ1R3h+nRZ29GHAmhiMdAgklIuwS8rA/SRGkPs0ANTlEYp 0oOscpL1649psCDypkONG4Emnw/bkt1OQLBIZHKfG1oOlqsF0Qfz+WfeedzqHG4jSANTbu eQP+gpQiHGiEYt/taGVNxjTiuhBLRtA/WFrM0bd8paug7jsSFYCFDKp1GSybR+rb4qV9UD gB0cW9B5ZPOYmjvZly0f9oF9SKLxIG94gZylh2szjw/z02h2DasjwwwuUnUVEQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4W55sr6YWCzwHl; Fri, 21 Jun 2024 05:45:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 45L5j4hU066923; Fri, 21 Jun 2024 05:45:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 45L5j47N066920; Fri, 21 Jun 2024 05:45:04 GMT (envelope-from git) Date: Fri, 21 Jun 2024 05:45:04 GMT Message-Id: <202406210545.45L5j47N066920@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Xin LI Subject: git: 224e20ceb121 - stable/14 - gve: Make gve_free_qpls idempotent List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: delphij X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 224e20ceb1212579887397b67c43b42d41108c62 Auto-Submitted: auto-generated The branch stable/14 has been updated by delphij: URL: https://cgit.FreeBSD.org/src/commit/?id=224e20ceb1212579887397b67c43b42d41108c62 commit 224e20ceb1212579887397b67c43b42d41108c62 Author: Shailend Chand AuthorDate: 2024-06-05 05:31:46 +0000 Commit: Xin LI CommitDate: 2024-06-21 05:44:34 +0000 gve: Make gve_free_qpls idempotent This fixes a panic caused by double free. PR: kern/279410 Differential Revision: https://reviews.freebsd.org/D45489 (cherry picked from commit b81cbb12410b000074483899e61e9e767ba3ec1d) --- sys/dev/gve/gve_qpl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/gve/gve_qpl.c b/sys/dev/gve/gve_qpl.c index 3c6d9af6feee..9a946a2a2f2d 100644 --- a/sys/dev/gve/gve_qpl.c +++ b/sys/dev/gve/gve_qpl.c @@ -182,6 +182,7 @@ gve_free_qpls(struct gve_priv *priv) for (i = 0; i < num_qpls; i++) gve_free_qpl(priv, i); free(priv->qpls, M_GVE_QPL); + priv->qpls = NULL; } }