Re: git: 801c452795ac - main - man9: Really complete the removal of MD5.9

From: Warner Losh <imp_at_bsdimp.com>
Date: Mon, 29 Jul 2024 17:40:49 UTC
On Mon, Jul 29, 2024 at 10:39 AM Mark Johnston <markj@freebsd.org> wrote:

> On Mon, Jul 29, 2024 at 11:31:19PM +0700, Yuri Pankov wrote:
> > Mark Johnston wrote:
> > > The branch main has been updated by markj:
> > >
> > > URL:
> https://cgit.FreeBSD.org/src/commit/?id=801c452795ac441523655eb3277051b7b034becf
> > >
> > > commit 801c452795ac441523655eb3277051b7b034becf
> > > Author:     Mark Johnston <markj@FreeBSD.org>
> > > AuthorDate: 2024-07-29 14:12:40 +0000
> > > Commit:     Mark Johnston <markj@FreeBSD.org>
> > > CommitDate: 2024-07-29 14:17:04 +0000
> > >
> > >     man9: Really complete the removal of MD5.9
> > >
> > >     Fixes:  46b0db2dbe9f ("Remove unnecessary and now inaccurate
> kernel side manual page.")
> > >     Fixes:  36d68cb2ddd2 ("Complete the removal of the MD5 manual page
> from section 9.")
> > > ---
> > >  ObsoleteFiles.inc       | 2 ++
> > >  share/man/man9/Makefile | 2 --
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc
> > > index b21778466800..01b4824e8692 100644
> > > --- a/ObsoleteFiles.inc
> > > +++ b/ObsoleteFiles.inc
> > > @@ -56,6 +56,8 @@ OLD_FILES+=usr/share/man/man9/ifaddr_byindex.9.gz
> > >
> > >  # 20240729: remove MD5(9)
> > >  OLD_FILES+=usr/share/man/man9/MD5.9.gz
> > > +OLD_FILES+=usr/share/man/man9/MD5Init.9
> > > +OLD_FILES+=usr/share/man/man9/MD5Transform.9
> >
> > This really needs to be smarter, but you have to specify .gz suffix for
> > man entries as we have compression enabled by default.
>
> Sigh, who knew it was so difficult to remove a man page.
>

There is a pull request being worked on that will be smarter about what's
removed since we have compress (UFS) and uncompress (ZFS) setups
now.

Warner


> Thanks, this is fixed now.
>
> > >  # 20240726: deprecate contigfree(9)
> > >  OLD_FILES+=usr/share/man/man9/contigfree.9.gz
> > > diff --git a/share/man/man9/Makefile b/share/man/man9/Makefile
> > > index 593bbd068790..60f994edfd9f 100644
> > > --- a/share/man/man9/Makefile
> > > +++ b/share/man/man9/Makefile
> > > @@ -1544,8 +1544,6 @@ MLINKS+=\
> > >     mbuf_tags.9 m_tag_next.9 \
> > >     mbuf_tags.9 m_tag_prepend.9 \
> > >     mbuf_tags.9 m_tag_unlink.9
> > > -MLINKS+=MD5.9 MD5Init.9 \
> > > -   MD5.9 MD5Transform.9
> > >  MLINKS+=mdchain.9 md_append_record.9 \
> > >     mdchain.9 md_done.9 \
> > >     mdchain.9 md_get_int64.9 \
> > >
> >
>