git: 5af25b6e4d55 - stable/14 - cxgbe(4): Minor tweaks to comments.
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 17 Jul 2024 14:21:46 UTC
The branch stable/14 has been updated by np:
URL: https://cgit.FreeBSD.org/src/commit/?id=5af25b6e4d5514c10028c6bce89d123a6162a2de
commit 5af25b6e4d5514c10028c6bce89d123a6162a2de
Author: Navdeep Parhar <np@FreeBSD.org>
AuthorDate: 2024-04-30 20:01:07 +0000
Commit: Navdeep Parhar <np@FreeBSD.org>
CommitDate: 2024-07-17 06:38:18 +0000
cxgbe(4): Minor tweaks to comments.
No functional change intended.
Sponsored by: Chelsio Communications
(cherry picked from commit 21aba396551e29808fa56a6d4fab17e871c3524f)
---
sys/dev/cxgbe/t4_main.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c
index 4834a4fc2873..04f564124356 100644
--- a/sys/dev/cxgbe/t4_main.c
+++ b/sys/dev/cxgbe/t4_main.c
@@ -5323,9 +5323,13 @@ get_params__post_init(struct adapter *sc)
}
/*
- * MPSBGMAP is queried separately because only recent firmwares support
- * it as a parameter and we don't want the compound query above to fail
- * on older firmwares.
+ * The parameters that follow may not be available on all firmwares. We
+ * query them individually rather than in a compound query because old
+ * firmwares fail the entire query if an unknown parameter is queried.
+ */
+
+ /*
+ * MPS buffer group configuration.
*/
param[0] = FW_PARAM_DEV(MPSBGMAP);
val[0] = 0;
@@ -5337,7 +5341,6 @@ get_params__post_init(struct adapter *sc)
/*
* Determine whether the firmware supports the filter2 work request.
- * This is queried separately for the same reason as MPSBGMAP above.
*/
param[0] = FW_PARAM_DEV(FILTER2_WR);
val[0] = 0;
@@ -5349,7 +5352,6 @@ get_params__post_init(struct adapter *sc)
/*
* Find out whether we're allowed to use the ULPTX MEMWRITE DSGL.
- * This is queried separately for the same reason as other params above.
*/
param[0] = FW_PARAM_DEV(ULPTX_MEMWRITE_DSGL);
val[0] = 0;