git: ca89a51d407a - stable/12 - msun: remove fabs from Symbol.map, and adjust comment
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 30 Jan 2024 17:56:58 UTC
The branch stable/12 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=ca89a51d407a1d6b78d27b8d407f0c12f7c8c9a1 commit ca89a51d407a1d6b78d27b8d407f0c12f7c8c9a1 Author: Dimitry Andric <dim@FreeBSD.org> AuthorDate: 2024-01-27 21:24:38 +0000 Commit: Dimitry Andric <dim@FreeBSD.org> CommitDate: 2024-01-30 17:52:55 +0000 msun: remove fabs from Symbol.map, and adjust comment We have s_fabs.c, but fabs(3) is already provided by libc due to historical reasons, so it is not compiled into libm. When the linker does not use --undefined-version, this leads to a complaint about the symbol being nonexistent, so remove it from Symbol.map. While here, adjust the comment about some functions being supplied by libc: while it is true that all these are indeed in libc, libm still includes its own versions of frexp(3), isnan(3), isnanf(3), and isnanl(3). Reported by: Steve Kargl <sgk@troutmask.apl.washington.edu> MFC after: 3 days (cherry picked from commit d04e03c19a8d7660ea36f62720eef9bc96b69889) --- lib/msun/Makefile | 3 ++- lib/msun/Symbol.map | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/msun/Makefile b/lib/msun/Makefile index 4771de91c561..15c56d10a8e3 100644 --- a/lib/msun/Makefile +++ b/lib/msun/Makefile @@ -143,7 +143,8 @@ COMMON_SRCS+= catrig.c catrigf.c \ s_cproj.c s_cprojf.c s_creal.c s_crealf.c s_creall.c \ s_csinh.c s_csinhf.c s_ctanh.c s_ctanhf.c -# FreeBSD's C library supplies these functions: +# FreeBSD's C library supplies these functions (but note we still have s_frexp.c +# and s_isnan.c enabled above, so they are duplicated): #COMMON_SRCS+= s_fabs.c s_frexp.c s_isnan.c s_ldexp.c s_modf.c # Exclude the generic versions of what we provide in the MD area. diff --git a/lib/msun/Symbol.map b/lib/msun/Symbol.map index 51deded732f0..435fbed5642e 100644 --- a/lib/msun/Symbol.map +++ b/lib/msun/Symbol.map @@ -89,7 +89,6 @@ FBSD_1.0 { exp2f; expm1; expm1f; - fabs; fabsf; fabsl; fdim;