git: dfe30e41967f - main - tcp: remove unused tcp_sack_output_debug() function
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 19 Jan 2024 13:50:23 UTC
The branch main has been updated by rscheff:
URL: https://cgit.FreeBSD.org/src/commit/?id=dfe30e41967f9b5112c42ca20ec2c366db74cef9
commit dfe30e41967f9b5112c42ca20ec2c366db74cef9
Author: Richard Scheffenegger <rscheff@FreeBSD.org>
AuthorDate: 2024-01-19 13:48:11 +0000
Commit: Richard Scheffenegger <rscheff@FreeBSD.org>
CommitDate: 2024-01-19 13:48:32 +0000
tcp: remove unused tcp_sack_output_debug() function
This debugging code has been lingering for years with
no known use.
No functional change.
Reviewed by: tuexen, #transport
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D43511
---
sys/netinet/tcp_sack.c | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/sys/netinet/tcp_sack.c b/sys/netinet/tcp_sack.c
index 48efe855f689..f9ca83850c09 100644
--- a/sys/netinet/tcp_sack.c
+++ b/sys/netinet/tcp_sack.c
@@ -994,32 +994,6 @@ tcp_sack_partialack(struct tcpcb *tp, struct tcphdr *th)
(void) tcp_output(tp);
}
-#if 0
-/*
- * Debug version of tcp_sack_output() that walks the scoreboard. Used for
- * now to sanity check the hint.
- */
-static struct sackhole *
-tcp_sack_output_debug(struct tcpcb *tp, int *sack_bytes_rexmt)
-{
- struct sackhole *p;
-
- INP_WLOCK_ASSERT(tptoinpcb(tp));
- *sack_bytes_rexmt = 0;
- TAILQ_FOREACH(p, &tp->snd_holes, scblink) {
- if (SEQ_LT(p->rxmit, p->end)) {
- if (SEQ_LT(p->rxmit, tp->snd_una)) {/* old SACK hole */
- continue;
- }
- *sack_bytes_rexmt += (p->rxmit - p->start);
- break;
- }
- *sack_bytes_rexmt += (SEQ_MIN(p->rxmit, p->end) - p->start);
- }
- return (p);
-}
-#endif
-
/*
* Returns the next hole to retransmit and the number of retransmitted bytes
* from the scoreboard. We store both the next hole and the number of