Re: git: dcb621efd664 - main - loader: Mark BEARSSL broken on powerpc

On 22 Feb 2024, at 17:08, Warner Losh <imp@FreeBSD.org> wrote:
> 
> The branch main has been updated by imp:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=dcb621efd6645d3f3a227c8c9113cc717e903389
> 
> commit dcb621efd6645d3f3a227c8c9113cc717e903389
> Author:     Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2024-02-22 17:05:40 +0000
> Commit:     Warner Losh <imp@FreeBSD.org>
> CommitDate: 2024-02-22 17:08:12 +0000
> 
>    loader: Mark BEARSSL broken on powerpc
> 
>    When BEARSSL is enabled, we pull in libsecureboot, which has EFI
>    dependencies which don't exist on powerpc. This needs to be detangled,
>    but until then mark it as broken.
> 
>    Sponsored by:           Netflix
> ---
> share/mk/src.opts.mk | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/share/mk/src.opts.mk b/share/mk/src.opts.mk
> index e154fbd4059d..3eec831db2cc 100644
> --- a/share/mk/src.opts.mk
> +++ b/share/mk/src.opts.mk
> @@ -313,6 +313,9 @@ BROKEN_OPTIONS+=LIB32
> .if ${__T:Mpowerpc*} || ${__T} == "i386"
> BROKEN_OPTIONS+=EFI
> .endif
> +# Bad coupling for libsecure stuff with bearssl and efi, so broken on EFI
> +.if ${__T:Mpowerpc*}
> +BROKEN_OPTIONS+=BEARSSL # bearssl brings in secure efi stuff xxx
> # OFW is only for powerpc, exclude others

Missing .endif (maybe you initially had it in the block below?)

Jess

> .if ${__T:Mpowerpc*} == ""
> BROKEN_OPTIONS+=LOADER_OFW