Re: git: 5bda26333a8e - main - gpiobus: Use bus_generic_rman_*

From: Andrew Turner <andrew_at_fubar.geek.nz>
Date: Mon, 19 Feb 2024 10:44:39 UTC 

> On 14 Feb 2024, at 22:52, John Baldwin <jhb@freebsd.org> wrote:
> 
> The branch main has been updated by jhb:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=5bda26333a8ebf34190e3a9124895e6a18e58e93
> 
> commit 5bda26333a8ebf34190e3a9124895e6a18e58e93
> Author:     John Baldwin <jhb@FreeBSD.org>
> AuthorDate: 2024-02-14 22:07:32 +0000
> Commit:     John Baldwin <jhb@FreeBSD.org>
> CommitDate: 2024-02-14 22:07:32 +0000
> 
>    gpiobus: Use bus_generic_rman_*
> 
>    Reviewed by:    imp
>    Differential Revision:  https://reviews.freebsd.org/D43887
> ---
> sys/dev/gpio/gpiobus.c | 57 +++++++++++++++++---------------------------------
> 1 file changed, 19 insertions(+), 38 deletions(-)
> 
> diff --git a/sys/dev/gpio/gpiobus.c b/sys/dev/gpio/gpiobus.c
> index 99d3114d51da..6d739597b759 100644
> --- a/sys/dev/gpio/gpiobus.c
> +++ b/sys/dev/gpio/gpiobus.c
> @@ -809,20 +809,29 @@ gpiobus_write_ivar(device_t dev, device_t child, int which, uintptr_t value)
>         return (0);
> }
> 
> +static struct rman *
> +gpiobus_get_rman(device_t bus, int type, u_int flags)

This is unused now. It looks like it’s missing "DEVMETHOD(bus_get_rman, gpiobus_get_rman)”.

Andrew