From nobody Mon Feb 12 16:14:07 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TYTzq1YQzz5B4w4; Mon, 12 Feb 2024 16:14:15 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4TYTzp20hNz46bL; Mon, 12 Feb 2024 16:14:14 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=freebsd.org (policy=none); spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id BBF873C019A; Mon, 12 Feb 2024 16:14:07 +0000 (UTC) Date: Mon, 12 Feb 2024 16:14:07 +0000 From: Brooks Davis To: Don Lewis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 49d684369c66 - main - libthr: filter rather than link with libsys Message-ID: References: <202402071951.417JpRgf034979@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.59 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_SHORT(-0.99)[-0.991]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : No valid SPF, No valid DKIM,none]; ONCE_RECEIVED(0.10)[]; MIME_GOOD(-0.10)[text/plain]; FREEFALL_USER(0.00)[brooks]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; R_SPF_NA(0.00)[no SPF record]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4] X-Rspamd-Queue-Id: 4TYTzp20hNz46bL On Sat, Feb 10, 2024 at 01:36:19PM -0800, Don Lewis wrote: > On 7 Feb, Brooks Davis wrote: > > The branch main has been updated by brooks: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=49d684369c6682eebca325c55a6c96b7c03f5aeb > > > > commit 49d684369c6682eebca325c55a6c96b7c03f5aeb > > Author: Brooks Davis > > AuthorDate: 2024-02-07 19:38:16 +0000 > > Commit: Brooks Davis > > CommitDate: 2024-02-07 19:50:47 +0000 > > > > libthr: filter rather than link with libsys > > > > The allows gcc + GNU ld to link programs with -m32 -pthread without > > erroring out due to _umtx_op_err being undefined (unless -lsys is added > > to the link command. > > > > We now always link _umtx_op_err into libthr (not just when it's static) > > and filter it with libsys so we call that implementation. The dynamic > > implementations (at least the assembly ones) should likely become stubs > > as a further refinement. > > Thanks! I ran into this problem early this week when lang/gcc12 stopped > bulding and I spent a bunch of time bisecting. Sorry about that. We (mostly antone) did a number of exp-runs, but I made a last minute change to fix (somewhat ironically) buildworld with GCC 12 and that broke the GCC MULTILIB option... I'm not convinced there isn't an underlying bug in GNU ld's -m32 support, but even if there is we need this to work with past versions so I've not put more effort into this. -- Brooks