From nobody Fri Feb 02 23:24:29 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TRX161Jvpz58Vrh for ; Fri, 2 Feb 2024 23:24:42 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TRX156bldz49Mc for ; Fri, 2 Feb 2024 23:24:41 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-40ef3f351d2so21455985e9.1 for ; Fri, 02 Feb 2024 15:24:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706916280; x=1707521080; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JutS0ysruJhgxMH9ohXG0xk6TL2kQ4UYUeqolPXzkpY=; b=vLitj0aTyqGq4wFrfzO4dysIMtHhTonESGteX/v5rstYqFy4cd+FXpuYoRYDe7twsb zP1U79y0/8uoZI7VliyAFozJBli7G6ZrDL+dgwLjbQHp/X7S04pq0vbNyJM9usP1CKXE gJQXpJ9EAvSkEUdRSY4yFKE2zi45SH83w/OqAdV4xjCkLC9p+UAnKJHdbNYu9xrCDCOF 4e7EgMVpXdCi/jqh8fHbPMuOjvVpxLFxScxq9oUulqIdYMLg6XTqsOjh1/HHM7ly3R8m nldn5l6qZ+sXtnIIDh4wLfrni6YjOGsyoZgCPXtK29jZjLZD1GZQEk61/YyXthkVGtQY ngxQ== X-Gm-Message-State: AOJu0Yzb2Ctk/x8T9Bobe52RVf5VQNOWMr4KbgVllKZR69vBJB2iJUUs VS2y4zWrqLkmbIQWYJCIsMT2Kh/STvRqKo9Lr41Mfn6a3U/TDzEvhM1+lizv2sI= X-Google-Smtp-Source: AGHT+IEoxBonMNOjbD4LTrgJAkZ84Lll4rx7Jme9VRTyWicM41+CHflPWNJw7iW5RF+m+Ho+fUfdug== X-Received: by 2002:a05:600c:468c:b0:40e:fb4c:c171 with SMTP id p12-20020a05600c468c00b0040efb4cc171mr46545wmo.11.1706916280208; Fri, 02 Feb 2024 15:24:40 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUGIitibsCjdlT6k+p/KNkqpgpyiWdVUQXOdF1W8xPphDkFtzzbJdU9BrgRVaU7GMapIAUgeKfQVyQFzhDWD6e6aB0QPfvFipVqRGt+Bb97aeuUz9FxqKE4m2yIdljtXAKWZ0vFL2HHDNH9xCSAV+6/f3gFTNShVWdBxM10CxGbsOa2QM1c3VIjL5VXSxo= Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id j17-20020a05600c1c1100b0040fbdd6f69bsm1171618wms.33.2024.02.02.15.24.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Feb 2024 15:24:39 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: git: 834517eff8aa - main - x86 & arm: remove CAM_DEBUG_FLAGS= from MMCCAM kernels From: Jessica Clarke In-Reply-To: Date: Fri, 2 Feb 2024 23:24:29 +0000 Cc: Warner Losh , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <76A2B22D-565F-4CC5-B135-291624DA1E1F@freebsd.org> References: <202402021959.412JxKop038336@gitrepo.freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Rspamd-Queue-Id: 4TRX156bldz49Mc X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On 2 Feb 2024, at 22:45, John Baldwin wrote: > On 2/2/24 11:59 AM, Warner Losh wrote: >> The branch main has been updated by imp: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D834517eff8aaab46760645619b880d97= f23ab61b >> commit 834517eff8aaab46760645619b880d97f23ab61b >> Author: Mina Gali=C4=87 >> AuthorDate: 2024-02-02 19:46:01 +0000 >> Commit: Warner Losh >> CommitDate: 2024-02-02 19:51:51 +0000 >> x86 & arm: remove CAM_DEBUG_FLAGS=3D from MMCCAM kernels >> we leave `options CAMDEBUG` enabled, so that when needed, = CAM debugging >> can be enabled *as needed*, rather than setting a default of = everything. >> Reviewed by: imp >> Pull Request: https://github.com/freebsd/freebsd-src/pull/798 >> --- >=20 > Would it make sense to have a sys/conf/std.MMCCAM and the various = GENERIC-MMCCAM > could just be include GENERIC, ident, include std.MMCCAM? >=20 > (Related, I wonder if we want to have std.DEBUG and std.NODEBUG for = use in > GENERIC and GENERIC-*DEBUG.) We have sys/conf/std.nodebug (not NODEBUG, which slightly bugs me) already. Extending the set of things would be sensible. I=E2=80=99d also = like to see a std.GENERIC that includes all the MI things you expect in a GENERIC kernel, and I guess a std.MINIMAL that=E2=80=99s the core subset = of that. Jess