git: 14b7cf92e73a - stable/14 - open(2): describe *at behavior for dirfd opened without O_SEARCH

From: Konstantin Belousov <kib_at_FreeBSD.org>
Date: Thu, 01 Feb 2024 00:31:02 UTC
The branch stable/14 has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=14b7cf92e73ab46f6b0eb22fc40a3f4c872c3598

commit 14b7cf92e73ab46f6b0eb22fc40a3f4c872c3598
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2024-01-29 17:54:32 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2024-02-01 00:30:40 +0000

    open(2): describe *at behavior for dirfd opened without O_SEARCH
    
    (cherry picked from commit a570fe4d0dd979ce099374259ffc45d56ae4e471)
---
 lib/libc/sys/open.2 | 38 ++++++++++++++++++++++++--------------
 1 file changed, 24 insertions(+), 14 deletions(-)

diff --git a/lib/libc/sys/open.2 b/lib/libc/sys/open.2
index ff0441d64507..67a059db10da 100644
--- a/lib/libc/sys/open.2
+++ b/lib/libc/sys/open.2
@@ -25,9 +25,7 @@
 .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 .\" SUCH DAMAGE.
 .\"
-.\"     @(#)open.2	8.2 (Berkeley) 11/16/93
-.\"
-.Dd May 29, 2023
+.Dd January 29, 2024
 .Dt OPEN 2
 .Os
 .Sh NAME
@@ -316,6 +314,12 @@ may not be used for any read operations like
 The primary use for this descriptor will be as the lookup descriptor for the
 .Fn *at
 family of functions.
+If
+.Dv O_SEARCH
+was not requested at open time, then the
+.Fn *at
+functions use the current directory permissions for the directory referenced
+by the descriptor at the time of the call.
 .Pp
 .Dv O_PATH
 returns a file descriptor that can be used as a directory file descriptor for
@@ -658,6 +662,23 @@ when
 is set in flags and the final component of pathname is a symbolic link
 to distinguish it from the case of too many symbolic link traversals
 in one of its non-final components.
+.Pp
+The Open Group Extended API Set 2 specification, that introduced the
+.Fn *at
+API, required that the test for whether
+.Fa fd
+is searchable is based on whether
+.Fa fd
+is open for searching, not whether the underlying directory currently
+permits searches.
+The present implementation of the
+.Fa openat
+system call is believed to be compatible with
+.St -p1003.1-2017 ,
+which specifies that behavior for
+.Dv O_SEARCH ,
+in the absence of the flag the implementation checks the current
+permissions of a directory.
 .Sh HISTORY
 The
 .Fn open
@@ -670,17 +691,6 @@ function was introduced in
 .Dv O_DSYNC
 appeared in 13.0.
 .Sh BUGS
-The Open Group Extended API Set 2 specification requires that the test
-for whether
-.Fa fd
-is searchable is based on whether
-.Fa fd
-is open for searching, not whether the underlying directory currently
-permits searches.
-The present implementation of the
-.Fa openat
-checks the current permissions of directory instead.
-.Pp
 The
 .Fa mode
 argument is variadic and may result in different calling conventions