Re: git: d2be7ed63aff - main - cred: proc_set_cred(), proc_unset_cred(): Update user's process count
- Reply: Cy Schubert : "Re: git: d2be7ed63aff - main - cred: proc_set_cred(), proc_unset_cred(): Update user's process count"
- In reply to: Cy Schubert : "Re: git: d2be7ed63aff - main - cred: proc_set_cred(), proc_unset_cred(): Update user's process count"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 16 Dec 2024 15:44:37 UTC
> I was just about to push this:
Ah, didn't see your mail. Just pushed a fix.
> proc_set_cred(struct proc *p, struct ucred *newcred)
> {
> - bool success = _proc_set_cred(p, newcred, false);
> +#ifdef INVARIANTS
> + bool success =
> +#endif
> + _proc_set_cred(p, newcred, false);
>
> MPASS(success);
Apparently, the idiom for such a situation is to tag the variable with `__diagused`, but the change above would have worked the same in the end.
Thanks for watching the build!
(And I now have one more thing on my before-commit list, since I forgot GENERIC-NODEBUG).
--
Olivier Certner