git: 0b011b5cddb5 - main - mountd(8): parsecred(): Remove comment on non-existent bug
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 16 Dec 2024 14:45:29 UTC
The branch main has been updated by olce:
URL: https://cgit.FreeBSD.org/src/commit/?id=0b011b5cddb5b17cf5b8f50ff580f3eb4abaeeef
commit 0b011b5cddb5b17cf5b8f50ff580f3eb4abaeeef
Author: Olivier Certner <olce@FreeBSD.org>
AuthorDate: 2024-10-08 09:44:06 +0000
Commit: Olivier Certner <olce@FreeBSD.org>
CommitDate: 2024-12-16 14:42:31 +0000
mountd(8): parsecred(): Remove comment on non-existent bug
'name' can never be NULL, as it is equal to 'names' and 'namelist',
which was passed by do_cred() only if the actual parameter wasn't NULL.
Reviewed by: rmacklem
Approved by: markj (mentor)
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D47014
---
usr.sbin/mountd/mountd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/usr.sbin/mountd/mountd.c b/usr.sbin/mountd/mountd.c
index 76a5fc6fae93..653d7135ef79 100644
--- a/usr.sbin/mountd/mountd.c
+++ b/usr.sbin/mountd/mountd.c
@@ -3632,7 +3632,6 @@ parsecred(char *namelist, struct expcred *cr)
*/
names = namelist;
name = strsep_quote(&names, ":");
- /* Bug? name could be NULL here */
name_ul = strtoul(name, &end, 10);
if (*end != '\0' || end == name)
pw = getpwnam(name);