Re: 101afbc6ee2f - main - loader/menu: tweak for added line

> 80x24 used to be very relevant for Serial, first as the typical terminal in the 70s and 80s, then in the default for xterm in the 90s and 2000s. But in 2024, I'm not sure there's many people still confining themselves to that, but maybe I'm ignorant of why my breaking it might be relevant.

There's still lots of gear out there which uses RS-232 serial over DB9, which uses 80x24.

-Ravi (rpokala@)


From: <owner-src-committers@freebsd.org> on behalf of Warner Losh <imp@bsdimp.com>
Date: Thursday, August 22, 2024 at 19:03
To: Jessica Clarke <jrtc27@freebsd.org>
Cc: Warner Losh <imp@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>
Subject: Re: git: 101afbc6ee2f - main - loader/menu: tweak for added line



On Thu, Aug 22, 2024 at 5:52 PM Jessica Clarke <mailto:jrtc27@freebsd.org> wrote:
On 23 Aug 2024, at 00:37, Warner Losh <imp@FreeBSD.org> wrote:
> 
> The branch main has been updated by imp:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=101afbc6ee2f06f77e6886f1f3ffe115c579967c
> 
> commit 101afbc6ee2f06f77e6886f1f3ffe115c579967c
> Author:     Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2024-08-22 23:28:51 +0000
> Commit:     Warner Losh <imp@FreeBSD.org>
> CommitDate: 2024-08-22 23:28:51 +0000
> 
>    loader/menu: tweak for added line
> 
>    I added a line to the menu, but didn't adjust so things were a
>    line off. Make the necessary adjustments.
> 
>    Fixes: 7cb65be96d47
>    Sponsored by: Netflix
>    MFC After: 3 days
> ---
> stand/lua/drawer.lua | 2 +-
> stand/lua/menu.lua   | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/stand/lua/drawer.lua b/stand/lua/drawer.lua
> index a009b78164df..3a462930b86b 100644
> --- a/stand/lua/drawer.lua
> +++ b/stand/lua/drawer.lua
> @@ -472,7 +472,7 @@ logodefs = {
> brand_position = {x = 2, y = 1}
> logo_position = {x = 46, y = 4}
> menu_position = {x = 5, y = 10}
> -frame_size = {w = 42, h = 13}
> +frame_size = {w = 42, h = 14}
> default_shift = {x = 0, y = 0}
> shift = default_shift
> 
> diff --git a/stand/lua/menu.lua b/stand/lua/menu.lua
> index 0587e5ae6586..ed84360d93b0 100644
> --- a/stand/lua/menu.lua
> +++ b/stand/lua/menu.lua
> @@ -535,7 +535,7 @@ end
> 
> function menu.autoboot(delay)
> local x = loader.getenv("loader_menu_timeout_x") or 4
> - local y = loader.getenv("loader_menu_timeout_y") or 23
> + local y = loader.getenv("loader_menu_timeout_y") or 24
> local endtime = loader.time() + delay
> local time
> local last

Does this mean we no longer fit a standard 80x24 terminal, or does this
place it on the 24th row so just fits?

I've not tested that configuration, so I don't know. It's my guess it will be fine.

I wonder if this configuration is relevant, though. 80x25 is the smallest text
console in common use in FreeBSD these days. 80x24 used to be very relevant
for Serial, first as the typical terminal in the 70s and 80s, then in the default
for xterm in the 90s and 2000s. But in 2024, I'm not sure there's many people
still confining themselves to that, but maybe I'm ignorant of why my breaking
it might be relevant.

I'll test it this weekend...

Warner