From nobody Mon Aug 19 13:22:01 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WnYCv6Vzzz5T22J; Mon, 19 Aug 2024 13:22:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WnYCv644Yz4kRD; Mon, 19 Aug 2024 13:22:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724073723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z5yLuGP5gE+JRUvmuOWS57SsgXYvxcH4sliI6qGg96Q=; b=BabFyz6dvB2KPCkNhxX6oX3PFyjDGT0gZtRhjHzjm/rB1HlPI4O8wEuM8kwOik4ItXH8Un RtDbnx3posFGmjdJCjpnemnI8MoqXXV30SIkbKSASPNjmhc1jiPr454AmgxH5bcn/3RaC1 T0qN1Y+c9Jfmv5CUdaFTQ3xaEsVhYQpos4z5+yunHhg67XrqMSNGu8e0r//BjZ9oXp9l3F hN78nStxJfBq30RM4Jq8m/eGsXwnkpKSbWKF+LEqBUNSq67Dk0VsvLVWCgJum73s3It05l 4OhcBRXSEuQfdfdhivtnOkfRYxSL/YamPPINovvrbMLVmzQaIOiU8S0Be0vr/g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724073723; a=rsa-sha256; cv=none; b=mQZCuKHVdrRJP+YSCsnt+PHj30gyuEw8wB81WAAHH2E8+R+UAYi7nkeyGqboZ6MYdtT03H BisV2bwzRDGvS5NA5jvbEbUbcLv9Cv7RDpxKc42zk94m8OK7CF5c5iLsDKqi6M+OVSa4ua e3KrrwZpaHvDj+ThCkuY9SI+Q0nQXC20R9CKoVYUQQbtemAySHQr9dyjHhvJNZQfInTU3a eiEXd5Rye+HFZA0XvIQqgydlwLaRHIkUSwWHq88yzT7sosxUT5lznPeB3BkuhnABRQbfSM Rl2GRROGpfDeJmXdyI8vqCBDMnWwlYr+wxFsNv5EENDK/3zgeTLQJYo1EY0Txg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724073723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z5yLuGP5gE+JRUvmuOWS57SsgXYvxcH4sliI6qGg96Q=; b=k1kF25+dn5kG+EZy+uvYKupoP4cbAVGjfm+6rDIH14gakRma7XI2yZT35v8B/VCoQBCrJg gapsTwTL6zXF+ITRmgJRydHaetcoNuBy2Uo3/pvBpR6hUCFkOHMkZVSIN8O6Ev8qikH3m9 C7jmuzDYKr2TcB7cqToS3zEYWSVFHMPycQUEp2p/IaDj4gXbvGSO+nKZ7KLKxRH1Ta4fIb bQdlBjFJB1k/oo1x4lYxAg0yzJM8m3dO2J+38AOAC8mC/rwQ9zeARGopBxN20el3l8b5ur hhgFdXMjGlOoeqj679in8D7dBUpxca0kcvUXv71iUIlEXE8kBCoaKMfZlPmHPQ== Received: from [IPV6:2601:5c0:4200:b830:49b5:d921:1c85:942f] (unknown [IPv6:2601:5c0:4200:b830:49b5:d921:1c85:942f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WnYCv4MwxzWrY; Mon, 19 Aug 2024 13:22:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <91c2e929-b663-45ac-8c7e-40f9cb219a41@FreeBSD.org> Date: Mon, 19 Aug 2024 06:22:01 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: f44ff2aba2d6 - main - bhyve: Treat the COMMAND register for PCI passthru devices as emulated Content-Language: en-US To: Navdeep Parhar , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202407311450.46VEoql9014730@gitrepo.freebsd.org> <58a179b1-9e92-461a-8902-31bd0a8c057e@FreeBSD.org> From: John Baldwin In-Reply-To: <58a179b1-9e92-461a-8902-31bd0a8c057e@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/13/24 21:17, Navdeep Parhar wrote: > On 7/31/24 7:50 AM, John Baldwin wrote: >> The branch main has been updated by jhb: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=f44ff2aba2d64d1d9312cb55008dc90275ccdc04 >> >> commit f44ff2aba2d64d1d9312cb55008dc90275ccdc04 >> Author: John Baldwin >> AuthorDate: 2024-07-31 14:50:33 +0000 >> Commit: John Baldwin >> CommitDate: 2024-07-31 14:50:33 +0000 >> >> bhyve: Treat the COMMAND register for PCI passthru devices as emulated >> >> Don't pass through writes of the command register through to the >> physical device. These registers do not need to be in sync, and in >> some cases (e.g. when the guest is sizing the BAR and temporarily >> disables decoding), the states need to diverge. > > This seems to break MSI-X interrupts for a device that is passed through > to a VM. That is, the device generates an interrupt but the driver in > the VM never receives it. Reverting this change fixes the problem. Yes, https://reviews.freebsd.org/D46245 is what I have been using. It turns out the ppt(4) driver wasn't fully managing the command register. -- John Baldwin