git: ef9fc9609a1f - main - sys: Mark ACL conversion routines as __result_use_check

From: Ed Maste <emaste_at_FreeBSD.org>
Date: Thu, 15 Aug 2024 19:04:59 UTC
The branch main has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=ef9fc9609a1ff53047577aa7cf51246fc04c954b

commit ef9fc9609a1ff53047577aa7cf51246fc04c954b
Author:     Pierre Pronchery <pierre@freebsdfoundation.org>
AuthorDate: 2024-08-09 17:37:38 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2024-08-15 19:04:29 +0000

    sys: Mark ACL conversion routines as __result_use_check
    
    Both acl_copy_oldacl_into_acl() and acl_copy_acl_into_oldacl() may fail
    in some circumstances (e.g., acl.acl_cnt exceeding the capacity of
    OLDACL_MAX_ENTRIES).  This change marks both routines with
    __result_use_check, enforcing check for errors by the caller.
    
    Suggested by:   markj
    Reviewed by:    markj, emaste
    Sponsored by:   The FreeBSD Foundation
    Differential Revision: https://reviews.freebsd.org/D46254
---
 sys/sys/acl.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/sys/acl.h b/sys/sys/acl.h
index c119cfabef32..d4770667fcf5 100644
--- a/sys/sys/acl.h
+++ b/sys/sys/acl.h
@@ -309,9 +309,9 @@ void			acl_nfs4_compute_inherited_acl(
 			    const struct acl *parent_aclp,
 			    struct acl *child_aclp, mode_t mode,
 			    int file_owner_id, int is_directory);
-int			acl_copy_oldacl_into_acl(const struct oldacl *source,
+int __result_use_check	acl_copy_oldacl_into_acl(const struct oldacl *source,
 			    struct acl *dest);
-int			acl_copy_acl_into_oldacl(const struct acl *source,
+int __result_use_check	acl_copy_acl_into_oldacl(const struct acl *source,
 			    struct oldacl *dest);
 
 /*