From nobody Sun Aug 04 10:23:20 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WcFyc46Xmz5SXyr; Sun, 04 Aug 2024 10:23:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WcFyc2ynGz4CB1; Sun, 4 Aug 2024 10:23:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722767000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8jm8E8UBN+mirj/qfY8hWzz7XblUgDoq/MUw6qB+Oag=; b=UxMHdTECTxy6WtgI0Ic6srkkXBG+Ad568nrGiEkzyYFY0RpgFGO8+ro9ULtkVobpHAH82j 7ziJRHwEHaAT2tSToQMivRZxr0Fwxl8MWL5HGqcVJpVteWVCOFuXinsXoCBjyPo4YXe2EN ZXi+foi2JtaC1bLtz5tCSTimSby4R+Wvm/6ygc40RBUhbpcgzALrveGcg8sbm5Ja18Ly9Q zVuSI1h/3DFbclM8Un8dVDPS0FGE5MCsxgoRVS/XoVUgtZVD8bl6rA2+0DUjD7MBWkp3Yr LgIMnpt7UyWdmMPn5s1zbGezk2WcpBTfL0SqUnzmBwirsbyTlgZMxVhT8hTcIg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1722767000; a=rsa-sha256; cv=none; b=wmAuKEBdDBpHFOVj32CcZV8dKmXcooyqrnWSVX1qTg1lNjC6Cl5Cjl2AHFvhEaCGNELc+I KE2pzyRDAAionObW4W8Fiske+oGqF79a6C0ZqYhvUKvsRVcL3Ca59atiPbJ3xf6YFNb1Vt QV9aIiuBm/ETb+uJlY1CeGgbMejnPBbUjPZvn+s/oR31+FL1RfqEiCCXhCGfJgKqX34fid njdSwBslhsksuF9r+QnOPV0dyy1YXomnduGbFyQJ8O5RrEqw/64F+ykdWIq7SifsTAJZsE yisqzoCIWRRaANpfkgkRhuTAogfO7iC6mOAW++fM8pSuabRgkShPFFejSoT4qQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722767000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8jm8E8UBN+mirj/qfY8hWzz7XblUgDoq/MUw6qB+Oag=; b=phJAlkR/2CXWS7QqsvccCX2NWXRI1V/hjPSsS3uoZX3t0NIdyK3CVaaWgettIMjpEet1eJ jxCBIeW52hDV+2sPFIDNcGiyIU9J1ydxlqYAr8C834spwO7JOrsX+Gb5ff/2faZKguh1V6 NzArnq28uzkmdcOYoZ0VLY7Wqa1BV5PNbRQJqR2o/GnF0Q/r6zDmZRByiiZP6fsS/Y4O7T WSx3mdNhhcza3ME1v5baQRcRTU2j8I2d+ryQDfO0EipmIxLdjvXOfaoPqWOEFSS3IZz0/4 xmjUJQ65q2I9cB6XPbQMhHSBU9bxw5oUOToU04nErDavcy8dRKiaYa4AseD39Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WcFyc2ZB7zrdr; Sun, 4 Aug 2024 10:23:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 474ANKip045607; Sun, 4 Aug 2024 10:23:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 474ANKDP045604; Sun, 4 Aug 2024 10:23:20 GMT (envelope-from git) Date: Sun, 4 Aug 2024 10:23:20 GMT Message-Id: <202408041023.474ANKDP045604@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: e656c69b8d50 - stable/14 - Fix enum warning in heimdal List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e656c69b8d50ab13a08d315d49f289287b97f83a Auto-Submitted: auto-generated The branch stable/14 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=e656c69b8d50ab13a08d315d49f289287b97f83a commit e656c69b8d50ab13a08d315d49f289287b97f83a Author: Dimitry Andric AuthorDate: 2024-07-30 18:31:47 +0000 Commit: Dimitry Andric CommitDate: 2024-08-04 10:21:02 +0000 Fix enum warning in heimdal This fixes a clang 19 warning: crypto/heimdal/lib/krb5/deprecated.c:75:17: error: comparison of different enumeration types ('krb5_keytype' (aka 'enum ENCTYPE') and 'enum krb5_keytype_old') [-Werror,-Wenum-compare] 75 | if (keytype != KEYTYPE_DES || context->etypes_des == NULL) | ~~~~~~~ ^ ~~~~~~~~~~~ In https://github.com/heimdal/heimdal/commit/3bebbe5323 this was solved by adding a cast. That commit is rather large, so I'm only applying the one-liner here. MFC after: 3 days (cherry picked from commit 6f25b46721a18cf4f036d041e7e5d275800a00b3) --- crypto/heimdal/lib/krb5/deprecated.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/lib/krb5/deprecated.c b/crypto/heimdal/lib/krb5/deprecated.c index e7c0105ebf7f..02cf7614f932 100644 --- a/crypto/heimdal/lib/krb5/deprecated.c +++ b/crypto/heimdal/lib/krb5/deprecated.c @@ -72,7 +72,7 @@ krb5_keytype_to_enctypes_default (krb5_context context, unsigned int i, n; krb5_enctype *ret; - if (keytype != KEYTYPE_DES || context->etypes_des == NULL) + if (keytype != (krb5_keytype)KEYTYPE_DES || context->etypes_des == NULL) return krb5_keytype_to_enctypes (context, keytype, len, val); for (n = 0; context->etypes_des[n]; ++n)