Re: git: 6120673f7566 - main - tests: fix ATF_TESTS_PYTEST no clean build
Date: Sun, 22 Oct 2023 22:13:15 UTC
On Sat, Oct 21, 2023 at 09:07:26PM +0200, Dimitry Andric wrote:
D> > commit 6120673f7566c35023921540d2d682572d1bf1ce
D> > Author: Gleb Smirnoff <glebius@FreeBSD.org>
D> > AuthorDate: 2023-10-20 17:47:08 +0000
D> > Commit: Gleb Smirnoff <glebius@FreeBSD.org>
D> > CommitDate: 2023-10-20 17:47:08 +0000
D> >
D> > tests: fix ATF_TESTS_PYTEST no clean build
D> >
D> > The hack with .xtmp file was effectively making the make to
D> > ignore changes to the sources, breaking NO_CLEAN builds. The
D> > hack can be actually omitted as setting SCRIPTSNAME_${_T} for
D> > every test is sufficient to prevent renaming by bsd.prog.mk.
D> >
D> > Reviewed by: melifaro
D> > Differential Revision: https://reviews.freebsd.org/D42283
D>
D> This appears to break clean builds, in that it now deletes files
D> mentioned in ATF_TESTS_PYTEST in the _source_ directories, leaving your
D> git checkout looking as follows:
Oh shit... Sorry. :( When I come up with a better change, who would
be a good reviewer for the change?
Mark, thanks for reverting promptly.
--
Gleb Smirnoff