From nobody Thu Oct 19 15:02:35 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SB9tw4d9Nz4xY2D for ; Thu, 19 Oct 2023 15:02:48 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SB9tw3vZzz4c6W for ; Thu, 19 Oct 2023 15:02:48 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-40839807e82so5763885e9.0 for ; Thu, 19 Oct 2023 08:02:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697727767; x=1698332567; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GIiXoKdczDxAtPy81sfr9hQgf9DkYxIsJ1NAh9GEsNU=; b=vK5Yt5JsFVEk3s2jTZF7m32+JOfZzSl0aVJv2Wc8phZQPbI9cayHdc6baKLqJgfYa3 URkhsrpf4uFzTgBIbIVQmDY8BO1GWnw/jVp+tPh4nDP8Y65JLdvA384uCzGHzeqHMpTE dZhl2Bswq4zq4VvnAujAdhZ4pvfVuAoF1POHQ80U2LqctD2aUrLRqzoVfzaOa/TfucH0 BvpecCTpdcqtJakWqqiCKo+dCw7eFjSKPOdayWG6bCbSQvso3kNzpkphFuveItJq4AHw YZynxRdXs5XRM/goKYNOU/GhDLzv97ZMGgpN2qdTVgusK1dRdvVV4GICq3X+5t6oZIDT 1beg== X-Gm-Message-State: AOJu0Yz8dII+LI/1EryBQ2GnKPCp/qF4tqg5YZbIxYKiq5YaID8SgpNo Wvd8DKtsdlClgz6Cjt1VfyHbEDmIzD4BWg6dpsAByQ== X-Google-Smtp-Source: AGHT+IEtqPAGcADh5pXOXFCWPLERDzlM6ILACTZJSIEsHl2iiyLRTDKs+9v53FwHsJB2LUycrF9tUg== X-Received: by 2002:a05:600c:4747:b0:408:3634:b81e with SMTP id w7-20020a05600c474700b004083634b81emr2082761wmo.13.1697727766343; Thu, 19 Oct 2023 08:02:46 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id h5-20020a05600c350500b003fc0505be19sm4682425wmq.37.2023.10.19.08.02.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Oct 2023 08:02:45 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.100.2.1.4\)) Subject: Re: git: 9eff6390718d - main - pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h From: Jessica Clarke In-Reply-To: Date: Thu, 19 Oct 2023 16:02:35 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <1EB17D31-16CB-44D2-A19E-6CC9699156D1@freebsd.org> References: <202310191420.39JEKitw071108@gitrepo.freebsd.org> <1DDF7B7C-9137-48F4-80C9-FDCC82F47118@freebsd.org> To: Kristof Provost X-Mailer: Apple Mail (2.3774.100.2.1.4) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4SB9tw3vZzz4c6W On 19 Oct 2023, at 15:56, Kristof Provost wrote: >=20 > On 19 Oct 2023, at 16:41, Jessica Clarke wrote: >> On 19 Oct 2023, at 15:20, Kristof Provost wrote: >>>=20 >>> The branch main has been updated by kp: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D9eff6390718d0fa67dffc6cd830b0bc6= b815e8c4 >>>=20 >>> commit 9eff6390718d0fa67dffc6cd830b0bc6b815e8c4 >>> Author: Kristof Provost >>> AuthorDate: 2023-10-19 10:06:29 +0000 >>> Commit: Kristof Provost >>> CommitDate: 2023-10-19 14:19:39 +0000 >>>=20 >>> pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h >>>=20 >>> When userspace includes pfvar.h it doesn't get the kernel's = COMPAT_* >>> defines, so we end up not having required symbols in userspace. = This >>> caused the libpfctl port to fail to build. >>>=20 >>> libpfctl will be updated to use the new netlink-based state export = code >>> soon, which will also fix thix build issue. >>>=20 >>> Sponsored by: Rubicon Communications, LLC ("Netgate") >>=20 >> That=E2=80=99s normally a feature to stop userspace using deprecated = things. >> Will you be reverting this once libpfctl is fixed? One could also = hack >> libpfctl instead to define COMPAT_FREEBSD14 temporarily (IIRC = that=E2=80=99s >> what was done for kbdcontrol to allow it to run on old kernels). >>=20 > I wasn=E2=80=99t planning on that, no. The libpfctl port fix should = land soon, but I figured that it=E2=80=99d be better to keep the = definitions, because userspace doesn=E2=80=99t know if the kernel is = built with or without COMPAT_FREEBSD14. > I=E2=80=99m open to being persuaded that that=E2=80=99s a bad idea = though. Indeed it doesn=E2=80=99t, because it shouldn=E2=80=99t. The thinking is = that userspace should *never* explicitly use them, only the kernel to provide compatibility with binaries built against older versions. Deliberately exposing them to userspace is quite unusual and deemed generally dodgy. Jess > Long-term (i.e. by freebsd 16) the plan is for all of these ioctls to = go away (so the code for them will stay in 15, but not be in 16), but = that does depend on me doing a fair bit of work before then. >=20 > Best regards, > Kristof