From nobody Fri Oct 13 23:53:45 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S6jyK5LGMz4wyJq; Fri, 13 Oct 2023 23:53:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S6jyK3c2Dz3JVJ; Fri, 13 Oct 2023 23:53:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697241225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hIrpPhccWzHXUQ1Nhug/ovvfJkfJ49aezw7LS5L1bGk=; b=WLLEtbK5MkcsusX3iWkq2fsm0X8+GtkxcWAt6mIZdG4qQ5TUY7YO/0vdeC9fy/reGbHFd9 RNrIuz8RpuYL7nCrKWNWSTVW4BBsYrXKpD5fdJ8WuTyOp3DUCNlzod6mLwSgax0Hysu9Zi U6XX+J0/MwPcHceV1jKV+VgOjizuoFj4I1zxjgj0Qd2icFTEPKbBX8D2j6ASeZgjj+b0jH OckIToXwAO8Iyx8mdgZgAdo7CTunhc1ydTKdJ4pcHt9eOpEb+L0C8Ftr+Pee3slw2MUhBH 9fkCz6tLxVXMmD4Hqq8StDmFnxc+YSfr8r0fsfzkCZA0+AS13xV2fwZcZfUNDA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697241225; a=rsa-sha256; cv=none; b=JRr+uQ46JciMtffLoDbilKLoGW7pJD2xbHSQ39qg7tvVQWFpuZBgsvP36E8ZOGSuRRbldh bn0SXINWkpxe+CCx4m4F+NckqxN8rMbU0ifkeAvo4E6w0/OVq5OJfsQ+W4Rx43KsNGsQ1k Lwvw5b7DVCqVWIr4FnB519Sx1LnqXdIaA+vjTnJoG8rt4pb4bSpFZ+Yu0QDn/oqbPxFqwO +AoAN7/BXbhvOCg5aDmiAVJSwsHhaBjwbdBi9xDMSKrQaQEaYiQWWL3TnmFM2/z4lXoDdV cGG7ub9PcUH1jBjG/OGB2KlpM3kTNW0/7W5fAdNZF0s6G1ZFD2jHdDiSzumUhQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697241225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hIrpPhccWzHXUQ1Nhug/ovvfJkfJ49aezw7LS5L1bGk=; b=who0o9BFdDt6mqagUCuposqaRxezBs/IyvLEdh9Lxgz5JaxUTTRL7gaHMEECB4GCsxgJEW K4HMjPZOuTdcyX7HgvEJs46F3wg61ymrLdSwOdvkJsHKZGoeL2qLEpVc7dj5Nsk15Xy7q1 pNtH49BUyZJ7f+NDlXYwRI+0Q3BMAVWR0kEPdQgkVlNvaIdsxm58ivnPcHrGcn7V/ivQGt hkPZpWKiV15lCL19zfukTs23PXyS2hsxODOvAYHJV9x2GJW8WVdGyPL4nmq0M+mCKwEmUB eSOzLmydwXzoSWEH2dd0B18s3xHsTofEQi2379eUpWXkICorvOpqa9BvwMOYqg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S6jyK2hctz17nb; Fri, 13 Oct 2023 23:53:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39DNrjSI031808; Fri, 13 Oct 2023 23:53:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39DNrjEA031805; Fri, 13 Oct 2023 23:53:45 GMT (envelope-from git) Date: Fri, 13 Oct 2023 23:53:45 GMT Message-Id: <202310132353.39DNrjEA031805@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: 564cd5a91540 - stable/13 - vfs cache: Drop known argument of internal cache_recalc_neg_min() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 564cd5a91540246ab13f8dd3cbc3058264c06755 Auto-Submitted: auto-generated The branch stable/13 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=564cd5a91540246ab13f8dd3cbc3058264c06755 commit 564cd5a91540246ab13f8dd3cbc3058264c06755 Author: Olivier Certner AuthorDate: 2023-09-22 21:25:41 +0000 Commit: Mateusz Guzik CommitDate: 2023-10-13 23:48:11 +0000 vfs cache: Drop known argument of internal cache_recalc_neg_min() 'ncnegminpct' is to be passed always, so just drop the unneeded parameter. Sponsored by: The FreeBSD Foundation Reviewed by: mjg Differential Revision: https://reviews.freebsd.org/D41763 (cherry picked from commit 02ef039c284b8a7b1ea40f5f9a851a3cb6af5b31) --- sys/kern/vfs_cache.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index a50e8010fb88..a98b0e5ce411 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -994,10 +994,10 @@ SYSCTL_PROC(_vfs_cache, OID_AUTO, nchstats, CTLTYPE_OPAQUE | CTLFLAG_RD | "VFS cache effectiveness statistics"); static void -cache_recalc_neg_min(u_int val) +cache_recalc_neg_min(void) { - neg_min = (ncsize * val) / 100; + neg_min = (ncsize * ncnegminpct) / 100; } static int @@ -1016,7 +1016,7 @@ sysctl_negminpct(SYSCTL_HANDLER_ARGS) if (val < 0 || val > 99) return (EINVAL); ncnegminpct = val; - cache_recalc_neg_min(val); + cache_recalc_neg_min(); return (0); } @@ -2656,7 +2656,7 @@ nchinit(void *dummy __unused) VFS_SMR_ZONE_SET(cache_zone_large_ts); ncsize = desiredvnodes * ncsizefactor; - cache_recalc_neg_min(ncnegminpct); + cache_recalc_neg_min(); nchashtbl = nchinittbl(desiredvnodes * 2, &nchash); ncbuckethash = cache_roundup_2(mp_ncpus * mp_ncpus) - 1; if (ncbuckethash < 7) /* arbitrarily chosen to avoid having one lock */ @@ -2800,7 +2800,7 @@ cache_changesize(u_long newmaxvnodes) } } ncsize = newncsize; - cache_recalc_neg_min(ncnegminpct); + cache_recalc_neg_min(); cache_changesize_set_new(new_nchashtbl, new_nchash); cache_unlock_all_buckets(); cache_unlock_all_vnodes();